urdt/ussd
5
0
Fork 1
Code Issues 41 Pull Requests Actions Packages Projects Releases Wiki Activity

postgres-switch #113

Merged
lash merged 14 commits from postgres-switch into master 2024-10-22 16:04:56 +02:00
Conversation 2 Commits 14 Files Changed 11 +191 -32
Alfred-mk commented 2024-10-15 22:57:16 +02:00
Member
Copy Link
  • Add and use env variables
  • Add the option of switching to postgres using the db flag
- Add and use env variables - Add the option of switching to postgres using the db flag
Alfred-mk added 2 commits 2024-10-15 22:57:16 +02:00
added an env.example file 51122d0fc5
use env variables 09eac03e10
Alfred-mk added 1 commit 2024-10-16 10:38:49 +02:00
use go-vise v0.2.0 d8db8df643
Alfred-mk added 2 commits 2024-10-17 11:48:03 +02:00
added a db flag and Database to the context 1aeb18379c
switch to postgres once the flag is set 4968cdff37
Alfred-mk added 1 commit 2024-10-17 11:49:44 +02:00
Merge branch 'master' into postgres-switch a759f47c8e
Alfred-mk changed title from WIP: postgres-switch to postgres-switch 2024-10-17 11:50:14 +02:00
Alfred-mk requested review from lash 2024-10-17 11:50:30 +02:00
Alfred-mk added 1 commit 2024-10-17 11:55:52 +02:00
polished code 6727bd3769
Alfred-mk added 1 commit 2024-10-17 14:35:48 +02:00
updated the vise version to include the updated column fd8bfae8c7
Alfred-mk added a new dependency 2024-10-18 09:27:53 +02:00
#110 Implement postgres db alternative
Alfred-mk added a new dependency 2024-10-18 10:48:37 +02:00
#19 Make config settable with env vars
lash requested changes 2024-10-18 15:49:47 +02:00
initializers/loadEnvVariables.go Outdated
@@ -0,0 +1,34 @@
package initializers
lash commented 2024-10-18 15:44:43 +02:00
Owner
Copy Link

I think convention is that file names in go be kept simple words. load.go will do

I think convention is that file names in go be kept simple words. load.go will do
Alfred-mk marked this conversation as resolved
internal/storage/postgres.go Outdated
@@ -0,0 +12,4 @@
pdbC map[string]chan db.Db
)
type ThreadPostgresDb struct {
lash commented 2024-10-18 15:46:59 +02:00
Owner
Copy Link

i dont think you need the thread abstraction here, because the pg implementation used is already a managed connection pool. did you try it without?

i dont think you need the thread abstraction here, because the pg implementation used is already a managed connection pool. did you try it without?
Alfred-mk marked this conversation as resolved
internal/storage/storageservice.go Outdated
@@ -60,1 +71,4 @@
return nil, fmt.Errorf("failed to select the database")
}
if database == "postgres" {
lash commented 2024-10-18 15:49:41 +02:00
Owner
Copy Link

postgres shouold be implemented for both userdatatstore and state store

postgres shouold be implemented for both userdatatstore and state store
Alfred-mk marked this conversation as resolved
Alfred-mk added 1 commit 2024-10-19 12:41:55 +02:00
rename file 00a2beae50
Alfred-mk added 1 commit 2024-10-19 13:51:50 +02:00
remove thread abstraction from postgres f13f5996c1
Alfred-mk added 1 commit 2024-10-19 14:27:30 +02:00
implement postgres for the state store a40fc37da4
Alfred-mk added 1 commit 2024-10-19 14:29:29 +02:00
Merge branch 'master' into postgres-switch fb0d2db156
Alfred-mk requested review from lash 2024-10-19 14:31:41 +02:00
lash requested changes 2024-10-19 16:13:16 +02:00
internal/storage/postgres.go Outdated
@@ -0,0 +1,74 @@
package storage
lash commented 2024-10-19 16:13:14 +02:00
Owner
Copy Link

as we spoke about in meeting, i believe this file could be removed, and use the db from go-vise directly.

as we spoke about in meeting, i believe this file could be removed, and use the db from go-vise directly.
Alfred-mk commented 2024-10-19 22:07:43 +02:00
Author
Member
Copy Link

Confirmed. This has been done

Confirmed. This has been done
Alfred-mk marked this conversation as resolved
Alfred-mk added 1 commit 2024-10-19 22:07:17 +02:00
use postgres directly from go-vise 9f562fe53e
Alfred-mk requested review from lash 2024-10-19 22:08:20 +02:00
Alfred-mk added 1 commit 2024-10-21 08:22:35 +02:00
include the Database in context 415c807464
lash removed a dependency 2024-10-22 16:04:47 +02:00
#19 Make config settable with env vars
lash removed a dependency 2024-10-22 16:04:52 +02:00
#110 Implement postgres db alternative
lash merged commit 59d0446020 into master 2024-10-22 16:04:56 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Activity
Doing
An item actively being worked on currently
Activity
Hold
Not being actively worked on
Activity
Proposal
A proposal for a new feature or enhancement
Activity
QA
Ready for QA testing
Activity
Validate
Dev team validating changes
Runner
AT
Runner
CLI
Runner
HTTP
Runner
SSH
cleanup
devops
documentation
easypeasy
A task that can be completed with little effort
 exchange
relating to swapping of assets and offramps
 i18n
Languages and translations
 legacy
Legacy features from the old ussd system to be ported
 meta
container for other issues
 migration
optimization
privilege
features that have to do with special, privileged axx
 refactor
smell
Code smell
 support
transparency and help with exception states
 tooling
ux
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk carlos kamikazechaser lash willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: urdt/ussd#113
Delete Branch "postgres-switch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?