urdt/ussd
5
0
Fork 0
Code Issues 59 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

Validate aliases, addresses and phone numbers in the send menu #176

Merged
kamikazechaser merged 14 commits from alias-address-validation into master 2024-11-26 07:24:57 +01:00
Conversation 0 Commits 14 Files Changed 9 +186 -41
Alfred-mk commented 2024-11-20 14:16:07 +01:00
Member
Copy Link
  • Update the phone number regex
  • Check whether the recipient is a valid phone number, alias or address
- Update the phone number regex - Check whether the recipient is a valid phone number, alias or address
Alfred-mk added 1 commit 2024-11-20 14:16:08 +01:00
Alfred-mk changed title from updated the regex to match all Kenyan numbers to WIP: updated the regex to match all Kenyan numbers 2024-11-20 14:16:17 +01:00
Alfred-mk added 5 commits 2024-11-20 16:37:45 +01:00
Alfred-mk changed title from WIP: updated the regex to match all Kenyan numbers to WIP: Validate aliases, addresses and phone numbers in the send menu 2024-11-20 16:38:31 +01:00
Alfred-mk added 1 commit 2024-11-20 16:45:45 +01:00
Alfred-mk added 1 commit 2024-11-20 16:56:04 +01:00
Alfred-mk changed title from WIP: Validate aliases, addresses and phone numbers in the send menu to Validate aliases, addresses and phone numbers in the send menu 2024-11-20 17:02:42 +01:00
Alfred-mk requested review from lash 2024-11-20 18:03:57 +01:00
lash requested changes 2024-11-22 02:16:34 +01:00
common/recipient.go
@ -0,0 +7,4 @@
// Define the regex patterns as constants
const (
phoneRegex = `^(?:\+254|254|0)?((?:7[0-9]{8})|(?:1[01][0-9]{7}))$`
lash commented 2024-11-22 02:11:08 +01:00
Owner
Copy Link

I think phone regex should be check formatting but not specifics; that is, country code should be filtered elsewhere.

I think phone regex should be check formatting but not specifics; that is, country code should be filtered elsewhere.
common/recipient.go
@ -0,0 +9,4 @@
const (
phoneRegex = `^(?:\+254|254|0)?((?:7[0-9]{8})|(?:1[01][0-9]{7}))$`
addressRegex = `^0x[a-fA-F0-9]{40}$`
aliasRegex = `^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+$`
lash commented 2024-11-22 02:13:22 +01:00
Owner
Copy Link

alias is same format as email? May want to have a look at https://emailregex.com/

alias is same format as email? May want to have a look at https://emailregex.com/
Alfred-mk commented 2024-11-22 11:26:17 +01:00
Author
Member
Copy Link

No, it is not. This is the format that I picked from Sarafu's website

Your shortcode is a unique identifier that can be used by others to send you vouchers. It must be in the following format name@area

No, it is not. This is the format that I picked from Sarafu's website `Your shortcode is a unique identifier that can be used by others to send you vouchers. It must be in the following format name@area`
kamikazechaser commented 2024-11-25 11:26:45 +01:00
Owner
Copy Link

@Alfred-mk See https://github.com/grassrootseconomics/sarafu.network/issues/174 for Alias requirements

@Alfred-mk See https://github.com/grassrootseconomics/sarafu.network/issues/174 for Alias requirements
kamikazechaser marked this conversation as resolved
internal/handlers/ussd/menuhandler.go
@ -916,2 +908,4 @@
recipient := string(input)
if recipient != "0" {
lash commented 2024-11-22 02:14:38 +01:00
Owner
Copy Link

when is recipient "0" ?

when is recipient "0" ?
Alfred-mk commented 2024-11-22 11:22:42 +01:00
Author
Member
Copy Link

This is related to #126 (comment)

This is related to https://git.grassecon.net/urdt/ussd/pulls/126#issuecomment-2709
Alfred-mk added 1 commit 2024-11-24 14:48:27 +01:00
Alfred-mk added 2 commits 2024-11-25 10:00:00 +01:00
kamikazechaser reviewed 2024-11-25 11:30:57 +01:00
common/recipient.go Outdated
@ -0,0 +49,4 @@
}
// FormatPhoneNumber formats a Kenyan phone number to "254xxxxxxxx".
func FormatPhoneNumber(phone string) (string, error) {
kamikazechaser commented 2024-11-25 11:30:57 +01:00
Owner
Copy Link

It should be + prefixed. Why? That is how we save it in our common db (graph) and also how most, if not all, API providers expect the phone number.

It should be + prefixed. Why? That is how we save it in our common db (graph) and also how most, if not all, API providers expect the phone number.
Alfred-mk commented 2024-11-25 12:44:13 +01:00
Author
Member
Copy Link

Thanks, this has been updated

Thanks, this has been updated
kamikazechaser marked this conversation as resolved
Alfred-mk added 1 commit 2024-11-25 12:37:47 +01:00
Alfred-mk added 1 commit 2024-11-25 13:02:37 +01:00
Alfred-mk added 1 commit 2024-11-26 07:16:26 +01:00
kamikazechaser merged commit 08ff1056d7 into master 2024-11-26 07:24:57 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
lash
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Activity:Doing

An item actively being worked on currently

  
Activity:Proposal

A proposal for a new feature or enhancement

  
Runner
AT

  
Runner
CLI

  
Runner
HTTP

  
cleanup

   
devops

   
easypeasy

A task that can be completed with little effort

  
exchange

relating to swapping of assets and offramps

  
l8ter

   
legacy

Legacy features from the old ussd system to be ported

  
optimization

   
privilege

features that have to do with special, privileged axx

  
refactor

   
smell

Code smell

  
support

transparency and help with exception states

  
tooling

   
ux
No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Activity:Doing
Activity:Proposal
Runner
AT
Runner
CLI
Runner
HTTP
cleanup
devops
easypeasy
exchange
l8ter
legacy
optimization
privilege
refactor
smell
support
tooling
ux
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: urdt/ussd#176
No description provided.
Delete Branch "alias-address-validation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?