urdt/ussd
5
0
Fork 1
Code Issues 41 Pull Requests Actions Packages Projects Releases Wiki Activity

Restart menu when ussd session expires #201

New Issue
Closed
opened 2024-12-04 16:49:22 +01:00 by lash · 7 comments
lash commented 2024-12-04 16:49:22 +01:00
Owner
Copy Link

User should be restarted from main menu when the AT session expires.

On new session, request id will change and input string will reset.

Most likely, the appropriate solution involves flushing the state bytecode in the _first handler, and replace it with MOVE ^ if simply an empty bytecode will not be sufficient.

User should be restarted from main menu when the AT session expires. On new session, request id will change and input string will reset. Most likely, the appropriate solution involves _flushing_ the state bytecode in the `_first` handler, and replace it with `MOVE ^` _if_ simply an empty bytecode will not be sufficient.
lash added the Kind/Feature
Runner
AT
ux labels 2024-12-04 16:49:36 +01:00
lash added the
Priority
Medium
 label 2024-12-04 16:52:58 +01:00
Alfred-mk commented 2024-12-08 06:47:06 +01:00
Member
Copy Link

image

@lash I have tried resetting the state for the failed account sample (my number) but the engine kept bailing before running any of the handler code. This was a bit problematic trying to flush the state from the USSD code.

However, I noted that the cause of the engine bailing was the FLAG_TERMINATE flag, under vm>runner.go line 84

Resetting the flag before it returns enabled me to access the menu.

Can this be a solution outside the USSD (changing go-vise)?

![image](/attachments/3558d550-aa59-4398-8a7f-38e678833b98) @lash I have tried resetting the state for the failed account sample (my number) but the engine kept bailing before running any of the handler code. This was a bit problematic trying to flush the state from the USSD code. However, I noted that the cause of the engine bailing was the FLAG_TERMINATE flag, under vm>runner.go line 84 Resetting the flag before it returns enabled me to access the menu. Can this be a solution outside the USSD (changing go-vise)?
image.png
88 KiB
lash commented 2024-12-08 22:27:57 +01:00
Author
Owner
Copy Link

@Alfred-mk is the FLAG_TERMINATE set in your stored state?

@Alfred-mk is the `FLAG_TERMINATE` set in your stored state?
Alfred-mk commented 2024-12-09 04:56:26 +01:00
Member
Copy Link

Yes it is set. Resetting it allows the menu to go back to the main node

Yes it is set. Resetting it allows the menu to go back to the main node
lash commented 2024-12-09 16:31:20 +01:00
Author
Owner
Copy Link

@Alfred-mk so this is an abnormal sitation. Probably it came about because of an unclean exit, and for this kind of case we are going to need a manual tool to force restart from top as a last resort, i.e. #202

As for your account, the safe way to recover it would be to call vise.state.State.Restart() (which would be the same the tool should do)

@Alfred-mk so this is an abnormal sitation. Probably it came about because of an unclean exit, and for this kind of case we are going to need a manual tool to force restart from top as a last resort, i.e. https://git.grassecon.net/urdt/ussd/issues/202 As for your account, the safe way to recover it would be to call `vise.state.State.Restart()` (which would be the same the tool should do)
lash added this to the 2024.12.12 milestone 2024-12-10 11:21:01 +01:00
lash changed title from Force restart of state on different request id to Restart menu when ussd session expires 2024-12-10 11:22:08 +01:00
lash added the
Activity
Doing
 label 2024-12-10 11:22:19 +01:00
lash modified the milestone from 2024.12.12 to 2024.12.19 2024-12-12 17:38:08 +01:00
lash removed this from the 2024.12.19 milestone 2024-12-12 17:38:14 +01:00
lash self-assigned this 2024-12-30 09:15:57 +01:00
Alfred-mk was assigned by lash 2024-12-30 09:15:57 +01:00
lash commented 2024-12-30 09:18:51 +01:00
Author
Owner
Copy Link

persister retrieved from menustorageservice does not contain state (ref @Alfred-mk )

persister retrieved from menustorageservice does not contain state (ref @Alfred-mk )
Alfred-mk commented 2024-12-31 03:16:41 +01:00
Member
Copy Link

The persister retrieved from menustorageservice ...

func (ms *MenuStorageService) GetPersister(ctx context.Context) (*persist.Persister, error) {
	stateStore, err := ms.GetStateStore(ctx)
	if err != nil {
		return nil, err
	}

	pr := persist.NewPersister(stateStore)
	logg.TraceCtxf(ctx, "menu storage service", "persist", pr, "store", stateStore)
	return pr, nil
}

... has a nil state and cache

One can only access the state once the engine is run

The persister retrieved from menustorageservice ... ``` func (ms *MenuStorageService) GetPersister(ctx context.Context) (*persist.Persister, error) { stateStore, err := ms.GetStateStore(ctx) if err != nil { return nil, err } pr := persist.NewPersister(stateStore) logg.TraceCtxf(ctx, "menu storage service", "persist", pr, "store", stateStore) return pr, nil } ``` ... has a nil state and cache One can only access the state once the engine is run
lash commented 2024-12-31 10:07:58 +01:00
Author
Owner
Copy Link

resolved by @Alfred-mk

resolved by @Alfred-mk
lash closed this issue 2024-12-31 10:07:58 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Activity
Doing
An item actively being worked on currently
Activity
Hold
Not being actively worked on
Activity
Proposal
A proposal for a new feature or enhancement
Activity
QA
Ready for QA testing
Activity
Validate
Dev team validating changes
Runner
AT
Runner
CLI
Runner
HTTP
Runner
SSH
cleanup
devops
documentation
easypeasy
A task that can be completed with little effort
 exchange
relating to swapping of assets and offramps
 i18n
Languages and translations
 legacy
Legacy features from the old ussd system to be ported
 meta
container for other issues
 migration
optimization
privilege
features that have to do with special, privileged axx
 refactor
smell
Code smell
 support
transparency and help with exception states
 tooling
ux
No Label Kind/Feature
Priority
Medium
Activity
Doing
Runner
AT
 ux
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk carlos kamikazechaser lash willruddick
No Assignees lash Alfred-mk
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: urdt/ussd#201
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?