urdt/ussd
5
0
Fork 1
Code Issues 41 Pull Requests Actions Packages Projects Releases Wiki Activity

add-space-after-colon #211

Merged
lash merged 20 commits from add-space-after-colon into master 2024-12-19 11:35:14 +01:00
Conversation 3 Commits 20 Files Changed 8 +101 -57
Alfred-mk commented 2024-12-12 13:26:52 +01:00
Member
Copy Link
  • Add a space after the colon for each menu item
  • Capitalize the first letter for custom defined menu items
- Add a space after the colon for each menu item - Capitalize the first letter for custom defined menu items
Alfred-mk added 6 commits 2024-12-12 13:26:52 +01:00
Capitalize the transfer statement details 3129e8210e
Add a space after the colon for vouchers b1e4b63c6a
Capitalize statement details and add a space after the colon 6f3b30e2fe
updated the description of the GetTransactionsList function 1a4ee0d3e1
updated failed menuhandler_test 2383e8ead3
update to the latest go-vise changes e05f8e7291
Alfred-mk changed title from add-space-after-colon to WIP: add-space-after-colon 2024-12-12 13:27:00 +01:00
Alfred-mk added 2 commits 2024-12-12 19:12:53 +01:00
use latest commits from go-vise 0d7f7aaca1
add the custom separator to the menu 6cc285d1e8
Alfred-mk changed title from WIP: add-space-after-colon to add-space-after-colon 2024-12-12 19:17:12 +01:00
lash requested changes 2024-12-12 20:53:52 +01:00
cmd/africastalking/main.go Outdated
@@ -122,6 +123,7 @@ func main() {
flag.UintVar(&size, "s", 160, "max size of output")
flag.StringVar(&host, "h", initializers.GetEnv("HOST", "127.0.0.1"), "http host")
flag.UintVar(&port, "p", initializers.GetEnvUint("PORT", 7123), "http port")
flag.StringVar(&separator, "sep", ": ", "custom separator for the menu")
lash commented 2024-12-12 20:52:09 +01:00
Owner
Copy Link

this is probably more a config thing than an arg thing?

this is probably more a config thing than an arg thing?
Alfred-mk commented 2024-12-12 23:11:33 +01:00
Author
Member
Copy Link

This has been resolved

This has been resolved
Alfred-mk marked this conversation as resolved
common/vouchers.go Outdated
@@ -25,3 +25,3 @@
for i, h := range holdings {
symbols = append(symbols, fmt.Sprintf("%d:%s", i+1, h.TokenSymbol))
symbols = append(symbols, fmt.Sprintf("%d: %s", i+1, h.TokenSymbol))
lash commented 2024-12-12 20:53:08 +01:00
Owner
Copy Link

won't this break if separator is set to something else by config/arg?

won't this break if separator is set to something else by config/arg?
Alfred-mk marked this conversation as resolved
internal/handlers/ussd/menuhandler.go Outdated
@@ -1901,3 +1901,3 @@
}
formattedTransactions = append(formattedTransactions, fmt.Sprintf("%d:%s %s %s %s", i+1, status, value, sym, date))
formattedTransactions = append(formattedTransactions, fmt.Sprintf("%d: %s %s %s %s", i+1, status, value, sym, date))
lash commented 2024-12-12 20:53:47 +01:00
Owner
Copy Link

same here, will break

same here, will break
Alfred-mk commented 2024-12-13 09:44:28 +01:00
Author
Member
Copy Link

This has been resolved

This has been resolved
Alfred-mk added 1 commit 2024-12-12 23:11:12 +01:00
set the separator as a config and not an arg f38ea59569
Alfred-mk changed title from add-space-after-colon to WIP: add-space-after-colon 2024-12-13 08:54:03 +01:00
Alfred-mk added 4 commits 2024-12-13 09:44:10 +01:00
set the separator as a var and add it to the context 64c1fe5276
properly format the vouchers df5e5f1a4b
use the MenuSeparator 5cd791aae7
updated tests 7aea2af9a1
Alfred-mk changed title from WIP: add-space-after-colon to add-space-after-colon 2024-12-13 09:44:38 +01:00
lash requested changes 2024-12-13 09:52:12 +01:00
internal/handlers/ussd/menuhandler.go Outdated
@@ -1676,6 +1676,11 @@ func (h *Handlers) CheckVouchers(ctx context.Context, sym string, input []byte)
func (h *Handlers) GetVoucherList(ctx context.Context, sym string, input []byte) (resource.Result, error) {
var res resource.Result
menuSeparator, ok := ctx.Value("MenuSeparator").(string)
lash commented 2024-12-13 09:51:43 +01:00
Owner
Copy Link

why wouldnt this be set directly as a property in the handler?

why wouldnt this be set directly as a property in the handler?
Alfred-mk commented 2024-12-13 11:19:54 +01:00
Author
Member
Copy Link

It would be easier setting it in the context for use by downstream functions, similar to how the database is set.

Also. it won't be used by most of the handler functions. It's only usable by functions that generate custom menu items (such as the voucher list and transfers list)

It would be easier setting it in the context for use by downstream functions, similar to how the database is set. Also. it won't be used by most of the handler functions. It's only usable by functions that generate custom menu items (such as the voucher list and transfers list)
lash commented 2024-12-13 16:23:46 +01:00
Owner
Copy Link

ref phone conversation, let store a function pointer in the handlers that does the translation with the separator selected :)

ref phone conversation, let store a function pointer in the handlers that does the translation with the separator selected :)
Alfred-mk commented 2024-12-18 20:35:04 +01:00
Author
Member
Copy Link

This has been done. The function is passed from the LocalHandlerService to the Handlers

This has been done. The function is passed from the LocalHandlerService to the Handlers
Alfred-mk changed title from add-space-after-colon to WIP: add-space-after-colon 2024-12-18 08:12:20 +01:00
Alfred-mk added 3 commits 2024-12-18 19:59:17 +01:00
remove the MenuSeparator from the context 17ba6a06ba
add the replaceSeparator func and pass it to the Handler struct d08afff443
use the replaceSeparator func to format the generated menus fda68231ea
Alfred-mk added 2 commits 2024-12-18 20:25:54 +01:00
updated test ecfdab47a8
use a common mockReplaceSeparator func 055c2db790
Alfred-mk added 1 commit 2024-12-18 20:30:48 +01:00
Merge branch 'master' into add-space-after-colon 97fcdda12f
Alfred-mk changed title from WIP: add-space-after-colon to add-space-after-colon 2024-12-18 20:35:12 +01:00
lash requested changes 2024-12-19 09:42:31 +01:00
internal/handlers/ussd/menuhandler.go Outdated
@@ -102,0 +100,4 @@
accountService: accountService,
prefixDb: prefixDb,
profile: &models.Profile{Max: 6},
ReplaceSeparator: replaceSeparator,
lash commented 2024-12-19 09:40:45 +01:00
Owner
Copy Link

Let's name it ReplaceSeparatorFunc

Let's name it `ReplaceSeparatorFunc`
Alfred-mk commented 2024-12-19 11:33:13 +01:00
Author
Member
Copy Link

This has been done

This has been done
Alfred-mk added 1 commit 2024-12-19 11:33:02 +01:00
rename the function to ReplaceSeparatorFunc 1292851226
lash merged commit 235af3519d into master 2024-12-19 11:35:14 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Activity
Doing
An item actively being worked on currently
Activity
Hold
Not being actively worked on
Activity
Proposal
A proposal for a new feature or enhancement
Activity
QA
Ready for QA testing
Activity
Validate
Dev team validating changes
Runner
AT
Runner
CLI
Runner
HTTP
Runner
SSH
cleanup
devops
documentation
easypeasy
A task that can be completed with little effort
 exchange
relating to swapping of assets and offramps
 i18n
Languages and translations
 legacy
Legacy features from the old ussd system to be ported
 meta
container for other issues
 migration
optimization
privilege
features that have to do with special, privileged axx
 refactor
smell
Code smell
 support
transparency and help with exception states
 tooling
ux
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk carlos kamikazechaser lash willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: urdt/ussd#211
Delete Branch "add-space-after-colon"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?