urdt/ussd
5
0
Fork 0
Code Issues 33 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

wip-flag-migration #28

Merged
Alfred-mk merged 44 commits from wip-flag-migration into master 2024-09-04 11:25:34 +02:00
Conversation 0 Commits 44 Files Changed 22 +577 -381
lash commented 2024-09-02 16:45:19 +02:00
Owner
Copy Link
No description provided.
lash added 24 commits 2024-09-02 16:45:19 +02:00
Alfred-mk added 1 commit 2024-09-02 20:07:14 +02:00
carlos added 4 commits 2024-09-02 20:12:20 +02:00
lash reviewed 2024-09-03 00:32:23 +02:00
lash left a comment
Author
Owner
Copy Link

Silly, I made the pull request so the review can only be marked as comment...

Silly, I made the pull request so the review can only be marked as comment...
cmd/main.go Outdated
@ -54,0 +48,4 @@
}
// Register all flags loaded from pp.csv
flagKeys := []string{
lash commented 2024-09-03 00:11:12 +02:00
Author
Owner
Copy Link

these flags should be loaded not hardcoded.

these flags should be loaded not hardcoded.
Alfred-mk marked this conversation as resolved
cmd/main.go Outdated
@ -54,0 +67,4 @@
"flag_incorrect_date_format",
}
for _, key := range flagKeys {
lash commented 2024-09-03 00:11:45 +02:00
Author
Owner
Copy Link

iterate on csv lines and populate with rows 2 and 3...

iterate on csv lines and populate with rows 2 and 3...
Alfred-mk marked this conversation as resolved
internal/handlers/ussd/menuhandler.go Outdated
@ -38,2 +66,3 @@
func NewHandlers(path string, st *state.State) *Handlers {
func NewHandlers(dir string, st *state.State) (*Handlers, error) {
db, err := gdbm.Open(dbFile, gdbm.ModeWrcreat)
lash commented 2024-09-03 00:16:48 +02:00
Author
Owner
Copy Link

FYI this will truncate the file on every open.

... but lets not spend time on that, as it needs to be changed to the new gdbm implementation anyway.

FYI this will truncate the file on every open. ... but lets not spend time on that, as it needs to be changed to the new gdbm implementation anyway.
carlos commented 2024-09-03 19:11:53 +02:00
Member
Copy Link

So a question on this,we want to be able to keep a reference to the file created for each session and be able to initialize a database instance depending on its existence.So we have this code and it still seems to be removing the previously stored information when it is opened with mode ModeWriter .A fix for the time being for this will be appreciated because the refactoring depends on storing the user information to gdbm.

filename := path.Join(scriptDir, sessionId+"_userdata.gdbm")
_, err := os.Open(filename)
if err != nil {
	// Check if the error is due to the file not existing
	if os.IsNotExist(err) {
		fmt.Printf("File open error: the file '%s' does not exist\n", filename)
		db, err = gdbm.Open(filename, gdbm.ModeWrcreat)
		if err != nil {
			panic(err)
		}
	} else {
		panic(err)
	}
} else {
	db, err = gdbm.Open(filename, gdbm.ModeWriter)
	if err != nil {
		panic(err)
	}
}`
So a question on this,we want to be able to keep a reference to the file created for each session and be able to initialize a database instance depending on its existence.So we have this code and it still seems to be removing the previously stored information when it is opened with mode **ModeWriter** .A fix for the time being for this will be appreciated because the refactoring depends on storing the user information to gdbm. filename := path.Join(scriptDir, sessionId+"_userdata.gdbm") _, err := os.Open(filename) if err != nil { // Check if the error is due to the file not existing if os.IsNotExist(err) { fmt.Printf("File open error: the file '%s' does not exist\n", filename) db, err = gdbm.Open(filename, gdbm.ModeWrcreat) if err != nil { panic(err) } } else { panic(err) } } else { db, err = gdbm.Open(filename, gdbm.ModeWriter) if err != nil { panic(err) } }`
lash commented 2024-09-03 19:58:16 +02:00
Author
Owner
Copy Link

First, as I said, let's not spend time on this, since this code will be gone when you implement db.gdbmDb in dev-0.1.0.

That said, choosing flag on os.Stat would be the way to go, I guess.

As a reference example on how to do it directly, see go-vise branch dev-0.1.0 method db/gdbm/gdbmDb.Connect(...)

But I repeat, please don't spend time on this.

First, as I said, let's not spend time on this, since this code will be gone when you implement db.gdbmDb in dev-0.1.0. That said, choosing flag on os.Stat would be the way to go, I guess. As a reference example on how to do it directly, see `go-vise` branch `dev-0.1.0` method `db/gdbm/gdbmDb.Connect(...)` But I repeat, please don't spend time on this.
internal/handlers/ussd/menuhandler.go Outdated
@ -60,1 +98,4 @@
func (h *Handlers) PreloadFlags(flagKeys []string) (map[string]uint32, error) {
flags := make(map[string]uint32)
for _, key := range flagKeys {
lash commented 2024-09-03 00:18:04 +02:00
Author
Owner
Copy Link

It shouldn't be necessary to process the flags twice.

It shouldn't be necessary to process the flags twice.
Alfred-mk marked this conversation as resolved
internal/handlers/ussd/menuhandler.go Outdated
@ -85,2 +143,3 @@
err := h.accountFileHandler.EnsureFileExists()
// Preload the required flags
flagKeys := []string{"flag_account_created", "flag_account_creation_failed"}
lash commented 2024-09-03 00:19:45 +02:00
Author
Owner
Copy Link

also seems unnecessary, there should be one single source of flag label to value map.

also seems unnecessary, there should be one single source of flag label to value map.
Alfred-mk commented 2024-09-03 15:25:10 +02:00
Member
Copy Link

For clarity, do you mean that we should load all flags once in the menuhandler and have functions access the already loaded flags?

For clarity, do you mean that we should load all flags once in the menuhandler and have functions access the already loaded flags?
lash commented 2024-09-03 15:27:50 +02:00
Author
Owner
Copy Link

yes, or perhaps even globally.

yes, or perhaps even globally.
Alfred-mk marked this conversation as resolved
internal/handlers/ussd/menuhandler.go Outdated
@ -88,3 +148,4 @@
return res, err
}
// err = h.accountFileHandler.EnsureFileExists()
lash commented 2024-09-03 00:20:06 +02:00
Author
Owner
Copy Link

please remove commented code if it is not of any more use

please remove commented code if it is not of any more use
carlos marked this conversation as resolved
internal/handlers/ussd/menuhandler.go Outdated
@ -156,3 +222,2 @@
case "2":
res.FlagReset = append(res.FlagSet, models.USERFLAG_ALLOW_UPDATE)
res.FlagSet = append(res.FlagSet, models.USERFLAG_SINGLE_EDIT)
res.FlagReset = append(res.FlagSet, flags["flag_allow_update"])
lash commented 2024-09-03 00:21:51 +02:00
Author
Owner
Copy Link

here appends to set but assign to reset. happens in the below, too.

here appends to set but assign to reset. happens in the below, too.
Alfred-mk marked this conversation as resolved
internal/handlers/ussd/menuhandler.go Outdated
@ -546,1 +629,3 @@
return res, err
err = h.db.Delete([]byte(Amount))
if err != nil && !errors.Is(err, gdbm.ErrItemNotFound) {
panic(err)
lash commented 2024-09-03 00:26:40 +02:00
Author
Owner
Copy Link

we cannot have panics anywhere in the vm execution! Just return error.

we cannot have panics anywhere in the vm execution! Just return error.
carlos marked this conversation as resolved
carlos added 2 commits 2024-09-03 10:51:42 +02:00
carlos added 1 commit 2024-09-03 12:19:53 +02:00
Alfred-mk added 1 commit 2024-09-03 14:03:01 +02:00
Alfred-mk added 1 commit 2024-09-03 14:04:25 +02:00
carlos added 2 commits 2024-09-03 14:09:46 +02:00
carlos added 1 commit 2024-09-03 14:14:15 +02:00
Alfred-mk added 1 commit 2024-09-03 14:34:39 +02:00
carlos added 2 commits 2024-09-03 17:00:33 +02:00
Alfred-mk added 1 commit 2024-09-03 18:06:58 +02:00
Alfred-mk added 1 commit 2024-09-03 21:29:12 +02:00
lash reviewed 2024-09-04 08:03:05 +02:00
cmd/main.go
@ -54,0 +71,4 @@
}
// Register the flag
state.FlagDebugger.Register(uint32(flagValue), flagName)
lash commented 2024-09-04 07:41:27 +02:00
Author
Owner
Copy Link

A logline to show debug the flag loaded would be nice

A logline to show debug the flag loaded would be nice
internal/handlers/ussd/menuhandler.go
@ -32,0 +56,4 @@
// FlagManager handles centralized flag management
type FlagManager struct {
parser *asm.FlagParser
mu sync.RWMutex
lash commented 2024-09-04 07:43:34 +02:00
Author
Owner
Copy Link

I don't think mutex is needed here, it will be loaded once (before threads) and only read from then right?

I don't think mutex is needed here, it will be loaded once (before threads) and only read from then right?
Alfred-mk marked this conversation as resolved
Alfred-mk added 1 commit 2024-09-04 11:02:13 +02:00
Alfred-mk added 1 commit 2024-09-04 11:20:04 +02:00
Alfred-mk merged commit c6c66f956a into master 2024-09-04 11:25:34 +02:00
kamikazechaser reviewed 2024-09-04 13:07:48 +02:00
cmd/main.go
@ -87,0 +110,4 @@
ussdHandlers, err := ussd.NewHandlers(fp, &st, sessionId)
if err != nil {
fmt.Fprintf(os.Stderr, "handler setup failed with error: %v\n", err)
kamikazechaser commented 2024-09-04 13:07:48 +02:00
Owner
Copy Link

Exit in main if any setup fails.

Exit in main if any setup fails.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Runner
AT

  
Runner
CLI

  
Runner
HTTP

  
cleanup

   
easy

A task that can be completed with little effort

  
optimization

   
refactor

   
smell

Code smell

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Runner
AT
Runner
CLI
Runner
HTTP
cleanup
easy
optimization
refactor
smell
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: urdt/ussd#28
No description provided.
Delete Branch "wip-flag-migration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?