urdt/ussd
5
0
Fork 0
Code Issues 33 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Replace log with structured logging log/slog #31

New Issue
Open
opened 2024-09-04 13:04:34 +02:00 by kamikazechaser · 3 comments
kamikazechaser commented 2024-09-04 13:04:34 +02:00
Owner
Copy Link

This is required to collect and process logs for alerting. Ideally go-vise also does the same if go-vise logging is activated in this project.

fmt.Printf statements should also be replaced at some point.

This is required to collect and process logs for alerting. Ideally go-vise also does the same if go-vise logging is activated in this project. fmt.Printf statements should also be replaced at some point.
kamikazechaser added the
Kind/Feature
Kind/Enhancement
Priority
Low
refactor
easy
 labels 2024-09-04 13:04:34 +02:00
lash commented 2024-09-05 17:50:16 +02:00
Owner
Copy Link

we have a logger in go-vise/logging - does it suffice? @kamikazechaser

we have a logger in go-vise/logging - does it suffice? @kamikazechaser
kamikazechaser commented 2024-09-06 10:00:43 +02:00
Author
Owner
Copy Link

Looks good. However, the existing one go-vise/logging could be implemented as a slog Handler. By accepting slog.Logger, anyone can bring their own logger.

I can bring this feature to go-vise if you like the idea.

Looks good. However, the existing one `go-vise/logging` could be implemented as a [slog Handler](https://go.dev/blog/slog). By accepting slog.Logger, anyone can bring their own logger. I can bring this feature to go-vise if you like the idea.
lash commented 2024-09-06 17:06:59 +02:00
Owner
Copy Link

I can bring this feature to go-vise if you like the idea.

@kamikazechaser sure, thanks! I have added an issue for it here: https://defalsify.org/issues/vise/2dc45a02-36de-42d3-9b20-4305a49f3d9b.html

> I can bring this feature to go-vise if you like the idea. @kamikazechaser sure, thanks! I have added an issue for it here: https://defalsify.org/issues/vise/2dc45a02-36de-42d3-9b20-4305a49f3d9b.html
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Runner
AT

  
Runner
CLI

  
Runner
HTTP

  
cleanup

   
easy

A task that can be completed with little effort

  
optimization

   
refactor

   
smell

Code smell

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Runner
AT
Runner
CLI
Runner
HTTP
cleanup
easy
optimization
refactor
smell
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: urdt/ussd#31
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?