urdt/ussd
5
0
Fork 0
Code Issues 50 Pull Requests 7 Actions Packages Projects Releases Wiki Activity

voucher-data #138

Merged
lash merged 18 commits from voucher-data into master 2024-10-31 13:44:19 +01:00
Conversation 0 Commits 18 Files Changed 11 +1 -4
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e6a369dcdd - Show all commits

3
internal/utils/vouchers.go
View File

@ -77,9 +77,6 @@ func MatchVoucher(input, symbols, balances, decimals, addresses string) (symbol,
for i, sym := range symList { for i, sym := range symList {
parts := strings.SplitN(sym, ":", 2) parts := strings.SplitN(sym, ":", 2)
if len(parts) != 2 {
continue
}
Alfred-mk marked this conversation as resolved Outdated
lash commented 2024-10-30 19:37:17 +01:00
Outdated
Review
Copy Link

When will this condition occur?

When will this condition occur?
Alfred-mk commented 2024-10-31 00:46:01 +01:00
Outdated
Review
Copy Link

It will only occur if the string is not well formatted in the "1:SRF" format, such as it being "1SRF" or "1 SRF"

Ideally, this will not be encountered but I added this as an edge case in the unlikely event that it does

It will only occur if the string is not well formatted in the "1:SRF" format, such as it being "1SRF" or "1 SRF" Ideally, this will not be encountered but I added this as an edge case in the unlikely event that it does
lash commented 2024-10-31 00:49:30 +01:00
Outdated
Review
Copy Link

but shouldnt that raise an error, as it should never happen?

but shouldnt that raise an error, as it should never happen?
Alfred-mk commented 2024-10-31 12:44:50 +01:00
Outdated
Review
Copy Link

On further assessment, I see it best to remove the code as the condition would never occur.

The data being matched comes from the db, and for this condition to occur means an issue lies with the functions that process and store the data

On further assessment, I see it best to remove the code as the condition would never occur. The data being matched comes from the db, and for this condition to occur means an issue lies with the functions that process and store the data
if input == parts[0] || strings.EqualFold(input, parts[1]) { if input == parts[0] || strings.EqualFold(input, parts[1]) {
symbol = parts[1] symbol = parts[1]