urdt/ussd
5
0
Fork 0
Code Issues 50 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

wip-flag-migration #28

Merged
Alfred-mk merged 44 commits from wip-flag-migration into master 2024-09-04 11:25:34 +02:00
Conversation 0 Commits 44 Files Changed 22 +42 -40
2 changed files with 42 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 3a3ddc9922 - Show all commits

60
cmd/main.go
View File

@ -7,13 +7,13 @@ import (
"os"
"path"
"git.defalsify.org/vise.git/asm"
"git.defalsify.org/vise.git/cache"
"git.defalsify.org/vise.git/engine"
"git.defalsify.org/vise.git/persist"
"git.defalsify.org/vise.git/resource"
"git.defalsify.org/vise.git/state"
"git.grassecon.net/urdt/ussd/internal/handlers/ussd"
"git.grassecon.net/urdt/ussd/internal/models"
)
var (
@ -35,22 +35,46 @@ func main() {
ctx := context.Background()
st := state.NewState(16)
st.UseDebug()
state.FlagDebugger.Register(models.USERFLAG_LANGUAGE_SET, "LANGUAGE_CHANGE")
state.FlagDebugger.Register(models.USERFLAG_ACCOUNT_CREATED, "ACCOUNT_CREATED")
state.FlagDebugger.Register(models.USERFLAG_ACCOUNT_SUCCESS, "ACCOUNT_SUCCESS")
state.FlagDebugger.Register(models.USERFLAG_ACCOUNT_PENDING, "ACCOUNT_PENDING")
state.FlagDebugger.Register(models.USERFLAG_INCORRECTPIN, "INCORRECTPIN")
state.FlagDebugger.Register(models.USERFLAG_INCORRECTDATEFORMAT, "INVALIDDATEFORMAT")
state.FlagDebugger.Register(models.USERFLAG_INVALID_RECIPIENT, "INVALIDRECIPIENT")
state.FlagDebugger.Register(models.USERFLAG_PINMISMATCH, "PINMISMATCH")
state.FlagDebugger.Register(models.USERFLAG_PIN_SET, "PIN_SET")
state.FlagDebugger.Register(models.USERFLAG_INVALID_RECIPIENT_WITH_INVITE, "INVALIDRECIPIENT_WITH_INVITE")
state.FlagDebugger.Register(models.USERFLAG_INVALID_AMOUNT, "INVALIDAMOUNT")
state.FlagDebugger.Register(models.USERFLAG_ALLOW_UPDATE, "UNLOCKFORUPDATE")
state.FlagDebugger.Register(models.USERFLAG_VALIDPIN, "VALIDPIN")
state.FlagDebugger.Register(models.USERFLAG_ACCOUNT_AUTHORIZED, "ACCOUNT_AUTHORIZED")
state.FlagDebugger.Register(models.USERFLAG_ACCOUNT_CREATION_FAILED, "ACCOUNT_CREATION_FAILED")
state.FlagDebugger.Register(models.USERFLAG_SINGLE_EDIT, "SINGLEEDIT")
// Initialize the FlagParser
pfp := path.Join(scriptDir, "pp.csv")
parser := asm.NewFlagParser()
// Load flags from the pp.csv file
_, err := parser.Load(pfp)
if err != nil {
fmt.Fprintf(os.Stderr, "Failed to load flags: %v\n", err)
os.Exit(1)
}
// Register all flags loaded from pp.csv
flagKeys := []string{
Alfred-mk marked this conversation as resolved Outdated
lash commented 2024-09-03 00:11:12 +02:00
Outdated
Review
Copy Link

these flags should be loaded not hardcoded.

these flags should be loaded not hardcoded.
"flag_language_set",
"flag_account_created",
"flag_account_creation_failed",
"flag_account_pending",
"flag_account_success",
"flag_pin_mismatch",
"flag_pin_set",
"flag_account_authorized",
"flag_invalid_recipient",
"flag_invalid_recipient_with_invite",
"flag_invalid_amount",
"flag_incorrect_pin",
"flag_valid_pin",
"flag_allow_update",
"flag_single_edit",
"flag_incorrect_date_format",
}
for _, key := range flagKeys {
Alfred-mk marked this conversation as resolved Outdated
lash commented 2024-09-03 00:11:45 +02:00
Outdated
Review
Copy Link

iterate on csv lines and populate with rows 2 and 3...

iterate on csv lines and populate with rows 2 and 3...
id, err := parser.GetFlag(key)
if err != nil {
fmt.Fprintf(os.Stderr, "Failed to get flag %s: %v\n", key, err)
continue
lash commented 2024-09-04 07:41:27 +02:00
Review
Copy Link

A logline to show debug the flag loaded would be nice

A logline to show debug the flag loaded would be nice
}
state.FlagDebugger.Register(id, key)
}
rfs := resource.NewFsResource(scriptDir)
ca := cache.NewCache()
@ -60,7 +84,7 @@ func main() {
}
dp := path.Join(scriptDir, ".state")
err := os.MkdirAll(dp, 0700)
err = os.MkdirAll(dp, 0700)
if err != nil {
fmt.Fprintf(os.Stderr, "state dir create exited with error: %v\n", err)
os.Exit(1)

22
internal/models/flags.go
View File

@ -1,22 +0,0 @@
package models
import "git.defalsify.org/vise.git/state"
const (
USERFLAG_LANGUAGE_SET = iota + state.FLAG_USERSTART
USERFLAG_ACCOUNT_CREATED
USERFLAG_ACCOUNT_CREATION_FAILED
USERFLAG_ACCOUNT_PENDING
USERFLAG_ACCOUNT_SUCCESS
USERFLAG_PINMISMATCH
USERFLAG_PIN_SET
USERFLAG_ACCOUNT_AUTHORIZED
USERFLAG_INVALID_RECIPIENT
USERFLAG_INVALID_RECIPIENT_WITH_INVITE
USERFLAG_INVALID_AMOUNT
USERFLAG_INCORRECTPIN
USERFLAG_VALIDPIN
USERFLAG_ALLOW_UPDATE
USERFLAG_SINGLE_EDIT
USERFLAG_INCORRECTDATEFORMAT
)