allow period for the alias #1

carlos · 2025-01-20T15:42:20+01:00

carlos commented

PR Change

**PR Change** - Allows period (.) for the aliases

carlos added 1 commit 2025-01-20 15:42:21 +01:00

lash requested changes 2025-01-20 16:27:00 +01:00

identity/alias.go Outdated

						
				@@ -6,3 +6,3 @@

				const (

					aliasRegex   = `^[a-zA-Z0-9]+$`

					aliasRegex = `^[a-zA-Z0-9.]+$`

lash commented

Actually this should be previous regex then followed by 1+ dot-prefixed alphanumerics something like ^[a-zA-Z0-9]+(\.[a-zA-Z0.9]+)*$

Actually this should be previous regex then followed by 1+ dot-prefixed alphanumerics something like `^[a-zA-Z0-9]+(\.[a-zA-Z0.9]+)*$`

lash commented

perhaps we can test it too?

foo
foo.bar
foo.bar.baz

and a couple of wrongs like

.foo
foo..bar
etc

perhaps we can test it too? `foo` `foo.bar` `foo.bar.baz` and a couple of wrongs like `.foo` `foo..bar` etc

carlos added 2 commits 2025-01-21 11:16:37 +01:00

lash merged commit ba8cbbccea into master

2025-01-21 14:47:36 +01:00

lash referenced this issue from a commit

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: grassrootseconomics/common#1