allow period for the alias #1

carlos · 2025-01-20T15:42:20+01:00

carlos commented

2025-01-20 15:42:20 +01:00

PR Change

Allows period (.) for the aliases

**PR Change** - Allows period (.) for the aliases

carlos added 1 commit 2025-01-20 15:42:21 +01:00

allow period for the alias 26b53c79df

lash requested changes 2025-01-20 16:27:00 +01:00

identity/alias.go Outdated

						
				@ -6,3 +6,3 @@

				const (

					aliasRegex   = `^[a-zA-Z0-9]+$`

					aliasRegex = `^[a-zA-Z0-9.]+$`

lash commented

2025-01-20 16:26:56 +01:00

Actually this should be previous regex then followed by 1+ dot-prefixed alphanumerics something like ^[a-zA-Z0-9]+(\.[a-zA-Z0.9]+)*$

Actually this should be previous regex then followed by 1+ dot-prefixed alphanumerics something like `^[a-zA-Z0-9]+(\.[a-zA-Z0.9]+)*$`

lash commented

2025-01-20 16:31:06 +01:00

perhaps we can test it too?

foo
foo.bar
foo.bar.baz

and a couple of wrongs like

.foo
foo..bar
etc

perhaps we can test it too? `foo` `foo.bar` `foo.bar.baz` and a couple of wrongs like `.foo` `foo..bar` etc

carlos added 2 commits 2025-01-21 11:16:37 +01:00

allow period for the alias regex 3e859d3469

test alias regex b4cd696f48

lash merged commit ba8cbbccea into master

2025-01-21 14:47:36 +01:00

lash referenced this issue from a commit

2025-01-21 14:47:37 +01:00

Merge pull request 'allow period for the alias' (#1) from alias-period into master

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: grassrootseconomics/common#1