grassrootseconomics/openethereum
5
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Give IoService a consistent interface (#257)

Browse Source 
The start() method had two different signatures depending on configuration. Since ethcore is built with either config depending on the build target, this resulted in compiler errors for either evmbin or oe.
This commit is contained in:
Jochen Müller 2021-02-05 13:33:39 +01:00 committed by GitHub
parent bbecb0415e
commit f40e198eb7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
crates/runtime/io/src/service_non_mio.rs
View File

@ -267,7 +267,9 @@ where
Message: Send + Sync + 'static, Message: Send + Sync + 'static,
{ {
/// Starts IO event loop /// Starts IO event loop
pub fn start() -> Result<IoService<Message>, IoError> { pub fn start(_symbolic_name: &'static str) -> Result<IoService<Message>, IoError> {
// This minimal implementation of IoService does have named Workers
// like the mio-dependent one does, so _symbolic_name is ignored.
let (tx, rx) = deque::fifo(); let (tx, rx) = deque::fifo();
let shared = Arc::new(Shared { let shared = Arc::new(Shared {