* Filter-out nodes.json (#7716)
* Filter-out nodes.json
* network: sort node table nodes by failure ratio
* network: fix node table tests
* network: fit node failure percentage into buckets of 5%
* network: consider number of attempts in sorting of node table
* network: fix node table grumbles
* Fix client not being dropped on shutdown (#7695)
* parity: wait for client to drop on shutdown
* parity: fix grumbles in shutdown wait
* parity: increase shutdown timeouts
* Wrap --help output to 120 characters (#7626)
* Update Clap dependency and remove workarounds
* WIP
* Remove line breaks in help messages for now
* Multiple values can only be separated by commas (closes#7428)
* Grumbles; refactor repeating code; add constant
* Use a single Wrapper rather than allocate a new one for each call
* Wrap --help to 120 characters rather than 100 characters
* Improve handling of RocksDB corruption (#7630)
* kvdb-rocksdb: update rust-rocksdb version
* kvdb-rocksdb: mark corruptions and attempt repair on db open
* kvdb-rocksdb: better corruption detection on open
* kvdb-rocksdb: add corruption_file_name const
* kvdb-rocksdb: rename mark_corruption to check_for_corruption
* Hardening of CSP (#7621)
* Fixed delegatecall's from/to (#7568)
* Fixed delegatecall's from/to, closes#7166
* added tests for delegatecall traces, #7167
* Light client RPCs (#7603)
* Implement registrar.
* Implement eth_getCode
* Don't wait for providers.
* Don't wait for providers.
* Fix linting and wasm tests.
* Problem: AttachedProtocols don't get registered (#7610)
I was investigating issues I am having with Whisper support. I've
enabled Whisper on a custom test network and inserted traces into
Whisper handler implementation (Network<T> and NetworkProtocolHandler
for Network<T>) and I noticed that the handler was never invoked.
After further research on this matter, I found out that
AttachedProtocol's register function does nothing:
https://github.com/paritytech/parity/blob/master/sync/src/api.rs#L172
but there was an implementation originally:
99075ad#diff-5212acb6bcea60e9804ba7b50f6fe6ec and it did the actual
expected logic of registering the protocol in the NetworkService.
However, as of 16d84f8#diff-5212acb6bcea60e9804ba7b50f6fe6ec ("finished
removing ipc") this implementation is gone and only the no-op function
is left.
Which leads me to a conclusion that in fact Whisper's handler never gets
registered in the service and therefore two nodes won't communicate
using it.
Solution: Resurrect original non-empty `AttachedProtocols.register`
implementation
Resolves#7566
* Fix Temporarily Invalid blocks handling (#7613)
* Handle temporarily invalid blocks in sync.
* Fix tests.
* More thorough changes detection
This basically trades false-negatives ("dumb" last commit not touching
Rust on a Rust-touching branch) for false-positives (all builds against
`stable` and `beta` will run all tests almost always).
This seems to be a reasonable tradeoff.
Closes#6507
* We don't have Appveyor anymore
* before_script sections are not merged
* Limiting commit depth breaks branching detection