Commit Graph

10071 Commits

Author SHA1 Message Date
Fredrik Harrysson c1288810c6 Change keypath derivation logic (#6815)
While the standard defined by Trezor as the default derivation path here
https://blog.trezor.io/trezor-integration-with-myetherwallet-3e217a652e08
says that it should be `m/44'/60'/0`, in practice they don't have an
implementation of a wallet for Ethereum themselves and refer customers
to MEW.

MEW has a custom implementation of the path derivation logic that allows them to
generate multiple addresses by essentially adding `/0`, `/1` etc to the path.

In my initial implementation of Trezor I didn't take this into
consideration unfortunately and just used the keypath that Trezor
themselves recommended. However, given that it's seemingly standard
practice to append `/0` for a "sub-address" (and this is what we've done
for Ledger as well) it seems like a mistake on my part to not take that
into consideration.

Unfortunately, anyone who has used their Trezor device with Parity
previously would now see a different address when they connect the
Trezor device the next time. The only way they would have to access the
old address is to use an old version, or by going through MEW and
selecting the Ledger keypath.

Also see #6811
2017-10-19 11:47:53 +02:00
Marek Kotewicz 5281e09828 Merge pull request #6801 from paritytech/refactoring/journal-6693
Refactors journaldb as a separate crate
2017-10-18 16:10:28 +02:00
GitLab Build Bot b1df272f4c [ci skip] js-precompiled 20171018-123105 2017-10-18 12:35:51 +00:00
Tomasz Drwięga 51caf97705 Trigger UI build. (#6817) 2017-10-18 14:19:45 +02:00
GitLab Build Bot 62fa1ed524 [ci skip] js-precompiled 20171017-174801 2017-10-17 17:53:06 +00:00
Dmitry Kashitsyn 153b8572dd Fixes tests 2017-10-17 22:24:47 +07:00
Arkadiy Paronyan a2fe7def1f Bumped version (#6809) 2017-10-17 16:48:38 +02:00
Kirill Pimenov 540c93955e Merge pull request #6808 from paritytech/td-rpc-warnings
Fix RPC compilation warnings.
2017-10-17 16:15:32 +02:00
Tomasz Drwięga 1d9542fe88
Fix RPC compilation warnings. 2017-10-17 15:41:32 +02:00
Kirill Pimenov 86c2633280 Migrate to Futures in SigningQueue (#6689)
* oneshot channels instead of custom promises

* Future instead of handle_dispatch

* Even less copying

* Those explicit waits were a mistake, thanks, @tomusdrw

* No more unsafe polling

* Test for the new `is_done()` method

* Mark Futures as `#[must_use]`

* Solve most compilation warnings

* `try_ready!` is more ideomatic

* Turn spaces into tabs

* Documentation and visibility improvements

* Minor code style improvements

* Make Futures run on an explisit reactor

* Another round of code style issues

* Simplify ConfirmationReceiver type

* Flatten ConfirmationOutcome into a plain Result type

* Get rid of a separate `pending` set, it was a stupid idea

* Clarify `add_request` docs

* No need to reduce the scope of the mutex here
2017-10-17 14:50:53 +02:00
debris 0e912bca5b bring back accidently removed whitespace 2017-10-17 10:44:05 +02:00
debris 607cc6c782 fixed compiling util tests 2017-10-17 10:40:45 +02:00
Dmitry Kashitsyn 7fe7b6d9a4 Fixes import in test 2017-10-17 12:12:46 +07:00
Dmitry Kashitsyn f9e588dd7b Refactors parity/parity to use journaldb crate (#6693) 2017-10-17 11:46:54 +07:00
Dmitry Kashitsyn c0fc83988f Refactors ethcore to use journaldb crate (#6693) 2017-10-17 11:46:07 +07:00
Dmitry Kashitsyn e2b96e1fe0 Moves journaldb sources to a separate crate (#6693) 2017-10-17 11:44:52 +07:00
Marek Kotewicz 98d0ef3fff Merge pull request #6795 from paritytech/ipc_cleanup
remove internal ipc
2017-10-16 23:22:47 +02:00
debris 3830f9b464 fixed failing test 2017-10-16 22:12:17 +02:00
debris 95f0384510 Merge branch 'master' into ipc_cleanup 2017-10-16 18:19:41 +02:00
Marek Kotewicz bb1be15dc4 Merge pull request #6792 from paritytech/kvdb_error
consistent KeyValueDB errors
2017-10-16 18:19:18 +02:00
debris 16d84f8ecf finished removing ipc 2017-10-16 18:18:43 +02:00
debris fa019bd03e remove ipc codegen from ethcore 2017-10-16 17:50:25 +02:00
debris 6f914d1851 remove ipc codegen from stratum 2017-10-16 17:32:15 +02:00
debris f1c50e5648 remove ipc codegen from updater 2017-10-16 17:28:59 +02:00
debris c83e9d0f1b remove ipc codegen from secretstore 2017-10-16 17:12:02 +02:00
debris 7661e93a56 fixed secret_store conversion from kvdb error 2017-10-16 14:55:11 +02:00
Arkadiy Paronyan 5b29b6d064 Squash remaining warnings (#6789)
* Fixed comment warnings

* Fixed remaining warnings
2017-10-16 12:31:52 +02:00
debris 8ecdab68c2 add missing space to TrieError description 2017-10-16 12:17:06 +02:00
debris 5e61f3493e require stable error-chain 2017-10-16 12:15:19 +02:00
debris 6dc50d01b5 KeyValueDB trait uses errors instead of strings 2017-10-16 12:11:35 +02:00
Marek Kotewicz 44db0c55c5 Merge pull request #6720 from paritytech/kvdb_split
separated kvdb into 3 crates: kvdb, kvdb-memorydb && kvdb-rocksdb
2017-10-16 10:57:27 +02:00
Afri Schoedon 774598974e Forward-port #6754 #6755 (#6785) 2017-10-16 10:56:23 +02:00
Marek Kotewicz aa4bc50c6b removed duplicated versions of clippy (#6776) 2017-10-16 10:22:02 +02:00
Marek Kotewicz 8365f4d80e updated ethabi to version 4.0 (#6742)
* updated ethabi to version 4.0

* ethabi 4.0.1
2017-10-16 10:21:35 +02:00
Marek Kotewicz 9fa639ede9 updated rpc_cli and parity to rpassword 1.0 (#6774) 2017-10-16 10:20:55 +02:00
Afri Schoedon b63c3a66ca Fix sign data typo, ref #6737 (#6750) 2017-10-16 10:08:36 +02:00
debris fbad6b5514 removed redundant mut from kvdb-memorydb 2017-10-16 10:02:26 +02:00
debris 2ce0eae406 Merge branch 'master' into kvdb_split 2017-10-16 10:01:12 +02:00
Marek Kotewicz d1c9acf439 Merge pull request #6772 from paritytech/refactoring/cache-6693
Refactoring/cache 6693
2017-10-16 09:58:48 +02:00
Afri Schoedon 832879e5c8 Fix CHANGLOG for 1.8.0 (#6751)
* Fix CHANGLOG for 1.8.0

* Update changelog for 1.8.0

* Add changelog for 1.7.7
2017-10-16 09:35:02 +02:00
Dmitry Kashitsyn 92a9fd3359 Uses dash instead of underscore in crate name 2017-10-16 11:05:54 +07:00
Dmitry Kashitsyn b03117b262 Removes redundant `mut` in service.rs.in (#6775) 2017-10-15 17:41:40 +02:00
Dmitry Kashitsyn e7690ab658 Removes redundant dependencies (#6693) 2017-10-15 21:47:06 +07:00
Dmitry Kashitsyn 4df541e47a Refactors references to MemoryLruCache in ethcore (#6693) 2017-10-15 21:47:06 +07:00
Dmitry Kashitsyn 51b61ccdbf Extracts MemoryLruCache to a separate crate (#6693) 2017-10-15 21:47:06 +07:00
debris db3ff67182 Merge branch 'master' into kvdb_split 2017-10-15 16:40:20 +02:00
Marek Kotewicz 82c8dccddf Merge pull request #6773 from paritytech/refactoring/redundant-mut
Remove redundant `mut`
2017-10-15 16:38:26 +02:00
debris fa4e5c98d0 docs 2017-10-15 16:18:45 +02:00
debris 616cafb04a renamed kvdb_memorydb::in_memory -> kvdb_memorydb::create 2017-10-15 16:17:15 +02:00
debris d88ec35a6a Merge branch 'master' into kvdb_split 2017-10-15 15:55:44 +02:00