Go to file
cheme c1aed4af45 Fix light client deadlock (#9385)
This PR is fixing deadlock for #8918 

It avoids some recursive calls on light_sync by making state check optional for Informant.

The current behavior is to display the information when informant checks if block is major version.
This change a bit the informant behavior, but not on most cases.

To remember where and how this kind of deadlock are likely to happen (not seen with Parkinglot deadlock detection because it uses std condvar), I am adding a description of the deadlock.
Also, for the reviewers there may be better solution than modifying the informant.

### Thread1 

- ethcore/sync/light_sync/mod.rs

A call to the light handler through any Io (having a loop of rpc query running on like client makes the dead lock way more likely).
At the end of those calls we systematically call `maintain_sync` method.

Here maintain_sync locks `state` (it is the deadlock cause), with a write purpose

`maintain_sync` -> `begin_search` with the state locked open

`begin_search` -> lightcliennt `flush_queue` method

- ethcore/light/src/client/mod.rs

`flush_queue` -> `flush` on queue (HeaderQueue aka VerificationQueue of headers)

- ethcore/src/verification/queue/mod.rs

Condition there is some unverified or verifying content

`flush` wait on a condvar until the queue is empty. The only way to unlock condvar is that worker is empty and unlock it (so thread 2 is Verification worker).

### Thread2

A verification worker at the end of a verify loop (new block).

- ethcore/src/verification/queue/mod.rs

thread loops on `verify` method.

End of loop condition is_ready -> Import the block immediately 

calls `set_sync` on QueueSignal which send a BlockVerified ClientIoMessage in inner channel (IoChannel of ClientIoMessage) using `send_sync`

- util/io/src/service_mio.rs

IoChannel `send_sync` method calls all handlers with `message` method; one of the handlers is ImportBlocks IoHandler (with a single inner Client service field)

- ethcore/light/src/client/service.rs

`message` trigger inner method `import_verified`

- core/light/src/client/mod.rs

`import_verified` at the very end notify the listeners of a new_headers, one of the listeners is Informant `listener` method

- parity/informant.rs

`newHeaders` run up to call to `is_major_importing` on its target (again clinet)

-  ethcore/sync/src/light_sync/mod.rs

Here `is_major_importing` tries to get state lock (read purpose only) but cannot because of previous state lock, thus deadlock
2018-09-04 15:36:34 +01:00
.cargo docs: update repository links (#9159) 2018-07-23 13:58:50 +02:00
.github Random small cleanups (#9423) 2018-08-30 19:57:27 +02:00
chainspec Random small cleanups (#9423) 2018-08-30 19:57:27 +02:00
devtools Update license header and scripts (#8666) 2018-06-04 10:19:50 +02:00
docker docker: install missing dependencies in arm target dockerfiles (#9436) 2018-08-30 20:03:38 +02:00
docs docs: add parity ethereum logo to readme (#9415) 2018-08-27 17:01:56 +02:00
ethash Random small cleanups (#9423) 2018-08-30 19:57:27 +02:00
ethcore Fix light client deadlock (#9385) 2018-09-04 15:36:34 +01:00
ethkey Random small cleanups (#9423) 2018-08-30 19:57:27 +02:00
ethstore Random small cleanups (#9423) 2018-08-30 19:57:27 +02:00
evmbin Fix a bug in evmbin initial_gas display (#9457) 2018-09-04 16:33:14 +08:00
hash-fetch Update log -> 0.4, env_logger -> 0.5. (#9294) 2018-08-10 00:04:10 +01:00
hw Update log -> 0.4, env_logger -> 0.5. (#9294) 2018-08-10 00:04:10 +01:00
ipfs Delete crates from parity-ethereum and fetch them from parity-common instead (#9083) 2018-07-10 14:59:19 +02:00
json Add EIP-1014 transition config flag (#9268) 2018-08-31 23:43:51 +08:00
local-store use kvdb-* and parity-snappy crates from crates.io (#9441) 2018-09-03 17:40:11 +01:00
logger Fix no line breaks in logs (#9355) 2018-08-14 18:10:51 +01:00
machine block cleanup (#9117) 2018-07-30 10:45:10 +01:00
miner Private packets verification and queue refactoring (#8715) 2018-08-29 20:31:04 +08:00
parity Fix light client deadlock (#9385) 2018-09-04 15:36:34 +01:00
parity-clib Allow setting the panic hook with parity-clib (#9292) 2018-08-10 11:06:30 +02:00
parity-clib-examples/cpp Fix path to parity.h (#9274) 2018-08-02 22:18:49 +01:00
price-info Update log -> 0.4, env_logger -> 0.5. (#9294) 2018-08-10 00:04:10 +01:00
registrar Delete crates from parity-ethereum and fetch them from parity-common instead (#9083) 2018-07-10 14:59:19 +02:00
rpc use kvdb-* and parity-snappy crates from crates.io (#9441) 2018-09-03 17:40:11 +01:00
rpc_cli Update license header and scripts (#8666) 2018-06-04 10:19:50 +02:00
rpc_client Update log -> 0.4, env_logger -> 0.5. (#9294) 2018-08-10 00:04:10 +01:00
scripts fix typo in bash script (#9462) 2018-09-04 10:58:13 +02:00
secret_store use kvdb-* and parity-snappy crates from crates.io (#9441) 2018-09-03 17:40:11 +01:00
snap/gui Random small cleanups (#9423) 2018-08-30 19:57:27 +02:00
transaction-pool Better logging when mining own transactions. (#9363) 2018-08-17 16:01:32 +01:00
updater Implement EIP234 block_hash for eth_getLogs (#9256) 2018-08-13 15:47:10 +08:00
util use kvdb-* and parity-snappy crates from crates.io (#9441) 2018-09-03 17:40:11 +01:00
whisper Random small cleanups (#9423) 2018-08-30 19:57:27 +02:00
.dockerignore improved dockerfile builds (#5659) 2017-05-23 12:25:41 +02:00
.editorconfig Fix checksums and auto-update push (#7846) 2018-02-13 19:31:06 +01:00
.gitignore Move the C/C++ example to another directory (#9032) 2018-07-04 13:06:53 +03:00
.gitlab-ci.yml add tags for runner selection of build-linux jobs (#9451) 2018-08-31 16:41:21 +02:00
.gitmodules WASM contracts MVP (#5679) 2017-07-10 17:42:10 +02:00
Cargo.lock use kvdb-* and parity-snappy crates from crates.io (#9441) 2018-09-03 17:40:11 +01:00
Cargo.toml use kvdb-* and parity-snappy crates from crates.io (#9441) 2018-09-03 17:40:11 +01:00
CHANGELOG.md add changelog for 1.11.8 stable and 2.0.1 beta (#9230) 2018-07-27 16:00:34 +02:00
LICENSE Change to library. 2015-11-24 21:05:08 +01:00
license_header Random small cleanups (#9423) 2018-08-30 19:57:27 +02:00
README.md Random small cleanups (#9423) 2018-08-30 19:57:27 +02:00
rust-toolchain rust-toolchain file on master (#6266) 2017-08-14 13:47:53 +02:00
rustfmt.toml Use memmap for dag cache (#6193) 2017-09-25 19:45:33 +02:00
SECURITY.md Update SECURITY.md 2018-01-25 18:53:32 +01:00
test.sh Random small cleanups (#9423) 2018-08-30 19:57:27 +02:00

Parity Ethereum

The fastest and most advanced Ethereum client.

» Download the latest release «

Built for mission-critical use: Miners, service providers, and exchanges need fast synchronisation and maximum uptime. Parity Ethereum provides the core infrastructure essential for speedy and reliable services.

  • Clean, modular codebase for easy customisation
  • Advanced CLI-based client
  • Minimal memory and storage footprint
  • Synchronise in hours, not days with Warp Sync
  • Modular for light integration into your service or product

Technical Overview

Parity Ethereum's goal is to be the fastest, lightest, and most secure Ethereum client. We are developing Parity Ethereum using the sophisticated and cutting-edge Rust programming language. Parity Ethereum is licensed under the GPLv3 and can be used for all your Ethereum needs.

By default, Parity Ethereum runs a JSON-RPC HTTP server on port :8545 and a Web-Sockets server on port :8546. This is fully configurable and supports a number of APIs.

If you run into problems while using Parity Ethereum, check out the wiki for documentation, feel free to file an issue in this repository, or hop on our Gitter or Riot chat room to ask a question. We are glad to help! For security-critical issues, please refer to the security policy outlined in SECURITY.md.

Parity Ethereum's current beta-release is 2.0. You can download it at the releases page or follow the instructions below to build from source. Please, mind the CHANGELOG.md for a list of all changes between different versions.

Build Dependencies

Parity Ethereum requires Rust version 1.28.x to build.

We recommend installing Rust through rustup. If you don't already have rustup, you can install it like this:

  • Linux:

    $ curl https://sh.rustup.rs -sSf | sh
    

    Parity Ethereum also requires gcc, g++, libudev-dev, pkg-config, file, make, and cmake packages to be installed.

  • OSX:

    $ curl https://sh.rustup.rs -sSf | sh
    

    clang is required. It comes with Xcode command line tools or can be installed with homebrew.

  • Windows Make sure you have Visual Studio 2015 with C++ support installed. Next, download and run the rustup installer from https://static.rust-lang.org/rustup/dist/x86_64-pc-windows-msvc/rustup-init.exe, start "VS2015 x64 Native Tools Command Prompt", and use the following command to install and set up the msvc toolchain:

    $ rustup default stable-x86_64-pc-windows-msvc
    

Once you have rustup installed, then you need to install:

Make sure that these binaries are in your PATH. After that, you should be able to build Parity Ethereum from source.

Install from the Snapcraft Store

In any of the supported Linux distros:

sudo snap install parity

Alternatively, if you want to contribute testing the upcoming release:

sudo snap install parity --beta

Moreover, to test the latest code from the master branch:

sudo snap install parity --edge

Build from Source Code

# download Parity Ethereum code
$ git clone https://github.com/paritytech/parity-ethereum
$ cd parity-ethereum

# build in release mode
$ cargo build --release --features final

This produces an executable in the ./target/release subdirectory.

Note: if cargo fails to parse manifest try:

$ ~/.cargo/bin/cargo build --release

Note, when compiling a crate and you receive errors, it's in most cases your outdated version of Rust, or some of your crates have to be recompiled. Cleaning the repository will most likely solve the issue if you are on the latest stable version of Rust, try:

$ cargo clean

This always compiles the latest nightly builds. If you want to build stable or beta, do a

$ git checkout stable

or

$ git checkout beta

Simple One-Line Installer for Mac and Linux

bash <(curl https://get.parity.io -L)

The one-line installer always defaults to the latest beta release. To install a stable release, run:

bash <(curl https://get.parity.io -L) -r stable

Start Parity Ethereum

Manually

To start Parity Ethereum manually, just run

$ ./target/release/parity

so Parity Ethereum begins syncing the Ethereum blockchain.

Using systemd service file

To start Parity Ethereum as a regular user using systemd init:

  1. Copy ./scripts/parity.service to your systemd user directory (usually ~/.config/systemd/user).
  2. To configure Parity Ethereum, write a /etc/parity/config.toml config file, see Configuring Parity Ethereum for details.

Parity Ethereum toolchain

In addition to the Parity Ethereum client, there are additional tools in this repository available:

  • evmbin - EVM implementation for Parity Ethereum.
  • ethabi - Parity Ethereum function calls encoding.
  • ethstore - Parity Ethereum key management.
  • ethkey - Parity Ethereum keys generator.
  • whisper - Implementation of Whisper-v2 PoC.

Join the chat!

Questions? Get in touch with us on Gitter: Gitter: Parity Gitter: Parity.js Gitter: Parity/Miners Gitter: Parity-PoA

Alternatively, join our community on Matrix: Riot: +Parity

Documentation

Official website: https://parity.io

Be sure to check out our wiki for more information.