grassrootseconomics/sarafu-vise
8
0
Fork 0
Code Issues 15 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

reset account blocked flag #13

Merged
lash merged 2 commits from reset-account-blocked-flag into master 2025-01-21 07:47:33 +01:00
Conversation 1 Commits 2 Files Changed 3
+40 -2
Alfred-mk commented 2025-01-21 00:32:32 +01:00
Member
Copy Link
Copy Source
  • Reset the incorrect PIN attempts to 0 when the PIN is reset
  • Reset the flag_account_blocked if the PIN attempts is 0
  • Resolves issue urdt/ussd#280
- Reset the incorrect PIN attempts to 0 when the PIN is reset - Reset the flag_account_blocked if the PIN attempts is 0 - Resolves issue https://git.grassecon.net/urdt/ussd/issues/280
Alfred-mk added 2 commits 2025-01-21 00:32:33 +01:00
reset the incorrect PIN attempts to 0 when the PIN is reset 4fb3474b51
added CheckBlockedStatus to reset the flag_account_blocked if the incorrect PIN attempt has been reset fbee26da08
Alfred-mk requested review from lash 2025-01-21 00:32:43 +01:00
lash reviewed 2025-01-21 07:12:23 +01:00
handlers/application/menuhandler.go
@@ -256,0 +265,4 @@
return res, fmt.Errorf("missing session")
}
currentWrongPinAttempts, err := store.ReadEntry(ctx, sessionId, storedb.DATA_INCORRECT_PIN_ATTEMPTS)
lash commented 2025-01-21 07:08:57 +01:00
Owner
Copy Link
Copy Source

why is the check for incorrect pin attempts needed here? Why not just put it as part of the incorrect pin reset? Wouldn't that reduce the need for one read operation?

why is the check for incorrect pin attempts needed here? Why not just put it as part of the incorrect pin reset? Wouldn't that reduce the need for one read operation?
Alfred-mk commented 2025-01-21 07:30:41 +01:00
Author
Member
Copy Link
Copy Source

The check exists to reset the flag once the user access the menu.

Having the operation as part of the PIN reset increased complexity as we need to access the state of the user, reset the account blocked flag and save the state

The check exists to reset the flag once the user access the menu. Having the operation as part of the PIN reset increased complexity as we need to access the state of the user, reset the account blocked flag and save the state
lash commented 2025-01-21 07:42:27 +01:00
Owner
Copy Link
Copy Source

Hmm. Ok. It's not entirely clear to me why it is like this, as any point where the pin is reset would simply enable to set the flag as reset? There would be no need to read the flag?

Hmm. Ok. It's not entirely clear to me why it is like this, as any point where the pin is reset would simply enable to set the flag as reset? There would be no need to read the flag?
lash merged commit 7d513ac2a7 into master 2025-01-21 07:47:33 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
ussd/user-reported
Issue reported by a user while interacting with the ussd
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Alfred-mk (Alfred Kamanda) amina carlos kamikazechaser (Mohamed Sohail) lash mango-habanero williamluke willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: grassrootseconomics/sarafu-vise#13