reset account blocked flag #13

Alfred-mk · 2025-01-21T00:32:32+01:00

Alfred-mk commented

2025-01-21 00:32:32 +01:00

Reset the incorrect PIN attempts to 0 when the PIN is reset
Reset the flag_account_blocked if the PIN attempts is 0
Resolves issue urdt/ussd#280

- Reset the incorrect PIN attempts to 0 when the PIN is reset - Reset the flag_account_blocked if the PIN attempts is 0 - Resolves issue https://git.grassecon.net/urdt/ussd/issues/280

Alfred-mk added 2 commits 2025-01-21 00:32:33 +01:00

reset the incorrect PIN attempts to 0 when the PIN is reset 4fb3474b51

added CheckBlockedStatus to reset the flag_account_blocked if the incorrect PIN attempt has been reset fbee26da08

Alfred-mk requested review from lash 2025-01-21 00:32:43 +01:00

lash reviewed 2025-01-21 07:12:23 +01:00

handlers/application/menuhandler.go

						
				@ -256,0 +265,4 @@

						return res, fmt.Errorf("missing session")

					}

					currentWrongPinAttempts, err := store.ReadEntry(ctx, sessionId, storedb.DATA_INCORRECT_PIN_ATTEMPTS)

lash commented

2025-01-21 07:08:57 +01:00

why is the check for incorrect pin attempts needed here? Why not just put it as part of the incorrect pin reset? Wouldn't that reduce the need for one read operation?

Alfred-mk commented

2025-01-21 07:30:41 +01:00

The check exists to reset the flag once the user access the menu.

Having the operation as part of the PIN reset increased complexity as we need to access the state of the user, reset the account blocked flag and save the state

The check exists to reset the flag once the user access the menu. Having the operation as part of the PIN reset increased complexity as we need to access the state of the user, reset the account blocked flag and save the state

lash commented

2025-01-21 07:42:27 +01:00

Hmm. Ok. It's not entirely clear to me why it is like this, as any point where the pin is reset would simply enable to set the flag as reset? There would be no need to read the flag?