grassrootseconomics/sarafu-vise
8
0
Fork 0
Code Issues 15 Pull Requests 4 Actions Packages Projects Releases Wiki Activity

Bug fixes and menu improvement #19

Merged
lash merged 6 commits from minor-bug-fixes into master 2025-02-04 14:36:20 +01:00
Conversation 1 Commits 6 Files Changed 14
+60 -32
carlos commented 2025-02-04 09:49:17 +01:00
Member
Copy Link
Copy Source

PR Change

Bug fixes

  • Ensures that incorrect PIN attempts are not double-counted by LOAD and RELOAD of the authorize function.

  • Add a check to the authorize function to prevent treating non-numeric inputs (e.g., "abcd") as valid PIN attempts.

  • Uses State.Back to reset node specific flags to ensure smooth back menu navigation.

Enhancement

  • Replaces a back with a retry option after entry of unregistered number during pin reset by admins.
## PR Change #### Bug fixes - Ensures that incorrect PIN attempts are not double-counted by LOAD and RELOAD of the authorize function. - Add a check to the authorize function to prevent treating non-numeric inputs (e.g., "abcd") as valid PIN attempts. - Uses `State.Back` to reset node specific flags to ensure smooth back menu navigation. #### Enhancement - Replaces a back with a retry option after entry of unregistered number during pin reset by admins.
carlos added 6 commits 2025-02-04 09:49:18 +01:00
reset flags on back navigation,process only numeric pin entries 5722d4f8dd
replace back with retry option d3f1a14e71
fix: wrong pin count by load and reload handlers 04429ab74c
preload all common functions f9a9a9b4a6
remove unused handler 815e3b2a25
add mock state to failing tests f7873bfef7
carlos requested review from lash 2025-02-04 09:50:36 +01:00
lash approved these changes 2025-02-04 14:36:16 +01:00
lash merged commit 1918ea37d5 into master 2025-02-04 14:36:20 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
ussd/user-reported
Issue reported by a user while interacting with the ussd
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
Alfred-mk (Alfred Kamanda) amina carlos kamikazechaser (Mohamed Sohail) lash mango-habanero williamluke willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: grassrootseconomics/sarafu-vise#19