grassrootseconomics/sarafu-vise
7
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

WIP: data-migration #6

Closed
Alfred-mk wants to merge 8 commits from data-migration into master
pull from: data-migration
merge into: grassrootseconomics:master
Conversation 2 Commits 8 Files Changed 4 +10 -15
Alfred-mk commented 2025-01-15 14:03:41 +01:00
Member
Copy Link

Added code that sets required flags for migrated accounts

Added code that sets required flags for migrated accounts
Alfred-mk added 4 commits 2025-01-15 14:03:42 +01:00
Alfred-mk added 1 commit 2025-01-15 14:05:08 +01:00
Alfred-mk requested review from lash 2025-01-15 14:05:43 +01:00
Alfred-mk commented 2025-01-15 14:19:55 +01:00
Author
Member
Copy Link

The public keys (addresses) are however registered on a separate network hence checking the account status results in a 404 (when using the local dev network)

The public keys (addresses) are however registered on a separate network hence checking the account status results in a 404 (when using the local dev network)
lash requested changes 2025-01-15 20:22:13 +01:00
handlers/application/menuhandler.go Outdated
@ -100,3 +100,3 @@
// WithPersister sets persister instance to the handlers.
//func (h *MenuHandlers) WithPersister(pe *persist.Persister) *MenuHandlers {
// func (h *MenuHandlers) WithPersister(pe *persist.Persister) *MenuHandlers {
lash commented 2025-01-15 20:14:10 +01:00
Owner
Copy Link

Please remove this leftover commented code thanks

Please remove this leftover commented code thanks
handlers/application/menuhandler.go Outdated
@ -159,0 +188,4 @@
return res, nil
}
codeStr := string(code)
lash commented 2025-01-15 20:19:26 +01:00
Owner
Copy Link

The active language is the DATA_SELECTED_LANGUAGE_CODE - the INITAL will only be set once and never looked at again.

Shouldn't the SELECTED_LANGUAGE one be set here too?

The active language is the DATA_SELECTED_LANGUAGE_CODE - the INITAL will only be set once and never looked at again. Shouldn't the SELECTED_LANGUAGE one be set here too?
handlers/application/menuhandler.go Outdated
@ -159,0 +191,4 @@
codeStr := string(code)
// fallback for unsupported languages
if codeStr != "eng" && codeStr != "swa" {
lash commented 2025-01-15 20:17:09 +01:00
Owner
Copy Link

I would prefer if this language mapping was an external function. Perhaps this whole thing rather belongs in sarafu-ussd-instance repo since the migration script also should be there? I does not seem right to include code in the application repo that will only be used once by migration.

I would prefer if this language mapping was an external function. Perhaps this whole thing rather belongs in sarafu-ussd-instance repo since the migration script also should be there? I does not seem right to include code in the application repo that will only be used once by migration.
Alfred-mk changed title from data-migration to WIP: data-migration 2025-01-20 08:42:46 +01:00
Alfred-mk added 1 commit 2025-01-20 08:43:39 +01:00
Alfred-mk added 1 commit 2025-01-20 08:56:35 +01:00
Alfred-mk added 1 commit 2025-01-20 13:33:20 +01:00
Alfred-mk commented 2025-01-27 10:39:08 +01:00
Author
Member
Copy Link

Closed as code changes moved to a different repo

Closed as code changes moved to a different repo
Alfred-mk closed this pull request 2025-01-27 10:39:13 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
lash
Labels
Clear labels
  
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: grassrootseconomics/sarafu-vise#6
No description provided.
Delete Branch "data-migration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?