grassrootseconomics/sarafu-vise
8
0
Fork 0
Code Issues 16 Pull Requests 5 Actions 1 Packages Projects Releases Wiki Activity

WIP: data-migration #6

Closed
Alfred-mk wants to merge 8 commits from data-migration into master
pull from: data-migration
merge into: grassrootseconomics:master
Conversation 2 Commits 8 Files Changed 4 +1 -5
3 changed files with 1 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit bad273fa58 - Show all commits

4
handlers/application/menuhandler.go
View File

@ -101,14 +101,12 @@ func NewMenuHandlers(appFlags *FlagManager, userdataStore db.Db, accountService
return h, nil return h, nil
} }
lash commented 2025-01-15 20:14:10 +01:00
Outdated
Review
Copy Link

Please remove this leftover commented code thanks

Please remove this leftover commented code thanks
// WithPersister sets persister instance to the handlers. // SetPersister sets persister instance to the handlers.
// func (h *MenuHandlers) WithPersister(pe *persist.Persister) *MenuHandlers {
func (h *MenuHandlers) SetPersister(pe *persist.Persister) { func (h *MenuHandlers) SetPersister(pe *persist.Persister) {
if h.pe != nil { if h.pe != nil {
panic("persister already set") panic("persister already set")
} }
h.pe = pe h.pe = pe
//return h
} }
// Init initializes the handler for a new session. // Init initializes the handler for a new session.

1
handlers/application/menuhandler_test.go
View File

@ -265,7 +265,6 @@ func TestWithPersister(t *testing.T) {
h.SetPersister(p) h.SetPersister(p)
assert.Equal(t, p, h.pe, "The persister should be set correctly.") assert.Equal(t, p, h.pe, "The persister should be set correctly.")
//assert.Equal(t, h, result, "The returned handler should be the same instance.")
} }
func TestWithPersister_PanicWhenAlreadySet(t *testing.T) { func TestWithPersister_PanicWhenAlreadySet(t *testing.T) {

1
handlers/local.go
View File

@ -60,7 +60,6 @@ func (ls *LocalHandlerService) GetHandler(accountService remote.AccountService)
if err != nil { if err != nil {
return nil, err return nil, err
} }
//appHandlers = appHandlers.WithPersister(ls.Pe)
appHandlers.SetPersister(ls.Pe) appHandlers.SetPersister(ls.Pe)
ls.DbRs.AddLocalFunc("set_account_flags", appHandlers.SetAccountFlags) ls.DbRs.AddLocalFunc("set_account_flags", appHandlers.SetAccountFlags)
ls.DbRs.AddLocalFunc("set_language", appHandlers.SetLanguage) ls.DbRs.AddLocalFunc("set_language", appHandlers.SetLanguage)