lash
0 Followers · 0 Following
  • Joined on 2021-10-26
Repositories
1
 Projects Packages Public Activity Starred Repositories
lash closed pull request urdt/ussd#109 2024-10-18 15:28:36 +02:00
menu-traversal-refactor
lash reopened pull request urdt/ussd#115 2024-10-18 15:28:05 +02:00
menu-traversal-v2
lash closed pull request urdt/ussd#115 2024-10-18 15:27:21 +02:00
menu-traversal-v2
lash pushed to master at urdt/ussd 2024-10-16 19:08:47 +02:00
e986eaa538 Merge pull request 'menu-api-errors' (#112) from menu-api-errors into master
0be570ae2d add check for api call failure
6a36bc43b5 add check for api call failure
1d27a88908 add test on validate amount
4889e6d18b Merge remote-tracking branch 'origin' into menu-api-errors
Compare 17 commits »
lash merged pull request urdt/ussd#112 2024-10-16 19:08:46 +02:00
menu-api-errors
lash opened issue urdt/ussd#114 2024-10-16 15:31:18 +02:00
Send menu should show nothing to send when no default token
lash pushed to lash/stalecache at urdt/ussd 2024-10-14 15:55:27 +02:00
0af7379ae4 Merge branch 'master' into lash/stalecache
b058f9d770 Merge pull request 'Adapter to enable subdomain of db key prefixes' (#102) from lash/subprefix into master
Compare 2 commits »
lash pushed to lash/ssh-4 at urdt/ussd 2024-10-14 15:50:33 +02:00
967e53d83b Merge branch 'master' into lash/ssh-4
b058f9d770 Merge pull request 'Adapter to enable subdomain of db key prefixes' (#102) from lash/subprefix into master
Compare 2 commits »
lash pushed to master at urdt/ussd 2024-10-14 15:11:09 +02:00
b058f9d770 Merge pull request 'Adapter to enable subdomain of db key prefixes' (#102) from lash/subprefix into master
2a93ea7a0c Remove out-of-context extend key
f89b1acc6c Merge branch 'master' into lash/subprefix
1dc8b054eb Add sub-prefix db wrapper
Compare 4 commits »
lash merged pull request urdt/ussd#102 2024-10-14 15:11:08 +02:00
Adapter to enable subdomain of db key prefixes
lash commented on pull request urdt/ussd#101 2024-10-14 14:38:52 +02:00
menu-voucherlist

If no active sym then the user has no vouchers yet, and then no balance should be displayed, I think?

lash commented on pull request urdt/ussd#101 2024-10-14 14:38:52 +02:00
menu-voucherlist

Same here, if there is no symbol there is no balance.

lash commented on pull request urdt/ussd#101 2024-10-14 14:38:52 +02:00
menu-voucherlist

s/gdbm/db/

lash commented on pull request urdt/ussd#101 2024-10-14 14:38:52 +02:00
menu-voucherlist

Can we put this in a separate method please (that can be unit-tested with data only)

lash commented on pull request urdt/ussd#101 2024-10-14 14:38:52 +02:00
menu-voucherlist

Now this is code smell; we don't want to use menu selectors in branching here.

lash commented on pull request urdt/ussd#101 2024-10-14 14:38:52 +02:00
menu-voucherlist

Please put in separate, unit-testable method.

lash commented on pull request urdt/ussd#101 2024-10-14 14:38:52 +02:00
menu-voucherlist

CAps

lash commented on pull request urdt/ussd#101 2024-10-14 14:38:52 +02:00
menu-voucherlist

These should be gotten from the api provider go code instead, urdt/ussd#106

lash commented on pull request urdt/ussd#101 2024-10-14 14:38:52 +02:00
menu-voucherlist

Is this in use? Looks like test code?

lash suggested changes for urdt/ussd#101 2024-10-14 14:38:52 +02:00
menu-voucherlist