lash
0 Followers · 0 Following
  • Joined on 2021-10-26
Repositories
1
 Projects Packages Public Activity Starred Repositories
lash commented on pull request urdt/ussd#4 2024-08-29 16:18:02 +02:00
wip-account-creation

"unlocked" risks being an ambiguous term when we introduce account blocking due to direct action or incorrect pin attempts. can we rename it please?

lash suggested changes for urdt/ussd#4 2024-08-29 16:18:02 +02:00
wip-account-creation

A few small things to sort, then we are good.

lash commented on pull request urdt/ussd#4 2024-08-26 04:59:48 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:59:26 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:59:13 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:59:07 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:59:01 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:58:51 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:58:41 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:58:33 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:58:19 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:58:09 +02:00
wip-account-creation

priority

lash commented on pull request urdt/ussd#4 2024-08-26 04:56:50 +02:00
wip-account-creation

This stops and gets stuck on correct pin put:

lash commented on pull request urdt/ussd#4 2024-08-26 04:56:50 +02:00
wip-account-creation

Please complete this list

lash commented on pull request urdt/ussd#4 2024-08-26 04:56:50 +02:00
wip-account-creation

Please add a documentation line on each.

lash commented on pull request urdt/ussd#4 2024-08-26 04:56:50 +02:00
wip-account-creation

age needs to be calculated.

lash commented on pull request urdt/ussd#4 2024-08-26 04:56:50 +02:00
wip-account-creation

please rename this flag to USERFLAG_PINMISMATCH to avoid ambiguity.

lash commented on pull request urdt/ussd#4 2024-08-26 04:56:50 +02:00
wip-account-creation

should error?

lash commented on pull request urdt/ussd#4 2024-08-26 04:56:50 +02:00
wip-account-creation

this shouldnt switch on the input string; that requires manual syncing between here and the menu code.

lash commented on pull request urdt/ussd#4 2024-08-26 04:56:50 +02:00
wip-account-creation

could clients of this reuse the pinentry used for unlock instead?