urdt/ussd
5
0
Fork 0
Code Issues 50 Pull Requests 7 Actions Packages Projects Releases Wiki Activity

pin-reset #139

Merged
lash merged 61 commits from pin-reset into pre-mock-remove 2024-11-02 14:54:20 +01:00
Conversation 0 Commits 61 Files Changed 37 +396 -34
carlos commented 2024-10-28 13:21:26 +01:00
Member
Copy Link

Implements PIN reset for others for users with the privilege

Implements PIN reset for others for users with the privilege
carlos added 2 commits 2024-10-28 13:21:27 +01:00
carlos added 1 commit 2024-10-28 13:46:15 +01:00
carlos added 11 commits 2024-10-29 12:32:30 +01:00
carlos added 1 commit 2024-10-29 12:36:01 +01:00
carlos added 1 commit 2024-10-29 13:02:55 +01:00
carlos added 6 commits 2024-10-29 15:36:03 +01:00
carlos added 4 commits 2024-10-29 20:23:42 +01:00
carlos added 4 commits 2024-10-30 12:34:45 +01:00
carlos added 3 commits 2024-10-30 12:50:50 +01:00
carlos added 4 commits 2024-10-30 16:02:01 +01:00
carlos added 1 commit 2024-10-30 19:10:33 +01:00
carlos added 3 commits 2024-10-30 20:32:55 +01:00
carlos added 1 commit 2024-10-30 21:21:35 +01:00
carlos changed title from WIP: pin-reset to pin-reset 2024-10-31 07:14:04 +01:00
carlos requested review from lash 2024-10-31 07:14:35 +01:00
carlos added 1 commit 2024-10-31 07:22:07 +01:00
carlos added 1 commit 2024-10-31 07:39:13 +01:00
lash requested changes 2024-10-31 12:09:21 +01:00
cmd/main.go Outdated
@ -48,6 +49,9 @@ func main() {
ctx = context.WithValue(ctx, "Database", database)
pfp := path.Join(scriptDir, "pp.csv")
as, _ := utils.NewAdminStore(ctx, "admin_numbers")
lash commented 2024-10-31 12:08:20 +01:00
Owner
Copy Link

We are going to need all executables. Should this be instantiated somewhere else, since the path is known?

We are going to need all executables. Should this be instantiated somewhere else, since the path is known?
carlos commented 2024-10-31 18:19:45 +01:00
Author
Member
Copy Link

Sure,we can define it in the LocalHandlerService , then instantiate it in the NewHandlerService,consider: 12825ae08a ,will this work?

Sure,we can define it in the LocalHandlerService , then instantiate it in the NewHandlerService,consider: 12825ae08a268db47ce105271c41807d1130913a ,will this work?
internal/utils/adminstore.go Outdated
@ -0,0 +52,4 @@
store := as.fsStore
defer store.Close()
data, err := os.ReadFile("admin_numbers.json")
lash commented 2024-10-31 12:09:14 +01:00
Owner
Copy Link

Let's extract this into a devtools folder, separate executable.

Let's extract this into a devtools folder, separate executable.
carlos commented 2024-10-31 19:04:04 +01:00
Author
Member
Copy Link

Consider: 7fa38340dd

Consider: 7fa38340ddf3cfaab0207506d048db32bf82dc52
carlos added 1 commit 2024-10-31 14:38:51 +01:00
carlos added 3 commits 2024-10-31 18:11:52 +01:00
carlos added 6 commits 2024-10-31 19:01:44 +01:00
carlos added 1 commit 2024-10-31 19:11:12 +01:00
carlos added 1 commit 2024-11-01 04:39:56 +01:00
carlos added 1 commit 2024-11-01 07:36:11 +01:00
carlos added 1 commit 2024-11-01 09:52:05 +01:00
carlos added 1 commit 2024-11-01 14:27:20 +01:00
carlos added 1 commit 2024-11-01 14:45:10 +01:00
carlos added 1 commit 2024-11-01 14:46:31 +01:00
lash changed target branch from master to pre-mock-remove 2024-11-02 14:50:58 +01:00
lash approved these changes 2024-11-02 14:54:01 +01:00
devtools/main.go Outdated
@ -0,0 +1,17 @@
package main
lash commented 2024-10-31 21:15:16 +01:00
Owner
Copy Link

perhaps a subcommand or (easier) a subdirectory?

perhaps a subcommand or (easier) a subdirectory?
internal/handlers/handlerservice.go Outdated
@ -53,8 +62,12 @@ func (ls *LocalHandlerService) SetDataStore(db *db.Db) {
ls.UserdataStore = db
}
func (ls *LocalHandlerService) SetAdminStore(adminstore *utils.AdminStore) {
lash commented 2024-10-31 21:14:55 +01:00
Owner
Copy Link

this doesnt seem to be in use

this doesnt seem to be in use
lash merged commit 2587882eae into pre-mock-remove 2024-11-02 14:54:20 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
lash
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Activity:Doing

An item actively being worked on currently

  
Activity:Proposal

A proposal for a new feature or enhancement

  
Runner
AT

  
Runner
CLI

  
Runner
HTTP

  
cleanup

   
devops

   
easypeasy

A task that can be completed with little effort

  
exchange

relating to swapping of assets and offramps

  
l8ter

   
legacy

Legacy features from the old ussd system to be ported

  
optimization

   
privilege

features that have to do with special, privileged axx

  
refactor

   
smell

Code smell

  
support

transparency and help with exception states

  
tooling

   
ux
No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Activity:Doing
Activity:Proposal
Runner
AT
Runner
CLI
Runner
HTTP
cleanup
devops
easypeasy
exchange
l8ter
legacy
optimization
privilege
refactor
smell
support
tooling
ux
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: urdt/ussd#139
No description provided.
Delete Branch "pin-reset"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?