urdt/ussd
5
0
Fork 1
Code Issues 41 Pull Requests Actions Packages Projects Releases Wiki Activity

pin-reset #139

Merged
lash merged 61 commits from pin-reset into pre-mock-remove 2024-11-02 14:54:20 +01:00
Conversation 2 Commits 61 Files Changed 37 +396 -34
carlos commented 2024-10-28 13:21:26 +01:00
Member
Copy Link

Implements PIN reset for others for users with the privilege

Implements PIN reset for others for users with the privilege
carlos added 2 commits 2024-10-28 13:21:27 +01:00
add admin privilege flag 72d5c186dd
add pin reset for others nodes 0cc0bdf9f7
carlos added 1 commit 2024-10-28 13:46:15 +01:00
setup pin reset nodes 3de46cef5e
carlos added 11 commits 2024-10-29 12:32:30 +01:00
define a key to hold number during pin reset e4c2f644f3
define handler functions required to reset others pin 26073c8000
setup an admin flag aec0abb2b6
add pin reset for others handling b97965193b
load and reload only after input e338ce0025
replace _ with explicit back node ca13d9155c
create a simple admin store for phone numbers c9bb93ede6
remove the admin flag,setup an admin store 41da099933
load admin numbers defined in the .env d83962c0ba
set admin privilege flag 5fd3eb3c29
add admin number defination in env 124049c924
carlos added 1 commit 2024-10-29 12:36:01 +01:00
Merge branch 'master' into pin-reset b35460d3c1
carlos added 1 commit 2024-10-29 13:02:55 +01:00
repeat same node on invalid option input e96c874300
carlos added 6 commits 2024-10-29 15:36:03 +01:00
add flag to catch unregistred numbers 449f90c95b
add node to handle unregistered phone numbers 6998c30dd1
catch unregistred phone numbers 534d756318
add reset unregistered number 91b85af11a
use explicit back to node 106983a394
add check for unregistered phone numbers d0ad6395b5
carlos added 4 commits 2024-10-29 20:23:42 +01:00
use _ for back navigation f37483e2f0
remove catch for unregistered number 7597b96dae
group regex,check for valid number against the regex 5a0563df94
catch unregistred number 0a97f610a4
carlos added 4 commits 2024-10-30 12:34:45 +01:00
setup an admin store based on fs b404ae95fb
provide required handler functions and admin store c42b1cd66b
update handler functions c2068db050
attach an admin store for phone numbers dc418771a7
carlos added 3 commits 2024-10-30 12:50:50 +01:00
define structure for admin numbers 017691a40c
add actual pin reset functionality 888d3befe9
update handler in test cf523e30f8
carlos added 4 commits 2024-10-30 16:02:01 +01:00
remove function exec after HALT d93a26f9b0
move catch and load to next node 41585f831c
move to root node after on back 7c823e07ca
check for phone number validity ea4c6d9314
carlos added 1 commit 2024-10-30 19:10:33 +01:00
Merge branch 'master' into pin-reset 8262e14198
carlos added 3 commits 2024-10-30 20:32:55 +01:00
remove print message 833d52a558
use 0 instead of 1 for back 8093eae61a
fix sink error c6ca3f6be4
carlos added 1 commit 2024-10-30 21:21:35 +01:00
catch incorrect pin entry d434194021
carlos changed title from WIP: pin-reset to pin-reset 2024-10-31 07:14:04 +01:00
carlos requested review from lash 2024-10-31 07:14:35 +01:00
carlos added 1 commit 2024-10-31 07:22:07 +01:00
remove extra spaces c4078c5280
carlos added 1 commit 2024-10-31 07:39:13 +01:00
remove pin guard menu option 767a3cd64c
lash requested changes 2024-10-31 12:09:21 +01:00
cmd/main.go Outdated
@@ -48,6 +49,9 @@ func main() {
ctx = context.WithValue(ctx, "Database", database)
pfp := path.Join(scriptDir, "pp.csv")
as, _ := utils.NewAdminStore(ctx, "admin_numbers")
lash commented 2024-10-31 12:08:20 +01:00
Owner
Copy Link

We are going to need all executables. Should this be instantiated somewhere else, since the path is known?

We are going to need all executables. Should this be instantiated somewhere else, since the path is known?
carlos commented 2024-10-31 18:19:45 +01:00
Author
Member
Copy Link

Sure,we can define it in the LocalHandlerService , then instantiate it in the NewHandlerService,consider: 12825ae08a ,will this work?

Sure,we can define it in the LocalHandlerService , then instantiate it in the NewHandlerService,consider: 12825ae08a268db47ce105271c41807d1130913a ,will this work?
internal/utils/adminstore.go Outdated
@@ -0,0 +52,4 @@
store := as.fsStore
defer store.Close()
data, err := os.ReadFile("admin_numbers.json")
lash commented 2024-10-31 12:09:14 +01:00
Owner
Copy Link

Let's extract this into a devtools folder, separate executable.

Let's extract this into a devtools folder, separate executable.
carlos commented 2024-10-31 19:04:04 +01:00
Author
Member
Copy Link

Consider: 7fa38340dd

Consider: 7fa38340ddf3cfaab0207506d048db32bf82dc52
carlos added 1 commit 2024-10-31 14:38:51 +01:00
Merge branch 'master' into pin-reset 8fe8ff540b
carlos added 3 commits 2024-10-31 18:11:52 +01:00
pass context ac0b4b2ed1
setup adminstore in the local handler service 12825ae08a
attach an admin store for the phone numbers 5abe9b78cc
carlos added 6 commits 2024-10-31 19:01:44 +01:00
remove seed from executable b2655b7f11
define seed as a command in the devtool 299534ccf1
remove seed 7aab3cff8c
add command to initialize a list of admin numbers 7fa38340dd
define structure of json 53fa6f64ce
remove from root 7d1a04f089
carlos added 1 commit 2024-10-31 19:11:12 +01:00
Merge branch 'master' into pin-reset 2704069e74
carlos added 1 commit 2024-11-01 04:39:56 +01:00
remove guard pin option 0014693ba8
carlos added 1 commit 2024-11-01 07:36:11 +01:00
change fs store path to root 7e448f739a
carlos added 1 commit 2024-11-01 09:52:05 +01:00
remove unused setadmin store eb2c73dce1
carlos added 1 commit 2024-11-01 14:27:20 +01:00
Merge branch 'master' into pin-reset 5e4a9e7567
carlos added 1 commit 2024-11-01 14:45:10 +01:00
wrap in devtools/admin 332074375a
carlos added 1 commit 2024-11-01 14:46:31 +01:00
use single temporary value 6dbe74d12b
lash changed target branch from master to pre-mock-remove 2024-11-02 14:50:58 +01:00
lash approved these changes 2024-11-02 14:54:01 +01:00
devtools/main.go Outdated
@@ -0,0 +1,17 @@
package main
lash commented 2024-10-31 21:15:16 +01:00
Owner
Copy Link

perhaps a subcommand or (easier) a subdirectory?

perhaps a subcommand or (easier) a subdirectory?
internal/handlers/handlerservice.go Outdated
@@ -53,8 +62,12 @@ func (ls *LocalHandlerService) SetDataStore(db *db.Db) {
ls.UserdataStore = db
}
func (ls *LocalHandlerService) SetAdminStore(adminstore *utils.AdminStore) {
lash commented 2024-10-31 21:14:55 +01:00
Owner
Copy Link

this doesnt seem to be in use

this doesnt seem to be in use
lash merged commit 2587882eae into pre-mock-remove 2024-11-02 14:54:20 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Activity
Doing
An item actively being worked on currently
Activity
Hold
Not being actively worked on
Activity
Proposal
A proposal for a new feature or enhancement
Activity
QA
Ready for QA testing
Activity
Validate
Dev team validating changes
Runner
AT
Runner
CLI
Runner
HTTP
Runner
SSH
cleanup
devops
documentation
easypeasy
A task that can be completed with little effort
 exchange
relating to swapping of assets and offramps
 i18n
Languages and translations
 legacy
Legacy features from the old ussd system to be ported
 meta
container for other issues
 migration
optimization
privilege
features that have to do with special, privileged axx
 refactor
smell
Code smell
 support
transparency and help with exception states
 tooling
ux
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk carlos kamikazechaser lash willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: urdt/ussd#139
Delete Branch "pin-reset"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?