urdt/ussd
5
0
Fork 1
Code Issues 41 Pull Requests Actions Packages Projects Releases Wiki Activity

africas-talking #50

Merged
lash merged 8 commits from africas-talking into lash/async-driver 2024-09-14 16:28:06 +02:00
Conversation 2 Commits 8 Files Changed 6 +361 -10
Alfred-mk commented 2024-09-12 22:03:01 +02:00
Member
Copy Link

Adding Africa's Taking (AT) specific functionality

  • Process requests and get the correct phoneNumber as sessionId and text as input
  • Respond and append the "CON " and "END " to the output as per AT's USSD requirements
Adding Africa's Taking (AT) specific functionality * Process requests and get the correct phoneNumber as sessionId and text as input * Respond and append the "CON " and "END " to the output as per AT's USSD requirements
Alfred-mk added 6 commits 2024-09-12 22:03:01 +02:00
Isolate http specific parts to minimal dde9f552a6
Factor out methods common to http and async cli d49f866ca4
Add shutdown to async, rehabilitate http cmd b31d3b907a
Update go-vise 9c751aff30
Use latest go-vise package ffeb28e851
Added africastalking binary 5e4e6a21a0
Alfred-mk added 1 commit 2024-09-12 22:53:19 +02:00
Added Continue bool to track whether the execution should be terminated 762f90adf6
Alfred-mk added 2 commits 2024-09-13 15:03:48 +02:00
Added Custom AtOutput to append CON or END to output 512460fdeb
have AtOutput as an option b53658e038
lash requested changes 2024-09-13 16:33:27 +02:00
Dismissed
cmd/africastalking/main.go Outdated
@@ -0,0 +232,4 @@
rp := &atRequestParser{}
bsh := handlers.NewBaseSessionHandler(cfg, rs, stateStore, userdataStore, rp, hl)
sh := httpserver.ToSessionHandler(bsh, httpserver.WithAtOutput())
lash commented 2024-09-13 16:28:27 +02:00
Owner
Copy Link

In general, chainable functions should be called ON the object instead of being an argument TO The object.

In general, chainable functions should be called ON the object instead of being an argument TO The object.
Alfred-mk marked this conversation as resolved
cmd/http/main.go
@@ -192,2 +194,3 @@
//sh := httpserver.NewSessionHandler(cfg, rs, stateStore, userdataStore, rp, hl.Init)
sh := httpserver.NewSessionHandler(cfg, rs, stateStore, userdataStore, rp, hl)
bsh := handlers.NewBaseSessionHandler(cfg, rs, stateStore, userdataStore, rp, hl)
sh := httpserver.ToSessionHandler(bsh)
lash commented 2024-09-13 16:29:22 +02:00
Owner
Copy Link

In fact, I should have implemented this as chainable, too. My bad.

In fact, I should have implemented this as chainable, too. My bad.
internal/handlers/base.go
@@ -0,0 +1,123 @@
package handlers
lash commented 2024-09-13 16:30:09 +02:00
Owner
Copy Link

It would be better to have this PR against my async branch, because here we cannot see the differences....

It would be better to have this PR against my async branch, because here we cannot see the differences....
Alfred-mk commented 2024-09-13 21:52:10 +02:00
Author
Member
Copy Link

I've updated the PR to reflect this

I've updated the PR to reflect this
lash marked this conversation as resolved
internal/handlers/base.go Outdated
@@ -0,0 +90,4 @@
return rqs, err
}
func (f *BaseSessionHandler) AtOutput(rqs RequestSession) (RequestSession, error) {
lash commented 2024-09-13 16:32:38 +02:00
Owner
Copy Link

This method should not exist in the base handler. Please EXTEND the handler to adapt it to your needs.

In fact, you probably need to extend the internal/http/server.go SessionHandler instead, since it in turn extends this, and also provides other functionality you need.

BaseSessionHandler -> http.SessionHandler -> at.SessionHandler

This method should not exist in the base handler. Please EXTEND the handler to adapt it to your needs. In fact, you probably need to extend the internal/http/server.go SessionHandler instead, since it in turn extends this, and also provides other functionality you need. BaseSessionHandler -> http.SessionHandler -> at.SessionHandler
Alfred-mk marked this conversation as resolved
internal/http/server.go Outdated
@@ -133,3 +127,1 @@
if err != nil {
f.writeError(w, 500, "Write result fail", err)
return
if f.useAtOutput {
lash commented 2024-09-13 16:33:21 +02:00
Owner
Copy Link

Similary here, Please do not put AT speicifc code in the generic http code. Please use your own extension of the class.

Similary here, Please do not put AT speicifc code in the generic http code. Please use your own extension of the class.
Alfred-mk marked this conversation as resolved
Alfred-mk changed target branch from master to lash/async-driver 2024-09-13 21:51:09 +02:00
Alfred-mk added 2 commits 2024-09-14 14:57:31 +02:00
use the new AtSessionHandler 3cb0b099e4
removed AT specific code 1e9c9cf6ad
Alfred-mk requested review from lash 2024-09-14 14:59:24 +02:00
Alfred-mk changed title from WIP: africas-talking to africas-talking 2024-09-14 15:55:08 +02:00
Alfred-mk added 1 commit 2024-09-14 16:01:20 +02:00
Update the func name to Output 6fe2e7287f 
Signed-off-by: Alfred Kamanda <alfredkamandamw@gmail.com>
lash approved these changes 2024-09-14 16:27:59 +02:00
lash merged commit f4f475bd45 into lash/async-driver 2024-09-14 16:28:06 +02:00
Alfred-mk deleted branch africas-talking 2024-09-20 11:11:08 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Activity
Doing
An item actively being worked on currently
Activity
Hold
Not being actively worked on
Activity
Proposal
A proposal for a new feature or enhancement
Activity
QA
Ready for QA testing
Activity
Validate
Dev team validating changes
Runner
AT
Runner
CLI
Runner
HTTP
Runner
SSH
cleanup
devops
documentation
easypeasy
A task that can be completed with little effort
 exchange
relating to swapping of assets and offramps
 i18n
Languages and translations
 legacy
Legacy features from the old ussd system to be ported
 meta
container for other issues
 migration
optimization
privilege
features that have to do with special, privileged axx
 refactor
smell
Code smell
 support
transparency and help with exception states
 tooling
ux
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk carlos kamikazechaser lash willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: urdt/ussd#50
Delete Branch "africas-talking"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?