africas-talking #50

2024-09-12T22:03:01+02:00

Alfred-mk commented

2024-09-12 22:03:01 +02:00

Adding Africa's Taking (AT) specific functionality

Process requests and get the correct phoneNumber as sessionId and text as input
Respond and append the "CON " and "END " to the output as per AT's USSD requirements

Adding Africa's Taking (AT) specific functionality * Process requests and get the correct phoneNumber as sessionId and text as input * Respond and append the "CON " and "END " to the output as per AT's USSD requirements

Alfred-mk added 6 commits 2024-09-12 22:03:01 +02:00

Isolate http specific parts to minimal dde9f552a6

Factor out methods common to http and async cli d49f866ca4

Add shutdown to async, rehabilitate http cmd b31d3b907a

Update go-vise 9c751aff30

Use latest go-vise package ffeb28e851

Added africastalking binary 5e4e6a21a0

Alfred-mk added 1 commit 2024-09-12 22:53:19 +02:00

Added Continue bool to track whether the execution should be terminated 762f90adf6

Alfred-mk added 2 commits 2024-09-13 15:03:48 +02:00

Added Custom AtOutput to append CON or END to output 512460fdeb

have AtOutput as an option b53658e038

lash requested changes 2024-09-13 16:33:27 +02:00

Dismissed

cmd/africastalking/main.go Outdated

						
				@@ -0,0 +232,4 @@

					rp := &atRequestParser{}

					bsh := handlers.NewBaseSessionHandler(cfg, rs, stateStore, userdataStore, rp, hl)

					sh := httpserver.ToSessionHandler(bsh, httpserver.WithAtOutput())

lash commented

2024-09-13 16:28:27 +02:00

In general, chainable functions should be called ON the object instead of being an argument TO The object.

Alfred-mk marked this conversation as resolved

cmd/http/main.go

						
				@@ -192,2 +194,3 @@

					//sh := httpserver.NewSessionHandler(cfg, rs, stateStore, userdataStore, rp, hl.Init)

					sh := httpserver.NewSessionHandler(cfg, rs, stateStore, userdataStore, rp, hl)

					bsh := handlers.NewBaseSessionHandler(cfg, rs, stateStore, userdataStore, rp, hl)

					sh := httpserver.ToSessionHandler(bsh)

lash commented

2024-09-13 16:29:22 +02:00

In fact, I should have implemented this as chainable, too. My bad.

internal/handlers/base.go

						
				@@ -0,0 +1,123 @@

				package handlers

lash commented

2024-09-13 16:30:09 +02:00

It would be better to have this PR against my async branch, because here we cannot see the differences....

Alfred-mk commented

2024-09-13 21:52:10 +02:00

I've updated the PR to reflect this

lash marked this conversation as resolved

internal/handlers/base.go Outdated

						
				@@ -0,0 +90,4 @@

					return rqs, err

				}

				func (f *BaseSessionHandler) AtOutput(rqs RequestSession) (RequestSession, error) {

lash commented

2024-09-13 16:32:38 +02:00

This method should not exist in the base handler. Please EXTEND the handler to adapt it to your needs.

In fact, you probably need to extend the internal/http/server.go SessionHandler instead, since it in turn extends this, and also provides other functionality you need.

BaseSessionHandler -> http.SessionHandler -> at.SessionHandler

This method should not exist in the base handler. Please EXTEND the handler to adapt it to your needs. In fact, you probably need to extend the internal/http/server.go SessionHandler instead, since it in turn extends this, and also provides other functionality you need. BaseSessionHandler -> http.SessionHandler -> at.SessionHandler

Alfred-mk marked this conversation as resolved

internal/http/server.go Outdated

						
				@@ -133,3 +127,1 @@

					if err != nil {

						f.writeError(w, 500, "Write result fail", err)

						return

					if f.useAtOutput {

lash commented

2024-09-13 16:33:21 +02:00

Similary here, Please do not put AT speicifc code in the generic http code. Please use your own extension of the class.

Alfred-mk marked this conversation as resolved

Alfred-mk changed target branch from master to lash/async-driver

2024-09-13 21:51:09 +02:00

Alfred-mk added 2 commits 2024-09-14 14:57:31 +02:00

use the new AtSessionHandler 3cb0b099e4

removed AT specific code 1e9c9cf6ad

Alfred-mk requested review from lash 2024-09-14 14:59:24 +02:00

Alfred-mk marked the pull request as ready for review 2024-09-14 15:55:08 +02:00

Alfred-mk added 1 commit 2024-09-14 16:01:20 +02:00

Update the func name to Output 6fe2e7287f

Signed-off-by: Alfred Kamanda <alfredkamandamw@gmail.com>

lash approved these changes 2024-09-14 16:27:59 +02:00

lash merged commit f4f475bd45 into lash/async-driver

2024-09-14 16:28:06 +02:00

lash referenced this issue from a commit

2024-09-14 16:28:07 +02:00

Merge pull request 'africas-talking' (#50) from africas-talking into lash/async-driver

Alfred-mk deleted branch africas-talking

2024-09-20 11:11:08 +02:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: urdt/ussd#50

				`@@ -0,0 +1,123 @@`
				`package handlers`