change-language #58

Alfred-mk · 2024-09-16T11:05:18+02:00

Alfred-mk commented

2024-09-16 11:05:18 +02:00

Add menus and functionality to change the set language

Alfred-mk added 1 commit 2024-09-16 15:03:46 +02:00

added the SetNewLanguage function 353c38be46

Alfred-mk added 3 commits 2024-09-16 15:07:29 +02:00

added change_language node and templates 6437d2e4df

change language b7783073cf

add the change_language functionality to the account menu 1e99db2bd7

Alfred-mk added 1 commit 2024-09-16 15:13:20 +02:00

added quit menu to handle eng and swa ea68edff3d

Alfred-mk added 2 commits 2024-09-16 15:58:27 +02:00

remove new lines on templates and menus to clean up the empty spaces on the menu 9953ae3e56

added the profile info on the swa menu template 89da7fc741

Alfred-mk added 2 commits 2024-09-16 16:08:49 +02:00

ensure a PIN is set before changing the language fe7c04c0dd

remove extra space ca81b041f1

Alfred-mk commented

2024-09-16 16:12:04 +02:00

Also updated the templates and menu files by removing new lines at the end for a much cleaner look

Alfred-mk force-pushed change-language from ca81b041f1 to dc14480519

2024-09-16 16:30:44 +02:00

Compare

Alfred-mk changed title from ~~WIP: change-language~~ to change-language

2024-09-16 16:31:56 +02:00

Alfred-mk requested review from lash 2024-09-16 16:32:17 +02:00

lash requested changes 2024-09-16 18:28:11 +02:00

internal/handlers/ussd/menuhandler.go Outdated

						
				@ -1048,0 +1053,4 @@

					inputStr := string(input)

					switch inputStr {

					case "0":

lash commented

2024-09-16 18:27:58 +02:00

We must not switch on selector input. Please find a different way to do it, e.g. move to another node.

We _must not_ switch on selector input. Please find a different way to do it, e.g. move to another node.

Alfred-mk marked this conversation as resolved

Alfred-mk added 3 commits 2024-09-17 14:32:00 +02:00

use a single set_language function for setting and changing language 065c8e5c1d

use dedicated nodes to set the language 01f7571185

added missing functions to the other getHandlers 2e7c07e6f4

Alfred-mk requested review from lash 2024-09-17 14:32:39 +02:00

Alfred-mk added a new dependency 2024-09-17 14:33:06 +02:00

#61 Should be possible to use template with help node

Alfred-mk removed a dependency 2024-09-17 14:33:26 +02:00

#61 Should be possible to use template with help node

Alfred-mk added a new dependency 2024-09-17 14:34:40 +02:00

#5 Remove menu selector based switch statement in SetLanguage

lash reviewed 2024-09-17 14:57:45 +02:00

lash left a comment

test fail

=== RUN   TestSetLanguage/English_language
--- FAIL: TestSetLanguage (0.00s)
    --- FAIL: TestSetLanguage/English_language (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x5f724c]

goroutine 42 [running]:
testing.tRunner.func1.2({0x63c520, 0x86ae40})
        /usr/lib/go/src/testing/testing.go:1632 +0x230
testing.tRunner.func1()
        /usr/lib/go/src/testing/testing.go:1635 +0x35e
panic({0x63c520?, 0x86ae40?})
        /usr/lib/go/src/runtime/panic.go:785 +0x132
git.defalsify.org/vise.git/state.(*State).Where(...)
        /home/lash/.go/pkg/mod/git.defalsify.org/vise.git@v0.1.0-rc.3.0.20240911231817-0d23e0dbb57f/state/state.go:203
git.grassecon.net/urdt/ussd/internal/handlers/ussd.(*Handlers).SetLanguage(0x0?, {0x0?, 0x604?}, {0x4f7940?, 0x812f80?}, {0x841f20?, 0x6603c0?, 0x682a01?})
        /srv/git/grassrootseconomics/urdt-ussd.git/internal/handlers/ussd/menuhandler.go:125 +0x6c
git.grassecon.net/urdt/ussd/internal/handlers/ussd.TestSetLanguage.func1(0xc0001e1040)
        /srv/git/grassrootseconomics/urdt-ussd.git/internal/handlers/ussd/menuhandler_test.go:591 +0xa5
testing.tRunner(0xc0001e1040, 0xc000126ff0)
        /usr/lib/go/src/testing/testing.go:1690 +0xf4
created by testing.(*T).Run in goroutine 41
        /usr/lib/go/src/testing/testing.go:1743 +0x390
FAIL    git.grassecon.net/urdt/ussd/internal/handlers/ussd      0.008s
FAIL

test fail ``` === RUN TestSetLanguage/English_language --- FAIL: TestSetLanguage (0.00s) --- FAIL: TestSetLanguage/English_language (0.00s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x5f724c] goroutine 42 [running]: testing.tRunner.func1.2({0x63c520, 0x86ae40}) /usr/lib/go/src/testing/testing.go:1632 +0x230 testing.tRunner.func1() /usr/lib/go/src/testing/testing.go:1635 +0x35e panic({0x63c520?, 0x86ae40?}) /usr/lib/go/src/runtime/panic.go:785 +0x132 git.defalsify.org/vise.git/state.(*State).Where(...) /home/lash/.go/pkg/mod/git.defalsify.org/vise.git@v0.1.0-rc.3.0.20240911231817-0d23e0dbb57f/state/state.go:203 git.grassecon.net/urdt/ussd/internal/handlers/ussd.(*Handlers).SetLanguage(0x0?, {0x0?, 0x604?}, {0x4f7940?, 0x812f80?}, {0x841f20?, 0x6603c0?, 0x682a01?}) /srv/git/grassrootseconomics/urdt-ussd.git/internal/handlers/ussd/menuhandler.go:125 +0x6c git.grassecon.net/urdt/ussd/internal/handlers/ussd.TestSetLanguage.func1(0xc0001e1040) /srv/git/grassrootseconomics/urdt-ussd.git/internal/handlers/ussd/menuhandler_test.go:591 +0xa5 testing.tRunner(0xc0001e1040, 0xc000126ff0) /usr/lib/go/src/testing/testing.go:1690 +0xf4 created by testing.(*T).Run in goroutine 41 /usr/lib/go/src/testing/testing.go:1743 +0x390 FAIL git.grassecon.net/urdt/ussd/internal/handlers/ussd 0.008s FAIL ```

Alfred-mk added 1 commit 2024-09-17 17:54:30 +02:00

run TestSetLanguage with execPath instead of input 75ab9c66a3

lash added 1 commit 2024-09-17 18:30:54 +02:00

Merge branch 'master' into change-language 2982f08b41

lash merged commit 4098ac8a19 into master

2024-09-17 18:31:11 +02:00

lash referenced this issue from a commit

2024-09-17 18:31:11 +02:00

Merge pull request 'change-language' (#58) from change-language into master

Sign in to join this conversation.

No reviewers