urdt/ussd
5
0
Fork 0
Code Issues 33 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

change-language #58

Merged
lash merged 14 commits from change-language into master 2024-09-17 18:31:11 +02:00
Conversation 1 Commits 14 Files Changed 58 +107 -77
Alfred-mk commented 2024-09-16 11:05:18 +02:00
Member
Copy Link

Add menus and functionality to change the set language

Add menus and functionality to change the set language
Alfred-mk added 1 commit 2024-09-16 15:03:46 +02:00
Alfred-mk added 3 commits 2024-09-16 15:07:29 +02:00
Alfred-mk added 1 commit 2024-09-16 15:13:20 +02:00
Alfred-mk added 2 commits 2024-09-16 15:58:27 +02:00
Alfred-mk added 2 commits 2024-09-16 16:08:49 +02:00
Alfred-mk commented 2024-09-16 16:12:04 +02:00
Author
Member
Copy Link

Also updated the templates and menu files by removing new lines at the end for a much cleaner look

Also updated the templates and menu files by removing new lines at the end for a much cleaner look
Alfred-mk force-pushed change-language from ca81b041f1 to dc14480519 2024-09-16 16:30:44 +02:00 Compare
Alfred-mk changed title from WIP: change-language to change-language 2024-09-16 16:31:56 +02:00
Alfred-mk requested review from lash 2024-09-16 16:32:17 +02:00
lash requested changes 2024-09-16 18:28:11 +02:00
internal/handlers/ussd/menuhandler.go Outdated
@ -1048,0 +1053,4 @@
inputStr := string(input)
switch inputStr {
case "0":
lash commented 2024-09-16 18:27:58 +02:00
Owner
Copy Link

We must not switch on selector input. Please find a different way to do it, e.g. move to another node.

We _must not_ switch on selector input. Please find a different way to do it, e.g. move to another node.
Alfred-mk marked this conversation as resolved
Alfred-mk added 3 commits 2024-09-17 14:32:00 +02:00
Alfred-mk requested review from lash 2024-09-17 14:32:39 +02:00
Alfred-mk added a new dependency 2024-09-17 14:33:06 +02:00
#61 Should be possible to use template with help node
Alfred-mk removed a dependency 2024-09-17 14:33:26 +02:00
#61 Should be possible to use template with help node
Alfred-mk added a new dependency 2024-09-17 14:34:40 +02:00
#5 Remove menu selector based switch statement in SetLanguage
lash reviewed 2024-09-17 14:57:45 +02:00
lash left a comment
Owner
Copy Link

test fail

=== RUN   TestSetLanguage/English_language
--- FAIL: TestSetLanguage (0.00s)
    --- FAIL: TestSetLanguage/English_language (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x5f724c]

goroutine 42 [running]:
testing.tRunner.func1.2({0x63c520, 0x86ae40})
        /usr/lib/go/src/testing/testing.go:1632 +0x230
testing.tRunner.func1()
        /usr/lib/go/src/testing/testing.go:1635 +0x35e
panic({0x63c520?, 0x86ae40?})
        /usr/lib/go/src/runtime/panic.go:785 +0x132
git.defalsify.org/vise.git/state.(*State).Where(...)
        /home/lash/.go/pkg/mod/git.defalsify.org/vise.git@v0.1.0-rc.3.0.20240911231817-0d23e0dbb57f/state/state.go:203
git.grassecon.net/urdt/ussd/internal/handlers/ussd.(*Handlers).SetLanguage(0x0?, {0x0?, 0x604?}, {0x4f7940?, 0x812f80?}, {0x841f20?, 0x6603c0?, 0x682a01?})
        /srv/git/grassrootseconomics/urdt-ussd.git/internal/handlers/ussd/menuhandler.go:125 +0x6c
git.grassecon.net/urdt/ussd/internal/handlers/ussd.TestSetLanguage.func1(0xc0001e1040)
        /srv/git/grassrootseconomics/urdt-ussd.git/internal/handlers/ussd/menuhandler_test.go:591 +0xa5
testing.tRunner(0xc0001e1040, 0xc000126ff0)
        /usr/lib/go/src/testing/testing.go:1690 +0xf4
created by testing.(*T).Run in goroutine 41
        /usr/lib/go/src/testing/testing.go:1743 +0x390
FAIL    git.grassecon.net/urdt/ussd/internal/handlers/ussd      0.008s
FAIL
test fail ``` === RUN TestSetLanguage/English_language --- FAIL: TestSetLanguage (0.00s) --- FAIL: TestSetLanguage/English_language (0.00s) panic: runtime error: invalid memory address or nil pointer dereference [recovered] panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x5f724c] goroutine 42 [running]: testing.tRunner.func1.2({0x63c520, 0x86ae40}) /usr/lib/go/src/testing/testing.go:1632 +0x230 testing.tRunner.func1() /usr/lib/go/src/testing/testing.go:1635 +0x35e panic({0x63c520?, 0x86ae40?}) /usr/lib/go/src/runtime/panic.go:785 +0x132 git.defalsify.org/vise.git/state.(*State).Where(...) /home/lash/.go/pkg/mod/git.defalsify.org/vise.git@v0.1.0-rc.3.0.20240911231817-0d23e0dbb57f/state/state.go:203 git.grassecon.net/urdt/ussd/internal/handlers/ussd.(*Handlers).SetLanguage(0x0?, {0x0?, 0x604?}, {0x4f7940?, 0x812f80?}, {0x841f20?, 0x6603c0?, 0x682a01?}) /srv/git/grassrootseconomics/urdt-ussd.git/internal/handlers/ussd/menuhandler.go:125 +0x6c git.grassecon.net/urdt/ussd/internal/handlers/ussd.TestSetLanguage.func1(0xc0001e1040) /srv/git/grassrootseconomics/urdt-ussd.git/internal/handlers/ussd/menuhandler_test.go:591 +0xa5 testing.tRunner(0xc0001e1040, 0xc000126ff0) /usr/lib/go/src/testing/testing.go:1690 +0xf4 created by testing.(*T).Run in goroutine 41 /usr/lib/go/src/testing/testing.go:1743 +0x390 FAIL git.grassecon.net/urdt/ussd/internal/handlers/ussd 0.008s FAIL ```
Alfred-mk added 1 commit 2024-09-17 17:54:30 +02:00
lash added 1 commit 2024-09-17 18:30:54 +02:00
lash merged commit 4098ac8a19 into master 2024-09-17 18:31:11 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
lash
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Runner
AT

  
Runner
CLI

  
Runner
HTTP

  
cleanup

   
easy

A task that can be completed with little effort

  
optimization

   
refactor

   
smell

Code smell

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Runner
AT
Runner
CLI
Runner
HTTP
cleanup
easy
optimization
refactor
smell
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks
#5 Remove menu selector based switch statement in SetLanguage
urdt/ussd
Reference: urdt/ussd#58
No description provided.
Delete Branch "change-language"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?