go-vise-0.2.0

Alfred-mk commented

2024-09-20 12:34:01 +02:00

Member

This PR implements go-vise 0.2.0

Alfred-mk added 2 commits 2024-09-20 12:34:01 +02:00

use latest commit from go-vise 0.2.0 b66891a646

remove init and use Exec e6e701a609

Alfred-mk added a new dependency 2024-09-20 12:38:08 +02:00

#64 Implement on go-vise 0.2.0

Alfred-mk added 1 commit 2024-09-20 12:54:49 +02:00

removed unused code a1056cf287

Alfred-mk requested review from lash 2024-09-20 14:20:55 +02:00

Alfred-mk added 3 commits 2024-09-20 21:17:04 +02:00

use updated latest commit from go-vise 0.2.0 9925b3a2e5

rename all WriteResult to Flush 63c7c65a00

remove need for initial Exec before loop e754773bce

Alfred-mk commented

2024-09-20 21:24:44 +02:00

Author

Member

@lash kindly confirm if all changes have been implemented

lash commented

2024-09-20 23:09:16 +02:00

Owner

I am not sure what the cause is, but now the state is not being persisted as expected:

[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" 
Welcome to Sarafu Network
Please select a language
0:english
1:kiswahili
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "0"
Do you agree to terms and conditions?
0:yes
1:no[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "0"
Please enter a new four number PIN for your account:
0:Exit
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234"
Enter your four number PIN again:
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234"
Your account is being created...Thank you for using Sarafu. Goodbye!
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" 
Enter your four number PIN again:
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234"
Your account is being created...Thank you for using Sarafu. Goodbye!
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" 
Enter your four number PIN again:
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" 
Enter your four number PIN again:
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234"
Your account is being created...Thank you for using Sarafu. Goodbye!
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" 
Enter your four number PIN again:

I did however notice that one of the examples in dev-0.2.0 behaved differently after the last change, and that had to do with async state updates. I'll make this as "need more info" for now, while I investigate.

I am not sure what the cause is, but now the state is not being persisted as expected: ``` [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" Welcome to Sarafu Network Please select a language 0:english 1:kiswahili [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "0" Do you agree to terms and conditions? 0:yes 1:no[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "0" Please enter a new four number PIN for your account: 0:Exit [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234" Enter your four number PIN again: [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234" Your account is being created...Thank you for using Sarafu. Goodbye! [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" Enter your four number PIN again: [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234" Your account is being created...Thank you for using Sarafu. Goodbye! [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" Enter your four number PIN again: [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" Enter your four number PIN again: [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234" Your account is being created...Thank you for using Sarafu. Goodbye! [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" Enter your four number PIN again: ``` I did however notice that one of the examples in dev-0.2.0 behaved differently after the last change, and that had to do with async state updates. I'll make this as "need more info" for now, while I investigate.

lash changed title from ~~go-vise-0.2.0~~ to WIP: go-vise-0.2.0

2024-09-20 23:18:34 +02:00

lash changed title from ~~WIP: go-vise-0.2.0~~ to go-vise-0.2.0

2024-09-21 00:00:55 +02:00

lash commented

2024-09-21 00:04:44 +02:00

Owner

Fixed in go-vise 39b8e4e6b7a6be892be740d3ede34d4d3ccc3b35

Engine persistence was broken, which wasn't picked up by any of the tests in urdt-ussd, but strictly it is not the responsibility of urdt-ussd to do it.

Will make sure have at least one regression test for it upstream. Sorry

Fixed in go-vise 39b8e4e6b7a6be892be740d3ede34d4d3ccc3b35 Engine persistence was broken, which wasn't picked up by any of the tests in urdt-ussd, but strictly it is not the responsibility of urdt-ussd to do it. Will make sure have at least one regression test for it upstream. Sorry

lash commented

2024-09-21 00:05:50 +02:00

Owner

resolved by #64

resolved by https://git.grassecon.net/urdt/ussd/issues/64

lash removed a dependency 2024-09-21 00:05:58 +02:00

#64 Implement on go-vise 0.2.0

lash merged commit 4439cc249a into master

2024-09-21 00:06:07 +02:00

lash referenced this issue from a commit

2024-09-21 00:06:08 +02:00

Merge pull request 'go-vise-0.2.0' (#71) from go-vise-0.2.0 into master

go-vise-0.2.0 #71