urdt/ussd
5
0
Fork 0
Code Issues 36 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

go-vise-0.2.0 #71

Merged
lash merged 6 commits from go-vise-0.2.0 into master 2024-09-21 00:06:07 +02:00
Conversation 4 Commits 6 Files Changed 8 +20 -36
Alfred-mk commented 2024-09-20 12:34:01 +02:00
Member
Copy Link

This PR implements go-vise 0.2.0

This PR implements go-vise 0.2.0
Alfred-mk added 2 commits 2024-09-20 12:34:01 +02:00
Alfred-mk added a new dependency 2024-09-20 12:38:08 +02:00
#64 Implement on go-vise 0.2.0
Alfred-mk added 1 commit 2024-09-20 12:54:49 +02:00
Alfred-mk requested review from lash 2024-09-20 14:20:55 +02:00
Alfred-mk added 3 commits 2024-09-20 21:17:04 +02:00
Alfred-mk commented 2024-09-20 21:24:44 +02:00
Author
Member
Copy Link

@lash kindly confirm if all changes have been implemented

@lash kindly confirm if all changes have been implemented
lash commented 2024-09-20 23:09:16 +02:00
Owner
Copy Link

I am not sure what the cause is, but now the state is not being persisted as expected:

[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" 
Welcome to Sarafu Network
Please select a language
0:english
1:kiswahili
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "0"
Do you agree to terms and conditions?
0:yes
1:no[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "0"
Please enter a new four number PIN for your account:
0:Exit
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234"
Enter your four number PIN again:
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234"
Your account is being created...Thank you for using Sarafu. Goodbye!
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" 
Enter your four number PIN again:
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234"
Your account is being created...Thank you for using Sarafu. Goodbye!
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" 
Enter your four number PIN again:
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" 
Enter your four number PIN again:
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234"
Your account is being created...Thank you for using Sarafu. Goodbye!
[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" 
Enter your four number PIN again:

I did however notice that one of the examples in dev-0.2.0 behaved differently after the last change, and that had to do with async state updates. I'll make this as "need more info" for now, while I investigate.

I am not sure what the cause is, but now the state is not being persisted as expected: ``` [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" Welcome to Sarafu Network Please select a language 0:english 1:kiswahili [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "0" Do you agree to terms and conditions? 0:yes 1:no[lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "0" Please enter a new four number PIN for your account: 0:Exit [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234" Enter your four number PIN again: [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234" Your account is being created...Thank you for using Sarafu. Goodbye! [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" Enter your four number PIN again: [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234" Your account is being created...Thank you for using Sarafu. Goodbye! [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" Enter your four number PIN again: [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" Enter your four number PIN again: [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" --data "1234" Your account is being created...Thank you for using Sarafu. Goodbye! [lash@contralto urdt-ussd.git]$ curl -XPOST http://localhost:7123 -H "X-Vise-Session: cswergiuh" Enter your four number PIN again: ``` I did however notice that one of the examples in dev-0.2.0 behaved differently after the last change, and that had to do with async state updates. I'll make this as "need more info" for now, while I investigate.
lash changed title from go-vise-0.2.0 to WIP: go-vise-0.2.0 2024-09-20 23:18:34 +02:00
lash changed title from WIP: go-vise-0.2.0 to go-vise-0.2.0 2024-09-21 00:00:55 +02:00
lash commented 2024-09-21 00:04:44 +02:00
Owner
Copy Link

Fixed in go-vise 39b8e4e6b7a6be892be740d3ede34d4d3ccc3b35

Engine persistence was broken, which wasn't picked up by any of the tests in urdt-ussd, but strictly it is not the responsibility of urdt-ussd to do it.

Will make sure have at least one regression test for it upstream. Sorry

Fixed in go-vise 39b8e4e6b7a6be892be740d3ede34d4d3ccc3b35 Engine persistence was broken, which wasn't picked up by any of the tests in urdt-ussd, but strictly it is not the responsibility of urdt-ussd to do it. Will make sure have at least one regression test for it upstream. Sorry
lash commented 2024-09-21 00:05:50 +02:00
Owner
Copy Link

resolved by #64

resolved by https://git.grassecon.net/urdt/ussd/issues/64
lash removed a dependency 2024-09-21 00:05:58 +02:00
#64 Implement on go-vise 0.2.0
lash merged commit 4439cc249a into master 2024-09-21 00:06:07 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
lash
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Runner
AT

  
Runner
CLI

  
Runner
HTTP

  
cleanup

   
easy

A task that can be completed with little effort

  
exchange

relating to swapping of assets and offramps

  
optimization

   
privilege

features that have to do with special, privileged axx

  
refactor

   
smell

Code smell

  
support

transparency and help with exception states

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Runner
AT
Runner
CLI
Runner
HTTP
cleanup
easy
exchange
optimization
privilege
refactor
smell
support
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: urdt/ussd#71
No description provided.
Delete Branch "go-vise-0.2.0"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?