urdt/ussd

api-context #127

Merged

lash merged 7 commits from api-context into master

2024-10-24 16:45:37 +02:00

carlos commented

2024-10-23 16:28:38 +02:00

Member

Change on passing context.Context to all api call functions

Change on passing context.Context to all api call functions

carlos added 2 commits 2024-10-23 16:28:38 +02:00

run go mod tidy fb32dde136

pass context.Context b41e52af63

lash added 1 commit 2024-10-24 14:51:26 +02:00

Merge branch 'master' into api-context 69eb57f794

lash requested changes 2024-10-24 15:12:34 +02:00

internal/handlers/server/accountservice.go Outdated

						
				@ -34,3 +35,3 @@

				//   - error: An error if any occurred during the HTTP request, reading the response, or unmarshalling the JSON data.

				//     If no error occurs, this will be nil.

				func (as *AccountService) CheckAccountStatus(trackingId string) (*models.TrackStatusResponse, error) {

				func (as *AccountService) CheckAccountStatus(trackingId string, ctx context.Context) (*models.TrackStatusResponse, error) {

lash commented

2024-10-24 15:12:28 +02:00

Owner

I believe context should per convention always be the first argument.

https://tip.golang.org/blog/context-and-structs#conclusion

I believe context should per convention always be the first argument. https://tip.golang.org/blog/context-and-structs#conclusion

carlos added 4 commits 2024-10-24 16:40:03 +02:00

Merge branch 'master' into api-context d678a639b8

update method signatures 383f074cae

ensure mod match with master 6e7b46666e

Merge remote-tracking branch 'refs/remotes/origin/api-context' into api-context bee9ad5ff5

lash merged commit 6b5d3f74d1 into master

2024-10-24 16:45:37 +02:00

lash referenced this issue from a commit

2024-10-24 16:45:38 +02:00

Merge pull request 'api-context' (#127) from api-context into master

Sign in to join this conversation.

No reviewers

No Milestone

No project

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: urdt/ussd#127

No description provided.