urdt/ussd
5
0
Fork 1
Code Issues 41 Pull Requests Actions Packages Projects Releases Wiki Activity

api-context #127

Merged
lash merged 7 commits from api-context into master 2024-10-24 16:45:37 +02:00
Conversation 1 Commits 7 Files Changed 4 +27 -22
carlos commented 2024-10-23 16:28:38 +02:00
Member
Copy Link

Change on passing context.Context to all api call functions

Change on passing context.Context to all api call functions
carlos added 2 commits 2024-10-23 16:28:38 +02:00
run go mod tidy fb32dde136
pass context.Context b41e52af63
lash added 1 commit 2024-10-24 14:51:26 +02:00
Merge branch 'master' into api-context 69eb57f794
lash requested changes 2024-10-24 15:12:34 +02:00
internal/handlers/server/accountservice.go Outdated
@@ -34,3 +35,3 @@
// - error: An error if any occurred during the HTTP request, reading the response, or unmarshalling the JSON data.
// If no error occurs, this will be nil.
func (as *AccountService) CheckAccountStatus(trackingId string) (*models.TrackStatusResponse, error) {
func (as *AccountService) CheckAccountStatus(trackingId string, ctx context.Context) (*models.TrackStatusResponse, error) {
lash commented 2024-10-24 15:12:28 +02:00
Owner
Copy Link

I believe context should per convention always be the first argument.

https://tip.golang.org/blog/context-and-structs#conclusion

I believe context should per convention always be the first argument. https://tip.golang.org/blog/context-and-structs#conclusion
carlos added 4 commits 2024-10-24 16:40:03 +02:00
Merge branch 'master' into api-context d678a639b8
update method signatures 383f074cae
ensure mod match with master 6e7b46666e
Merge remote-tracking branch 'refs/remotes/origin/api-context' into api-context bee9ad5ff5
lash merged commit 6b5d3f74d1 into master 2024-10-24 16:45:37 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Activity
Doing
An item actively being worked on currently
Activity
Hold
Not being actively worked on
Activity
Proposal
A proposal for a new feature or enhancement
Activity
QA
Ready for QA testing
Activity
Validate
Dev team validating changes
Runner
AT
Runner
CLI
Runner
HTTP
Runner
SSH
cleanup
devops
documentation
easypeasy
A task that can be completed with little effort
 exchange
relating to swapping of assets and offramps
 i18n
Languages and translations
 legacy
Legacy features from the old ussd system to be ported
 meta
container for other issues
 migration
optimization
privilege
features that have to do with special, privileged axx
 refactor
smell
Code smell
 support
transparency and help with exception states
 tooling
ux
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk carlos kamikazechaser lash willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: urdt/ussd#127
Delete Branch "api-context"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?