urdt/ussd
5
0
Fork 1
Code Issues 41 Pull Requests Actions Packages Projects Releases Wiki Activity

tests-refactor #137

Merged
lash merged 24 commits from tests-refactor into master 2024-10-28 16:28:42 +01:00
Conversation 1 Commits 24 Files Changed 22 +145 -128
carlos commented 2024-10-25 08:42:15 +02:00
Member
Copy Link

This PR aim is to refactor the menu tests.Structs,mocks and functions returning static data used for testing have been moved to testutil/*

This PR aim is to refactor the menu tests.Structs,mocks and functions returning static data used for testing have been moved to testutil/*
carlos added 22 commits 2024-10-25 08:42:15 +02:00
move driver to testutil 0c08654df3
move account service to testutil 14455f65cb
move account service tags switch to test tags package 3af943f77c
move driver to testutil a904cdbf44
update package import 961d8d1a5c
move test account service to testutil 4a9ef6b5f2
update imports 549d09890b
update imports f3a5178de7
move into testtag package eaac771722
check for back option e05dbb4885
load and reload after halt 306666a15e
Merge branch 'master' into tests-refactor 2725323f16
run mod tidy 1e6cf6a33a
move to testutil f3a028f1fc
move to testutil 651969668f
move to testutil 5692440099
correct import 57a07af8ca
correct import f99486c190
Merge branch 'master' into tests-refactor 2b34b3a75c
update test account service a3be98c514
remove test account service implementation a0e97cfe5b
run mod tidy 3792bfdc1f
carlos added 2 commits 2024-10-25 17:02:16 +02:00
Merge branch 'master' into tests-refactor d8800a665d
update account services 4e1b2d5ddb
lash reviewed 2024-10-25 21:04:32 +02:00
internal/handlers/ussd/menuhandler.go
@@ -32,6 +32,7 @@ var (
translationDir = path.Join(scriptDir, "locale")
okResponse *api.OKResponse
errResponse *api.ErrResponse
backOption = []byte("0")
lash commented 2024-10-25 21:04:21 +02:00
Owner
Copy Link

What is this backoption please?

What is this backoption please?
carlos commented 2024-10-25 21:26:19 +02:00
Author
Member
Copy Link

The backOption is used to check if the input was "0" in the edit profile information context,then we should not consider that a valid profile information entry.

The backOption is used to check if the input was "0" in the edit profile information context,then we should not consider that a valid profile information entry.
Screenshot from 2024-10-25 22-23-20.png
137 KiB
Screenshot from 2024-10-25 22-23-20.png
lash commented 2024-10-25 21:29:49 +02:00
Owner
Copy Link

I understand, but wouldnt the INCMP take care of avoiding that?

I understand, but wouldnt the INCMP take care of avoiding that?
lash merged commit 727f54ee57 into master 2024-10-28 16:28:42 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Activity
Doing
An item actively being worked on currently
Activity
Hold
Not being actively worked on
Activity
Proposal
A proposal for a new feature or enhancement
Activity
QA
Ready for QA testing
Activity
Validate
Dev team validating changes
Runner
AT
Runner
CLI
Runner
HTTP
Runner
SSH
cleanup
devops
documentation
easypeasy
A task that can be completed with little effort
 exchange
relating to swapping of assets and offramps
 i18n
Languages and translations
 legacy
Legacy features from the old ussd system to be ported
 meta
container for other issues
 migration
optimization
privilege
features that have to do with special, privileged axx
 refactor
smell
Code smell
 support
transparency and help with exception states
 tooling
ux
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk carlos kamikazechaser lash willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: urdt/ussd#137
Delete Branch "tests-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?