urdt/ussd
5
0
Fork 1
Code Issues 41 Pull Requests Actions Packages Projects Releases Wiki Activity

minor-bug-fixes #177

Merged
lash merged 26 commits from minor-bug-fixes into master 2024-12-03 18:18:23 +01:00
Conversation 1 Commits 26 Files Changed 25 +121 -46
carlos commented 2024-11-20 14:43:31 +01:00
Member
Copy Link

Fixes discovered minor bugs within the menu

Fixes:
#191
#189
#184

Fixes discovered minor bugs within the menu Fixes: https://git.grassecon.net/urdt/ussd/issues/191 https://git.grassecon.net/urdt/ussd/issues/189 https://git.grassecon.net/urdt/ussd/issues/184
carlos added 2 commits 2024-11-20 14:43:31 +01:00
add swahili translation for catch node 9cf1cbe425
fix size limit error d20700ca74
carlos added 2 commits 2024-11-20 15:14:38 +01:00
explicit set_language reload 451b15fb6b
set eng as default language 7880294c6f
carlos added 2 commits 2024-11-21 09:26:04 +01:00
add function to check validity of provided yob 9b89462797
refactor check for valid yob 8925e26c4c
Alfred-mk added 1 commit 2024-11-21 13:15:35 +01:00
include labels to define the symbol and balance while selecting a voucher 07df450b3c
Alfred-mk added 3 commits 2024-11-21 13:54:10 +01:00
use the correct balance b9ff467c0c
fixed typo and added a new translation e30bc177e9
use the language translation instead of hardcoded eng 7ce50398d1
carlos added 2 commits 2024-11-22 09:37:28 +01:00
use _ for back navigation 9847433e0a
Merge remote-tracking branch 'refs/remotes/origin/minor-bug-fixes' into minor-bug-fixes a17cf78d29
Alfred-mk added 1 commit 2024-11-26 13:32:18 +01:00
Merge branch 'master' into minor-bug-fixes c8c6b05b8a
carlos added 1 commit 2024-11-28 09:43:58 +01:00
show name without depending on family name being set 00c0445eed
Alfred-mk added 1 commit 2024-11-29 12:48:56 +01:00
Format the balance to 2 decimal places c46f41e25f
Alfred-mk added 1 commit 2024-11-29 13:39:42 +01:00
Capitalize menu items aab6660edd
carlos added 1 commit 2024-12-02 07:03:27 +01:00
fix: looped navigation 0091fbcabb
Alfred-mk changed title from WIP: minor-bug-fixes to minor-bug-fixes 2024-12-02 13:25:15 +01:00
Alfred-mk added 1 commit 2024-12-02 13:25:42 +01:00
Merge branch 'master' into minor-bug-fixes 419cd185fc
lash reviewed 2024-12-02 16:23:38 +01:00
internal/handlers/ussd/menuhandler.go Outdated
@@ -1393,3 +1403,1 @@
if firstName == defaultValue {
name = familyName
} else {
if firstName != defaultValue {
lash commented 2024-12-02 16:22:31 +01:00
Owner
Copy Link

Probably nicer in a separate function "constructName"?

Probably nicer in a separate function "constructName"?
Alfred-mk commented 2024-12-03 12:11:02 +01:00
Member
Copy Link

This has been added in ..utils/name.go

This has been added in ..utils/name.go
Alfred-mk marked this conversation as resolved
Alfred-mk added 1 commit 2024-12-03 10:58:33 +01:00
Merge branch 'master' into minor-bug-fixes 13b45c49da
Alfred-mk added 2 commits 2024-12-03 11:32:26 +01:00
updated the CheckAliasAddress mock ff3f049226
resolved error in the TestValidateRecipient e979742424
Alfred-mk added 2 commits 2024-12-03 11:37:07 +01:00
resolved error in the TestCheckBalance 10586baf0d
resolved error in the TestViewVoucher 0f21b01813
Alfred-mk added 1 commit 2024-12-03 12:10:15 +01:00
add a separate function to handle ConstructName ba430a5849
Alfred-mk added 1 commit 2024-12-03 12:13:13 +01:00
formatted code d40a4a171f
lash added 1 commit 2024-12-03 18:16:21 +01:00
Merge branch 'master' into minor-bug-fixes a709d24520
lash merged commit 22c9c3e0f0 into master 2024-12-03 18:18:23 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Activity
Doing
An item actively being worked on currently
Activity
Hold
Not being actively worked on
Activity
Proposal
A proposal for a new feature or enhancement
Activity
QA
Ready for QA testing
Activity
Validate
Dev team validating changes
Runner
AT
Runner
CLI
Runner
HTTP
Runner
SSH
cleanup
devops
documentation
easypeasy
A task that can be completed with little effort
 exchange
relating to swapping of assets and offramps
 i18n
Languages and translations
 legacy
Legacy features from the old ussd system to be ported
 meta
container for other issues
 migration
optimization
privilege
features that have to do with special, privileged axx
 refactor
smell
Code smell
 support
transparency and help with exception states
 tooling
ux
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk carlos kamikazechaser lash willruddick
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: urdt/ussd#177
Delete Branch "minor-bug-fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?