urdt/ussd
5
0
Fork 1
Code Issues 41 Pull Requests Actions Packages Projects Releases Wiki Activity

data-items-cleanup #203

Merged
lash merged 12 commits from data-items-cleanup into master 2024-12-05 16:03:50 +01:00
Conversation 3 Commits 12 Files Changed 8 +89 -66
Alfred-mk commented 2024-12-04 18:56:32 +01:00
Member
Copy Link
- Resolves issue #196 - Resolves issue #198
Alfred-mk added 4 commits 2024-12-04 18:56:33 +01:00
removed DATATYPE_USERSUB and replaced with DATATYPE_USERDATA 4ecfc9de38
Use numeric prefixes 93c44861e0
Merge branch 'master' into data-items-cleanup 82884a75a3
updated failing tests bc0e536d3d
Alfred-mk added 1 commit 2024-12-04 18:59:58 +01:00
renamed internal/storage/db.go -> internal/storage/sub_prefix_db.go for clarity 862830e9de
Alfred-mk requested review from lash 2024-12-04 19:00:47 +01:00
Alfred-mk added 1 commit 2024-12-04 19:07:17 +01:00
return nil with error 7a9de79aae
lash requested changes 2024-12-05 02:13:14 +01:00
Dismissed
common/db.go Outdated
@@ -33,3 +33,3 @@
DATA_ACTIVE_DECIMAL
DATA_ACTIVE_ADDRESS
DATA_TRANSACTIONS
DATA_PREFIX_SYMBOLS
lash commented 2024-12-04 22:13:47 +01:00
Owner
Copy Link

Perhaps better name DATA_VOUCHER_* ?

Perhaps better name `DATA_VOUCHER_*` ?
Alfred-mk marked this conversation as resolved
common/db.go Outdated
@@ -34,2 +34,3 @@
DATA_ACTIVE_ADDRESS
DATA_TRANSACTIONS
DATA_PREFIX_SYMBOLS
DATA_PREFIX_BALANCES
lash commented 2024-12-05 02:12:34 +01:00
Owner
Copy Link

I would start at 256 (0x0100), and keep the DATATYPE_USERDATA prefix.

I would start at 256 (0x0100), and keep the DATATYPE_USERDATA prefix.
Alfred-mk marked this conversation as resolved
common/vouchers_test.go
@@ -86,16 +86,16 @@ func TestGetVoucherData(t *testing.T) {
spdb := storage.NewSubPrefixDb(db, []byte("vouchers"))
lash commented 2024-12-05 02:13:08 +01:00
Owner
Copy Link

The prefix should be DATATYPE_USERDATA

The prefix should be `DATATYPE_USERDATA`
Alfred-mk marked this conversation as resolved
Alfred-mk added 2 commits 2024-12-05 14:31:55 +01:00
updated the name of the voucher related data 18423fcd9c
Start the sub prefix data at 256 (0x0100) f733fe5636
Alfred-mk added 2 commits 2024-12-05 15:02:36 +01:00
Added a function to convert int to []byte a659fb06fa
Use the DATATYPE_USERDATA as the prefix for the NewSubPrefixDb func 589a94216b
Alfred-mk requested review from lash 2024-12-05 15:03:23 +01:00
Alfred-mk changed title from data-items-cleanup to WIP: data-items-cleanup 2024-12-05 15:33:25 +01:00
lash requested changes 2024-12-05 15:46:31 +01:00
Dismissed
common/db.go Outdated
@@ -36,0 +37,4 @@
DATA_VOUCHER_BALANCES
DATA_VOUCHER_DECIMALS
DATA_VOUCHER_ADDRESSES
DATA_PREFIX_TX_SENDERS
lash commented 2024-12-05 15:45:15 +01:00
Owner
Copy Link

Sorry perhaps it wasn't clear. The "PREFIX" part in general is implied and a thus redundant. TX should suffice.

Sorry perhaps it wasn't clear. The "PREFIX" part in general is implied and a thus redundant. TX should suffice.
Alfred-mk commented 2024-12-05 15:59:56 +01:00
Author
Member
Copy Link

Apologies, I was to replace these as well. This has been done

Apologies, I was to replace these as well. This has been done
Alfred-mk marked this conversation as resolved
common/db.go Outdated
@@ -71,1 +83,4 @@
}
// Convert DataTyp to []byte
func (d DataTyp) ToBytes() []byte {
lash commented 2024-12-05 15:46:04 +01:00
Owner
Copy Link

So this should call IntToBytes then ;)

So this should call `IntToBytes` then ;)
Alfred-mk commented 2024-12-05 16:00:43 +01:00
Author
Member
Copy Link

I have set up a single function to handle both the DataTyp and int instead

I have set up a single function to handle both the DataTyp and int instead
Alfred-mk marked this conversation as resolved
Alfred-mk added 2 commits 2024-12-05 15:59:00 +01:00
Replace IntToBytes(value int) and ToBytes() with a single ToBytes() function caff27b43d
Removed redundant naming of transfer related data 14737b5f12
Alfred-mk changed title from WIP: data-items-cleanup to data-items-cleanup 2024-12-05 16:01:50 +01:00
lash approved these changes 2024-12-05 16:03:45 +01:00
lash merged commit 316358765d into master 2024-12-05 16:03:50 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Activity
Doing
An item actively being worked on currently
Activity
Hold
Not being actively worked on
Activity
Proposal
A proposal for a new feature or enhancement
Activity
QA
Ready for QA testing
Activity
Validate
Dev team validating changes
Runner
AT
Runner
CLI
Runner
HTTP
Runner
SSH
cleanup
devops
documentation
easypeasy
A task that can be completed with little effort
 exchange
relating to swapping of assets and offramps
 i18n
Languages and translations
 legacy
Legacy features from the old ussd system to be ported
 meta
container for other issues
 migration
optimization
privilege
features that have to do with special, privileged axx
 refactor
smell
Code smell
 support
transparency and help with exception states
 tooling
ux
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk carlos kamikazechaser lash willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: urdt/ussd#203
Delete Branch "data-items-cleanup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?