urdt/ussd
5
0
Fork 1
Code Issues 69 Pull Requests 5 Actions Packages Projects Releases Wiki Activity

issue-205: added comments for menu handlers methods. #218

Open
konstantinmds wants to merge 1 commits from konstantinmds/ussd:dev/issue-205 into master
pull from: konstantinmds/ussd:dev/issue-205
merge into: urdt:master
Conversation 1 Commits 1 Files Changed 1 +28
konstantinmds commented 2024-12-17 16:36:08 +01:00
First-time contributor
Copy Link

added comments for menu handlers methods.

added comments for menu handlers methods.
konstantinmds added 1 commit 2024-12-17 16:36:08 +01:00 
added comments for menu handlers methods.
lash requested changes 2024-12-18 07:37:48 +01:00
lash left a comment
Owner
Copy Link

Thank you for your first contribution to our code. Please note the comment and make the corresponding change before we can merge.

Thank you for your first contribution to our code. Please note the comment and make the corresponding change before we can merge.
👍 1
internal/handlers/ussd/menuhandler.go Outdated
@ -80,6 +80,7 @@ type Handlers struct {
profile *models.Profile
}
// Creates a new instance of Handlers
lash commented 2024-12-18 07:36:50 +01:00
Owner
Copy Link

In godoc, first word in the description of an exported symbol should be the symbol name, e.g. "NewHandlers creates a ..."

In godoc, first word in the description of an exported symbol should be the symbol name, e.g. "NewHandlers creates a ..."
👍 1
konstantinmds force-pushed dev/issue-205 from 57e6ff86b4 to d946dfc577 2024-12-18 17:03:30 +01:00 Compare
konstantinmds requested review from lash 2024-12-19 09:52:23 +01:00
lash requested changes 2024-12-19 10:01:39 +01:00
lash left a comment
Owner
Copy Link

please let's also add punctuation for all comment sentences.

please let's also add punctuation for all comment sentences.
internal/handlers/ussd/menuhandler.go
@ -231,6 +235,7 @@ func (h *Handlers) CreateAccount(ctx context.Context, sym string, input []byte)
return res, nil
}
// CheckPinMisMatch checks if the provided PIN matches a temporary PIN stored for a blocked number
lash commented 2024-12-19 09:58:36 +01:00
Owner
Copy Link

@carlos is this correct, as it is only for blocked numbers? If so maybe this should be renamed to reflect this.

@carlos is this correct, as it is only for blocked numbers? If so maybe this should be renamed to reflect this.
carlos commented 2024-12-22 06:18:09 +01:00
Member
Copy Link

@lash Yeah that's correct. The CheckPinMisMatch checks the temporary PIN(unconfirmed PIN) when trying to reset a blocked number's PIN.

@lash Yeah that's correct. The `CheckPinMisMatch` checks the temporary PIN(unconfirmed PIN) when trying to reset a blocked number's PIN.
internal/handlers/ussd/menuhandler.go
@ -930,6 +950,7 @@ func (h *Handlers) ResetOthersPin(ctx context.Context, sym string, input []byte)
return res, nil
}
// ResetUnregisteredNumber handles the cleanup of unregistered number flags in the system
lash commented 2024-12-19 10:00:35 +01:00
Owner
Copy Link

Can this be more precise please?

Can this be more precise please?
internal/handlers/ussd/menuhandler.go
@ -1957,6 +1984,7 @@ func (h *Handlers) ViewTransactionStatement(ctx context.Context, sym string, inp
return res, nil
}
// insertProfileItems handles bulk updates of profile information
lash commented 2024-12-19 10:01:18 +01:00
Owner
Copy Link

function name is not needed for unexported symbols.

function name is not needed for unexported symbols.
This pull request has changes conflicting with the target branch.
  • internal/handlers/ussd/menuhandler.go
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u dev/issue-205:konstantinmds-dev/issue-205
git checkout konstantinmds-dev/issue-205
Sign in to join this conversation.
Reviewers
No reviewers
lash
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Activity
Doing
An item actively being worked on currently

  
Activity
Proposal
A proposal for a new feature or enhancement

  
Activity
QA
Ready for QA testing

  
Activity
Validate
Dev team validating changes before sending over to QA

  
Runner
AT

  
Runner
CLI

  
Runner
HTTP

  
Runner
SSH

  
cleanup

   
devops

   
documentation

   
easypeasy

A task that can be completed with little effort

  
exchange

relating to swapping of assets and offramps

  
i18n

Languages and translations

  
l8ter

   
legacy

Legacy features from the old ussd system to be ported

  
meta

container for other issues

  
migration

   
optimization

   
privilege

features that have to do with special, privileged axx

  
refactor

   
smell

Code smell

  
support

transparency and help with exception states

  
tooling

   
ux
No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Activity
Doing
Activity
Proposal
Activity
QA
Activity
Validate
Runner
AT
Runner
CLI
Runner
HTTP
Runner
SSH
cleanup
devops
documentation
easypeasy
exchange
i18n
l8ter
legacy
meta
migration
optimization
privilege
refactor
smell
support
tooling
ux
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: urdt/ussd#218
No description provided.
Delete Branch "konstantinmds/ussd:dev/issue-205"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?