urdt/ussd
5
0
Fork 1
Code Issues 41 Pull Requests Actions Packages Projects Releases Wiki Activity

hash-pin #235

Merged
lash merged 15 commits from hash-pin into master 2025-01-03 09:25:26 +01:00
Conversation 1 Commits 15 Files Changed 4 +248 -76
Alfred-mk commented 2025-01-02 11:54:58 +01:00
Member
Copy Link
- Hash PIN using bcrypt with 8 salt rounds - Resolves issue #209
Alfred-mk added 6 commits 2025-01-02 11:54:58 +01:00
added pin.go to contain all PIN related functionality 48d63fb43f
move PIN test to the common package 5ca6a74274
updated the expected age c899c098f6
add code to Hash and Verify the PIN fd1ac85a1b
return if the PIN is not a match, and hash the PIN before saving it d95c7abea4
verify the PIN input against the hashed PIN 99a4d3ff42
Alfred-mk added 2 commits 2025-01-02 12:38:28 +01:00
hash the PIN in the ResetOthersPin function 98db85511b
hash the PIN in TestAuthorize 82b4365d16
Alfred-mk added 1 commit 2025-01-02 13:16:00 +01:00
updated expected age in test ca8df5989a
Alfred-mk added 1 commit 2025-01-02 13:22:13 +01:00
added tests for HashPIN and VerifyPIN 29ce4b83bd
Alfred-mk changed title from WIP: hash-pin to hash-pin 2025-01-02 13:44:59 +01:00
Alfred-mk added 1 commit 2025-01-02 14:01:27 +01:00
point to the correct ./devtools/admin_numbers directory 491b7424a9
Alfred-mk requested review from lash 2025-01-02 14:01:54 +01:00
lash requested changes 2025-01-02 15:35:03 +01:00
common/pin_test.go Outdated
@@ -0,0 +99,4 @@
}
}
func TestVerifyPIN(t *testing.T) {
lash commented 2025-01-02 15:34:59 +01:00
Owner
Copy Link

We are going to need a test using data from the legacy system aswell. Please @kamikazechaser can you provide an existing plain/cipher pair?

We are going to need a test using data from the legacy system aswell. Please @kamikazechaser can you provide an existing plain/cipher pair?
kamikazechaser marked this conversation as resolved
internal/handlers/handlerservice.go Outdated
@@ -44,3 +44,3 @@
return nil, err
}
adminstore, err := utils.NewAdminStore(ctx, "admin_numbers")
adminstore, err := utils.NewAdminStore(ctx, "./devtools/admin_numbers")
lash commented 2025-01-02 15:27:46 +01:00
Owner
Copy Link

it seems strange that handler service should be pointing to an executable directory. can we put it in the store instead somehow?

it seems strange that handler service should be pointing to an executable directory. can we put it in the store instead somehow?
Alfred-mk marked this conversation as resolved
Alfred-mk added 1 commit 2025-01-03 04:58:54 +01:00
Merge branch 'master' into hash-pin 0fe48a30fa
kamikazechaser added 1 commit 2025-01-03 09:10:19 +01:00
tests: add sample pin/hash pair from migration dataset 91dc9ce82f
Alfred-mk added 1 commit 2025-01-03 09:17:33 +01:00
removed second unused argument c26f5683f6
Alfred-mk added 1 commit 2025-01-03 09:24:31 +01:00
revert to previous state for the adminstore 9d6e25e184
lash merged commit 8bd025f2b2 into master 2025-01-03 09:25:26 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Activity
Doing
An item actively being worked on currently
Activity
Hold
Not being actively worked on
Activity
Proposal
A proposal for a new feature or enhancement
Activity
QA
Ready for QA testing
Activity
Validate
Dev team validating changes
Runner
AT
Runner
CLI
Runner
HTTP
Runner
SSH
cleanup
devops
documentation
easypeasy
A task that can be completed with little effort
 exchange
relating to swapping of assets and offramps
 i18n
Languages and translations
 legacy
Legacy features from the old ussd system to be ported
 meta
container for other issues
 migration
optimization
privilege
features that have to do with special, privileged axx
 refactor
smell
Code smell
 support
transparency and help with exception states
 tooling
ux
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk carlos kamikazechaser lash willruddick
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: urdt/ussd#235
Delete Branch "hash-pin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?