log-session-id-at-sessionid #251

carlos · 2025-01-06T06:55:45+01:00

carlos commented

2025-01-06 06:55:45 +01:00

Makes session id(phone number ) and africastalking session id available in the logs.

Resolves:

#240

Makes session id(phone number ) and africastalking session id available in the logs. Resolves: #240

carlos added 2 commits 2025-01-06 06:55:45 +01:00

pass context as an argument 974af6b2a7

pass context as an argument,rename context keys c69d3896f1

lash requested changes 2025-01-06 07:46:34 +01:00

Dismissed

lash left a comment

I thought we were going to make a logging wrapper as a separate package?

e.g. something like (not tested):

package logging

type ContextLogger logging.Logger

func NewContextLogger(domain string) logging.Logger{
   var logg ContextLogger 
   logg = logging.NewVanilla().WithDomain(domain).WithContextKey("SessionId").WithContextKey("ATSessionId")
   return logg
}

I thought we were going to make a logging wrapper as a separate package? e.g. something like (not tested): ``` package logging type ContextLogger logging.Logger func NewContextLogger(domain string) logging.Logger{ var logg ContextLogger logg = logging.NewVanilla().WithDomain(domain).WithContextKey("SessionId").WithContextKey("ATSessionId") return logg } ```

internal/http/at/server.go Outdated

						
				@ -11,3 +11,3 @@

				var (

					logg = logging.NewVanilla().WithDomain("atserver")

					logg = logging.NewVanilla().WithDomain("atserver").WithContextKey("AT-SessionId")

lash commented

2025-01-06 07:43:46 +01:00

We will need both SessionId and AT-Sessionid in the AT part, otherwise SessionId will not be logged.

lash commented

2025-01-06 07:50:54 +01:00

let's push logging instance to later, put in issue: #252

so let's just make sure we have sessionid everywhere.

let's push logging instance to later, put in issue: https://git.grassecon.net/urdt/ussd/issues/252 so let's just make sure we have sessionid everywhere.

carlos added 1 commit 2025-01-06 07:54:57 +01:00

add SessionId to context key 362eb209ef

lash requested changes 2025-01-06 07:56:21 +01:00

Dismissed

internal/http/server.go Outdated

						
				@ -11,3 +11,3 @@

				var (

					logg = logging.NewVanilla().WithDomain("httpserver")

					logg = logging.NewVanilla().WithDomain("httpserver").WithContextKey("at-session-id")