urdt/ussd
5
0
Fork 1
Code Issues 41 Pull Requests Actions Packages Projects Releases Wiki Activity

account-pin-block-v2 #256

Merged
lash merged 22 commits from account-pin-block-v2 into master 2025-01-08 13:30:39 +01:00
Conversation 2 Commits 22 Files Changed 13 +224 -23
carlos commented 2025-01-06 20:59:07 +01:00
Member
Copy Link

Feature:

Blocks an account when the number of incorrect PIN attempts has exceeded the allowed attempts(3)

Resolves:

#18

Feature: Blocks an account when the number of incorrect PIN attempts has exceeded the allowed attempts(3) Resolves: #18
carlos added 4 commits 2025-01-06 20:59:08 +01:00
add key for incorrect pin attempts 68e4c9af03
add flag for when an account has been blocked b37f2a0a11
add value for allowed number of PIN attempts 90df0eefc3
check for incorrect pin 562bd4fa24
carlos added 2 commits 2025-01-07 08:52:13 +01:00
add node to show remaining pin attempts f83f539046
map content of reset_incorrect and catch blocked account 11d30583a4
carlos added 2 commits 2025-01-07 12:33:08 +01:00
add blocked account node ee442daefa
reset incorrect pin attempts on correct entry c15958a1ad
carlos added 1 commit 2025-01-07 12:38:59 +01:00
catch blocked account 64fba91670
carlos added 5 commits 2025-01-08 07:31:13 +01:00
remove blocked account templates 07b061a68b
register handler to show blocked account message 50c7ff1046
add a message for a blocked account 3004698d5b
show message for a blocked account 4fe64a7747
add handler showing a message for a blocked account 4d72ae0313
carlos added 2 commits 2025-01-08 09:48:44 +01:00
update tests 7f3294a8a2
update tests 8d477356f3
carlos added 1 commit 2025-01-08 10:00:48 +01:00
Merge branch 'master' into account-pin-block-v2 c359d99075
carlos changed title from WIP: account-pin-block-v2 to account-pin-block-v2 2025-01-08 10:04:44 +01:00
carlos requested review from lash 2025-01-08 10:04:55 +01:00
lash requested changes 2025-01-08 12:17:52 +01:00
internal/handlers/ussd/menuhandler.go Outdated
@@ -740,2 +747,4 @@
}
}
} else {
err := h.countIncorrectPINAttempts(ctx, sessionId)
lash commented 2025-01-08 11:56:18 +01:00
Owner
Copy Link

perhaps incrementnot count ?

perhaps `increment`not `count` ?
👍 1
internal/handlers/ussd/menuhandler.go Outdated
@@ -843,0 +884,4 @@
code := codeFromCtx(ctx)
l := gotext.NewLocale(translationDir, code)
l.AddDomain("default")
res.Content = l.Get("Your account has been locked.For help on how to unblock your account,contact support at: 0757628885")
lash commented 2025-01-08 11:58:25 +01:00
Owner
Copy Link

Space after punctuation

Space after punctuation
menutraversal_test/group_test.json Outdated
@@ -55,3 +55,3 @@
{
"input": "1235",
"expectedContent": "Incorrect PIN\n1:Retry\n9:Quit"
"expectedContent": "Incorrect PIN.You have: 2 remaining attempt(s).\n1:Retry\n9:Quit"
lash commented 2025-01-08 12:15:52 +01:00
Owner
Copy Link

Space after punctuation

Space after punctuation
carlos added 4 commits 2025-01-08 12:55:46 +01:00
chore : add variable description to AllowedPINAttempts ed6651697a
chore : rename remainingPINAttempts to currentWrongPinAttemptsCount 477b4cf8f6
chore: rename countIncorrectPINAttempts to incrementIncorrectPINAttempts 2ff9fed3c5
chore: add space after punctuation efdb52bccd
lash requested changes 2025-01-08 13:02:46 +01:00
services/registration/locale/swa/default.po Outdated
@@ -10,6 +10,9 @@ msgstr "Asante kwa kutumia huduma ya Sarafu. Kwaheri!"
msgid "For more help, please call: 0757628885"
msgstr "Kwa usaidizi zaidi, piga: 0757628885"
msgid "Your account has been locked.For help on how to unblock your account, contact support at: 0757628885"
lash commented 2025-01-08 13:02:42 +01:00
Owner
Copy Link

Punctuation still.

Punctuation still.
carlos added 1 commit 2025-01-08 13:27:55 +01:00
chore: add space after punctuation b698f08136
lash merged commit f40e11c267 into master 2025-01-08 13:30:39 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Activity
Doing
An item actively being worked on currently
Activity
Hold
Not being actively worked on
Activity
Proposal
A proposal for a new feature or enhancement
Activity
QA
Ready for QA testing
Activity
Validate
Dev team validating changes
Runner
AT
Runner
CLI
Runner
HTTP
Runner
SSH
cleanup
devops
documentation
easypeasy
A task that can be completed with little effort
 exchange
relating to swapping of assets and offramps
 i18n
Languages and translations
 legacy
Legacy features from the old ussd system to be ported
 meta
container for other issues
 migration
optimization
privilege
features that have to do with special, privileged axx
 refactor
smell
Code smell
 support
transparency and help with exception states
 tooling
ux
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk carlos kamikazechaser lash willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: urdt/ussd#256
Delete Branch "account-pin-block-v2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?