urdt/ussd
5
0
Fork 1
Code Issues 62 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

account-pin-block-v2 #256

Merged
lash merged 22 commits from account-pin-block-v2 into master 2025-01-08 13:30:39 +01:00
Conversation 0 Commits 22 Files Changed 13 +5 -5
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2ff9fed3c5 - Show all commits

8
internal/handlers/ussd/menuhandler.go
View File

@ -747,7 +747,7 @@ func (h *Handlers) Authorize(ctx context.Context, sym string, input []byte) (res
} }
} }
} else { } else {
err := h.countIncorrectPINAttempts(ctx, sessionId) err := h.incrementIncorrectPINAttempts(ctx, sessionId)
lash commented 2025-01-08 11:56:18 +01:00
Outdated
Review
Copy Link

perhaps incrementnot count ?

perhaps `increment`not `count` ?
👍 1
if err != nil { if err != nil {
return res, err return res, err
} }
@ -884,7 +884,7 @@ func (h *Handlers) ShowBlockedAccount(ctx context.Context, sym string, input []b
code := codeFromCtx(ctx) code := codeFromCtx(ctx)
l := gotext.NewLocale(translationDir, code) l := gotext.NewLocale(translationDir, code)
l.AddDomain("default") l.AddDomain("default")
res.Content = l.Get("Your account has been locked.For help on how to unblock your account,contact support at: 0757628885") res.Content = l.Get("Your account has been locked.For help on how to unblock your account, contact support at: 0757628885")
lash commented 2025-01-08 11:58:25 +01:00
Outdated
Review
Copy Link

Space after punctuation

Space after punctuation
return res, nil return res, nil
} }
@ -2124,8 +2124,8 @@ func (h *Handlers) UpdateAllProfileItems(ctx context.Context, sym string, input
return res, nil return res, nil
} }
// countIncorrectPINAttempts keeps track of the number of incorrect PIN attempts // incrementIncorrectPINAttempts keeps track of the number of incorrect PIN attempts
func (h *Handlers) countIncorrectPINAttempts(ctx context.Context, sessionId string) error { func (h *Handlers) incrementIncorrectPINAttempts(ctx context.Context, sessionId string) error {
var pinAttemptsCount uint8 var pinAttemptsCount uint8
store := h.userdataStore store := h.userdataStore

2
internal/handlers/ussd/menuhandler_test.go
View File

@ -2247,7 +2247,7 @@ func TestCountIncorrectPINAttempts(t *testing.T) {
if err != nil { if err != nil {
t.Logf(err.Error()) t.Logf(err.Error())
} }
err = h.countIncorrectPINAttempts(ctx, sessionId) err = h.incrementIncorrectPINAttempts(ctx, sessionId)
if err != nil { if err != nil {
t.Logf(err.Error()) t.Logf(err.Error())
} }