wip-code-check #44

						
				@@ -35,0 +118,4 @@

					var debug bool

					flag.StringVar(&sessionId, "session-id", "075xx2123", "session id")

					flag.StringVar(&dbDir, "dbdir", ".state", "database dir to read from")

					flag.StringVar(&resourceDir, "resourcedir", path.Join("services", "registration"), "resource dir")

lash commented

2024-09-10 01:44:07 +02:00

do we need this parameter?

lash marked this conversation as resolved

internal/utils/account_utils.go Outdated

						
				@@ -35,3 +37,3 @@

					}

					return os.WriteFile(afh.FilePath, jsonData, 0644)

					return nil

lash commented

2024-09-10 02:28:02 +02:00

WriteEntry is missing here?

`WriteEntry` is missing here?

internal/utils/account_utils.go Outdated

						
				@@ -38,3 +39,4 @@

					return nil

				}

				func (afh *AccountFileHandler) EnsureFileExists() error {

lash commented

2024-09-10 02:30:20 +02:00

can be removed

internal/utils/userStore.go Outdated

						
				@@ -0,0 +7,4 @@

					"git.defalsify.org/vise.git/lang"

				)

				type DataStore interface {

lash commented

2024-09-10 03:05:02 +02:00

This does not need to be so verbose, inherit interface (and implementer) instead. Consider:

package main

import (
        "fmt"
)

type A interface {
        Foo() int
}

type B interface {
        A
        Bar() string
}

type a struct {
}

func(ao *a) Foo() int {
        return 42
}


type b struct {
        A
}

func(bo *b) Bar() string {
        return "13"
}

func main() {
        var o B
        o = &b{
                A: &a{},
        }
        fmt.Printf("%d %s", o.Foo(), o.Bar())
}

This does not need to be so verbose, inherit interface (and implementer) instead. Consider: ``` package main import ( "fmt" ) type A interface { Foo() int } type B interface { A Bar() string } type a struct { } func(ao *a) Foo() int { return 42 } type b struct { A } func(bo *b) Bar() string { return "13" } func main() { var o B o = &b{ A: &a{}, } fmt.Printf("%d %s", o.Foo(), o.Bar()) } ```

lash marked this conversation as resolved

carlos added 3 commits 2024-09-10 10:24:31 +02:00

match code refactor a3dffdf4e9

delete deprecated code c0a3ad7e2b

remove deprecated code ad48890a9f

carlos added 1 commit 2024-09-10 14:15:08 +02:00

remove resource directory 9f034967b5

lash approved these changes 2024-09-10 14:25:19 +02:00

lash merged commit 63cee42261 into master

2024-09-10 14:25:50 +02:00

lash referenced this issue from a commit

2024-09-10 14:25:52 +02:00