urdt/ussd
5
0
Fork 0
Code Issues 34 Pull Requests Actions Packages Projects Releases Wiki Activity

wip-code-check #44

Merged
lash merged 54 commits from wip-code-check into master 2024-09-10 14:25:50 +02:00
Conversation 0 Commits 54 Files Changed 15 +995 -1379
carlos commented 2024-09-09 08:48:03 +02:00
Member
Copy Link

This PR includes changes that adapt the USSD to go-vise:dev-0.1.0

This PR includes changes that adapt the USSD to go-vise:dev-0.1.0
carlos added 42 commits 2024-09-09 08:48:03 +02:00
carlos added 1 commit 2024-09-09 08:57:18 +02:00
carlos added 1 commit 2024-09-09 09:12:44 +02:00
carlos added 5 commits 2024-09-09 16:18:25 +02:00
carlos added 1 commit 2024-09-09 16:25:01 +02:00
lash requested changes 2024-09-10 03:05:30 +02:00
Dismissed
cmd/main.go
@ -35,0 +118,4 @@
var debug bool
flag.StringVar(&sessionId, "session-id", "075xx2123", "session id")
flag.StringVar(&dbDir, "dbdir", ".state", "database dir to read from")
flag.StringVar(&resourceDir, "resourcedir", path.Join("services", "registration"), "resource dir")
lash commented 2024-09-10 01:44:07 +02:00
Owner
Copy Link

do we need this parameter?

do we need this parameter?
lash marked this conversation as resolved
internal/utils/account_utils.go Outdated
@ -35,3 +37,3 @@
}
return os.WriteFile(afh.FilePath, jsonData, 0644)
return nil
lash commented 2024-09-10 02:28:02 +02:00
Owner
Copy Link

WriteEntry is missing here?

`WriteEntry` is missing here?
internal/utils/account_utils.go Outdated
@ -38,3 +39,4 @@
return nil
}
func (afh *AccountFileHandler) EnsureFileExists() error {
lash commented 2024-09-10 02:30:20 +02:00
Owner
Copy Link

can be removed

can be removed
internal/utils/userStore.go Outdated
@ -0,0 +7,4 @@
"git.defalsify.org/vise.git/lang"
)
type DataStore interface {
lash commented 2024-09-10 03:05:02 +02:00
Owner
Copy Link

This does not need to be so verbose, inherit interface (and implementer) instead. Consider:

package main

import (
        "fmt"
)

type A interface {
        Foo() int
}

type B interface {
        A
        Bar() string
}

type a struct {
}

func(ao *a) Foo() int {
        return 42
}


type b struct {
        A
}

func(bo *b) Bar() string {
        return "13"
}

func main() {
        var o B
        o = &b{
                A: &a{},
        }
        fmt.Printf("%d %s", o.Foo(), o.Bar())
}
This does not need to be so verbose, inherit interface (and implementer) instead. Consider: ``` package main import ( "fmt" ) type A interface { Foo() int } type B interface { A Bar() string } type a struct { } func(ao *a) Foo() int { return 42 } type b struct { A } func(bo *b) Bar() string { return "13" } func main() { var o B o = &b{ A: &a{}, } fmt.Printf("%d %s", o.Foo(), o.Bar()) } ```
lash marked this conversation as resolved
carlos added 3 commits 2024-09-10 10:24:31 +02:00
carlos added 1 commit 2024-09-10 14:15:08 +02:00
lash approved these changes 2024-09-10 14:25:19 +02:00
lash merged commit 63cee42261 into master 2024-09-10 14:25:50 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
lash
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Runner
AT

  
Runner
CLI

  
Runner
HTTP

  
cleanup

   
easy

A task that can be completed with little effort

  
exchange

relating to swapping of assets and offramps

  
optimization

   
privilege

features that have to do with special, privileged axx

  
refactor

   
smell

Code smell

  
support

transparency and help with exception states

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Runner
AT
Runner
CLI
Runner
HTTP
cleanup
easy
exchange
optimization
privilege
refactor
smell
support
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: urdt/ussd#44
No description provided.
Delete Branch "wip-code-check"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?