wip-code-check #46
 Closed
		
		
			
				
				
					
				
				
				
				
					
				
				
					
						
							carlos
							wants to merge 18 commits from 
							
						
						
							
								
									
									
								
								
									
										
										
										
											
							
						
					
				
			
		
	wip-code-check  into master
						
					
					
						
								pull from: wip-code-check
							
						
								merge into: urdt:master
								
							
							urdt:master
										
									
										
										
										
											urdt:phone-ussd
										
									
										
										
										
											urdt:lash/stalecache
										
									
										
										
										
											urdt:lash/purify-max
										
									
										
										
										
											urdt:postgres-switch-for-tests
										
									
										
										
										
											urdt:copy-language-code
										
									
										
										
										
											urdt:lash/purify-more
										
									
										
										
										
											urdt:account-pin-block-v2
										
									
										
										
										
											urdt:lash/helpcomma
										
									
										
										
										
											urdt:send-input-fix
										
									
										
										
										
											urdt:lash/gettext
										
									
										
										
										
											urdt:lash/dump-format
										
									
										
										
										
											urdt:account-pin-block
										
									
										
										
										
											urdt:lash/ssh-fixes
										
									
										
										
										
											urdt:lash/ssh-4
										
									
										
										
										
											urdt:log-session-id-at-sessionid
										
									
										
										
										
											urdt:lash/purify
										
									
										
										
										
											urdt:logs-at-sessionid
										
									
										
										
										
											urdt:language-change-fix
										
									
										
										
										
											urdt:hash-pin
										
									
										
										
										
											urdt:menu-primary-selectors
										
									
										
										
										
											urdt:lash/dump-key-prefix
										
									
										
										
										
											urdt:force-restart-state
										
									
										
										
										
											urdt:restart-state-devtool
										
									
										
										
										
											urdt:mixed-languages
										
									
										
										
										
											urdt:add-space-after-colon
										
									
										
										
										
											urdt:link-terms-and-conditions
										
									
										
										
										
											urdt:lash/store-dumper
										
									
										
										
										
											urdt:back-state-check
										
									
										
										
										
											urdt:double-session-id
										
									
										
										
										
											urdt:profile-edit-traverse
										
									
										
										
										
											urdt:data-items-cleanup
										
									
										
										
										
											urdt:minor-bug-fixes
										
									
										
										
										
											urdt:lash/persister-freakout
										
									
										
										
										
											urdt:trigger-balance-reload
										
									
										
										
										
											urdt:lash/no-persister-deadlock
										
									
										
										
										
											urdt:voucher-details
										
									
										
										
										
											urdt:single-error-node
										
									
										
										
										
											urdt:sohail/trace-build-29-11
										
									
										
										
										
											urdt:alias-address-validation
										
									
										
										
										
											urdt:sohail/upgrade-deps
										
									
										
										
										
											urdt:account-statement
										
									
										
										
										
											urdt:sohail/docker-build
										
									
										
										
										
											urdt:menu-balances
										
									
										
										
										
											urdt:send-node
										
									
										
										
										
											urdt:profile-edit-show
										
									
										
										
										
											urdt:terminal-logs
										
									
										
										
										
											urdt:readme-documentation
										
									
										
										
										
											urdt:africastalking-endpoint
										
									
										
										
										
											urdt:http-logs
										
									
										
										
										
											urdt:log-file
										
									
										
										
										
											urdt:swahili-templates-menu
										
									
										
										
										
											urdt:api-error-fix
										
									
										
										
										
											urdt:lash/export-to-term
										
									
										
										
										
											urdt:pre-mock-remove
										
									
										
										
										
											urdt:remove-db-mocks
										
									
										
										
										
											urdt:pin-reset
										
									
										
										
										
											urdt:tests-refactor
										
									
										
										
										
											urdt:consolidate-temp-data-storage
										
									
										
										
										
											urdt:profile-update-pin-check
										
									
										
										
										
											urdt:voucher-data
										
									
										
										
										
											urdt:lash/reverse-session
										
									
										
										
										
											urdt:address-sessionId
										
									
										
										
										
											urdt:menu-voucherlist
										
									
										
										
										
											urdt:api-context
										
									
										
										
										
											urdt:api-structs
										
									
										
										
										
											urdt:send-menu-update
										
									
										
										
										
											urdt:check-balance-update
										
									
										
										
										
											urdt:postgres-switch
										
									
										
										
										
											urdt:menu-api-errors
										
									
										
										
										
											urdt:menu-traversal-v2
										
									
										
										
										
											urdt:psql-switch
										
									
										
										
										
											urdt:menu-traversal-refactor
										
									
										
										
										
											urdt:menu-traversals
										
									
										
										
										
											urdt:lash/subprefix
										
									
										
										
										
											urdt:tests-update
										
									
										
										
										
											urdt:menu-profile-edit
										
									
										
										
										
											urdt:fix-repeated-nodes
										
									
										
										
										
											urdt:wip-menu-select-fix
										
									
										
										
										
											urdt:lash/ssh
										
									
										
										
										
											urdt:go-vise-0.2.0
										
									
										
										
										
											urdt:wip-main-refactor
										
									
										
										
										
											urdt:at-return-output
										
									
										
										
										
											urdt:wip-unit-tests
										
									
										
										
										
											urdt:wip-pin-guard
										
									
										
										
										
											urdt:change-language
										
									
										
										
										
											urdt:wip-menu-help
										
									
										
										
										
											urdt:wip-pin-reset
										
									
										
										
										
											urdt:lash/vise-make-var
										
									
										
										
										
											urdt:lash/async-driver
										
									
										
										
										
											urdt:menu-options
										
									
										
										
										
											urdt:unit-tests
										
									
										
										
										
									
										
										
										
											urdt:lash/draft-dev-0.1.0
										
									
										
										
										
											urdt:wip-go-vise-dev-0.1.0
										
									
										
										
										
											urdt:wip-flag-migration
										
									
								
			No reviewers
			
				
				
			
		
		
		
	
	
	
		Labels
		
	
	
		
			
				
				
			
		
		Clear labels
		
			
			
				
				
				
				  
Breaking change that won't be backward compatible
Something is not working
Documentation changes
Improve existing functionality
New functionality
This is security issue
Issue or pull request related to testing
The priority is critical
The priority is high
The priority is low
The priority is medium
Issue has been confirmed
This issue or pull request already exists
Invalid issue
This issue won't be fixed
Somebody has started to work on this but abandoned work
Something is blocking this issue or pull request
Feedback is required to reproduce issue or to continue work
An item actively being worked on currently
Not being actively worked on
A proposal for a new feature or enhancement
Ready for QA testing
Dev team validating changes
A task that can be completed with little effort
relating to swapping of assets and offramps
Languages and translations
Legacy features from the old ussd system to be ported
container for other issues
features that have to do with special, privileged axx
Code smell
transparency and help with exception states
	Compat/Breaking
					Breaking change that won't be backward compatible
Kind/Bug
					Something is not working
Kind/Documentation
					Documentation changes
Kind/Enhancement
					Improve existing functionality
Kind/Feature
					New functionality
Kind/Security
					This is security issue
Kind/Testing
					Issue or pull request related to testing
Priority
Critical
					The priority is critical
Priority
High
					The priority is high
Priority
Low
					The priority is low
Priority
Medium
					The priority is medium
Reviewed
Confirmed
					Issue has been confirmed
Reviewed
Duplicate
					This issue or pull request already exists
Reviewed
Invalid
					Invalid issue
Reviewed
Won't Fix
					This issue won't be fixed
Status
Abandoned
					Somebody has started to work on this but abandoned work
Status
Blocked
					Something is blocking this issue or pull request
Status
Need More Info
					Feedback is required to reproduce issue or to continue work
Activity
Doing
					An item actively being worked on currently
Activity
Hold
					Not being actively worked on
Activity
Proposal
					A proposal for a new feature or enhancement
Activity
QA
					Ready for QA testing
Activity
Validate
					Dev team validating changes
Runner
AT
					
					
Runner
CLI
					
					
Runner
HTTP
					
					
Runner
SSH
					
					
cleanup
					
					
devops
					
					
documentation
					
					
easypeasy
					A task that can be completed with little effort
exchange
					relating to swapping of assets and offramps
i18n
					Languages and translations
legacy
					Legacy features from the old ussd system to be ported
meta
					container for other issues
migration
					
					
optimization
					
					
privilege
					features that have to do with special, privileged axx
refactor
					
					
smell
					Code smell
support
					transparency and help with exception states
tooling
					
					
ux
					
					
	
		No Label
		
			
	
	Compat/Breaking
		
			Kind/Bug
		
			Kind/Documentation
		
			Kind/Enhancement
		
			Kind/Feature
		
			Kind/Security
		
			Kind/Testing
		
			Priority
Critical
		
			Priority
High
		
			Priority
Low
		
			Priority
Medium
		
			Reviewed
Confirmed
		
			Reviewed
Duplicate
		
			Reviewed
Invalid
		
			Reviewed
Won't Fix
		
			Status
Abandoned
		
			Status
Blocked
		
			Status
Need More Info
		
		
			Activity
Doing
		
			Activity
Hold
		
			Activity
Proposal
		
			Activity
QA
		
			Activity
Validate
		
			Runner
AT
		
			Runner
CLI
		
			Runner
HTTP
		
			Runner
SSH
		
			cleanup
		
			devops
		
			documentation
		
			easypeasy
		
			exchange
		
			i18n
		
			legacy
		
			meta
		
			migration
		
			optimization
		
			privilege
		
			refactor
		
			smell
		
			support
		
			tooling
		
			ux
		
	
		
			Milestone
			
		
		
			
	
	Clear milestone
	
		No items
	
		
		No Milestone
		
			
		
	
	
		
		
			
				Projects
				
			
			
				
				
		
		Clear projects
				
				
			
			No project
			
				
			
		
	
	
	
	
		
			Assignees
			
		
		
			
				
				
			
			
	
	Clear assignees
			
		
		No Assignees
		
			
		
	
	
	
		2 Participants
		
	
	
		
		
			Notifications
			
				
			
		
	
	
		
		
	
	
	Due Date
	
			
			The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
		
		
			No due date set.
			
				Dependencies
				
				
		
	
	
	No dependencies set.
			Reference: urdt/ussd#46
			
		
	
		Reference in New Issue
	
	Block a user
	Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
		
	
	No description provided.
		
		Delete Branch "wip-code-check"
	
	Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR aims at introducing unit tests for the menuhandlers. For tests involving api calls to the custodial system(server package) you can toggle between offline and online by using build tags.You need to run an online test first to "record" the first api calls: For that run :
obsoleted by #59
Pull request closed