urdt/ussd
5
0
Fork 0
Code Issues 50 Pull Requests 7 Actions Packages Projects Releases Wiki Activity

menu-options #51

Closed
carlos wants to merge 33 commits from menu-options into master
pull from: menu-options
merge into: urdt:master
Conversation 0 Commits 33 Files Changed 25 +148 -512
carlos commented 2024-09-13 17:17:47 +02:00
Member
Copy Link

This PR implements remaining menu options

This PR implements remaining menu options
carlos added 24 commits 2024-09-13 17:17:48 +02:00
carlos added 4 commits 2024-09-13 20:52:31 +02:00
carlos added 1 commit 2024-09-13 20:55:58 +02:00
lash requested changes 2024-09-14 01:37:39 +02:00
lash left a comment
Owner
Copy Link

Help menu does not work as expected here:

$ go run -v cmd/main.go -session-id foobar -dbdir .test
Balance: 0.003 CELO

1:Send
2:My Vouchers
3:My Account
4:Help
9:quit
4
Thank you for using Sarafu. Goodbye!

Same with change pin:

$ go run -v cmd/main.go -session-id foobar -dbdir .test
Balance: 0.003 CELO

1:Send
2:My Vouchers
3:My Account
4:Help
9:quit
3
My Account
1:Profile

2:Change language
3:Check balances
4:Check statement

5:PIN options
6:My Address
0:Back
5
PIN Management

1:Change PIN

2:Reset other's PIN
3:Guard my PIN

0:Back
1
loop exited with error: unexpected termination: key not found: 5f6361746368

exit status 1
Help menu does not work as expected here: --- ``` $ go run -v cmd/main.go -session-id foobar -dbdir .test Balance: 0.003 CELO 1:Send 2:My Vouchers 3:My Account 4:Help 9:quit 4 Thank you for using Sarafu. Goodbye! ``` --- Same with change pin: --- ``` $ go run -v cmd/main.go -session-id foobar -dbdir .test Balance: 0.003 CELO 1:Send 2:My Vouchers 3:My Account 4:Help 9:quit 3 My Account 1:Profile 2:Change language 3:Check balances 4:Check statement 5:PIN options 6:My Address 0:Back 5 PIN Management 1:Change PIN 2:Reset other's PIN 3:Guard my PIN 0:Back 1 loop exited with error: unexpected termination: key not found: 5f6361746368 exit status 1 ```
internal/handlers/ussd/menuhandler.go
@ -492,3 +534,1 @@
res.FlagSet = append(res.FlagSet, flag_allow_update)
res.FlagReset = append(res.FlagReset, flag_account_authorized)
}
if len(input) == 4 {
lash commented 2024-09-14 01:21:41 +02:00
Owner
Copy Link

can you please put the pin length in a global variable and replace all similar occurrences and check with that?

can you please put the pin length in a global variable and replace all similar occurrences and check with that?
carlos marked this conversation as resolved
internal/handlers/ussd/menuhandler.go
@ -572,0 +625,4 @@
l := gotext.NewLocale(translationDir, code)
l.AddDomain("default")
res.Content = l.Get("For more help,please call: 0757628885")
lash commented 2024-09-14 01:24:09 +02:00
Owner
Copy Link

This should be a config variable. Let's put it as a global variable for now.

You are sure this cannot be solved with a template?

This should be a config variable. Let's put it as a global variable for now. You are sure this cannot be solved with a template?
internal/handlers/ussd/menuhandler_test.go Outdated
@ -321,0 +1001,4 @@
}
}
func TestVerifyPin(t *testing.T) {
lash commented 2024-09-14 01:35:35 +02:00
Owner
Copy Link

this test does not pass

https://g33k.holbrook.no/e675e48bdd347c120aa37d85250b6c419b17ec38c5940e0907362eef3d4ffda9

this test does not pass https://g33k.holbrook.no/e675e48bdd347c120aa37d85250b6c419b17ec38c5940e0907362eef3d4ffda9
carlos added 1 commit 2024-09-14 06:47:01 +02:00
carlos added 1 commit 2024-09-14 06:48:34 +02:00
carlos added 1 commit 2024-09-14 09:47:13 +02:00
carlos added 1 commit 2024-09-14 12:15:36 +02:00
carlos closed this pull request 2024-09-14 19:53:04 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
lash
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Activity:Doing

An item actively being worked on currently

  
Activity:Proposal

A proposal for a new feature or enhancement

  
Runner
AT

  
Runner
CLI

  
Runner
HTTP

  
cleanup

   
devops

   
easypeasy

A task that can be completed with little effort

  
exchange

relating to swapping of assets and offramps

  
l8ter

   
legacy

Legacy features from the old ussd system to be ported

  
optimization

   
privilege

features that have to do with special, privileged axx

  
refactor

   
smell

Code smell

  
support

transparency and help with exception states

  
tooling

   
ux
No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Activity:Doing
Activity:Proposal
Runner
AT
Runner
CLI
Runner
HTTP
cleanup
devops
easypeasy
exchange
l8ter
legacy
optimization
privilege
refactor
smell
support
tooling
ux
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: urdt/ussd#51
No description provided.
Delete Branch "menu-options"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?