urdt/ussd
5
0
Fork 0
Code Issues 33 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

WIP: at-return-output #63

Draft
Alfred-mk wants to merge 3 commits from at-return-output into master
pull from: at-return-output
merge into: urdt:master
Conversation 0 Commits 3 Files Changed 2 +6 -12
Alfred-mk commented 2024-09-18 14:32:58 +02:00
Member
Copy Link

Updated the code to only show output if the http response code is 200

From the AT documentation:

If we get a HTTP error response (Code 40X) from your script, or a malformed response (does not begin with CON or END), we will terminate the USSD session gracefully.

Based on this, I see it best to return an error response instead of having a success response of 200, leading to an empty result if the menu encountered any errors

Updated the code to only show output if the http response code is 200 From the AT documentation: > If we get a HTTP error response (Code 40X) from your script, or a malformed response (does not begin with CON or END), we will terminate the USSD session gracefully. Based on this, I see it best to return an error response instead of having a success response of 200, leading to an empty result if the menu encountered any errors
Alfred-mk added 2 commits 2024-09-18 14:32:58 +02:00
Alfred-mk requested review from lash 2024-09-18 14:34:32 +02:00
lash requested changes 2024-09-18 14:41:03 +02:00
lash left a comment
Owner
Copy Link

Add a test please?

Add a test please?
Alfred-mk changed title from at-return-output to WIP: at-return-output 2024-09-18 14:43:33 +02:00
Alfred-mk added 1 commit 2024-09-18 14:43:54 +02:00
This pull request is marked as a work in progress.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin at-return-output:at-return-output
git checkout at-return-output
Sign in to join this conversation.
Reviewers
No reviewers
lash
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Runner
AT

  
Runner
CLI

  
Runner
HTTP

  
cleanup

   
easy

A task that can be completed with little effort

  
optimization

   
refactor

   
smell

Code smell

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Runner
AT
Runner
CLI
Runner
HTTP
cleanup
easy
optimization
refactor
smell
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: urdt/ussd#63
No description provided.
Delete Branch "at-return-output"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?