urdt/ussd
5
0
Fork 0
Code Issues 34 Pull Requests Actions Packages Projects Releases Wiki Activity

Code refactor #66

Merged
lash merged 9 commits from wip-main-refactor into master 2024-09-19 20:19:17 +02:00
Conversation 0 Commits 9 Files Changed 6 +252 -447
carlos commented 2024-09-19 15:25:41 +02:00
Member
Copy Link

This PR motive is to perform code refactoring in the executables .

This PR motive is to perform code refactoring in the executables .
carlos added 5 commits 2024-09-19 15:25:42 +02:00
carlos added 1 commit 2024-09-19 16:01:50 +02:00
carlos changed title from WIP: Code refactor to Code refactor 2024-09-19 16:02:23 +02:00
carlos added 1 commit 2024-09-19 16:04:21 +02:00
lash requested changes 2024-09-19 18:09:21 +02:00
Dismissed
cmd/async/main.go
@ -48,86 +45,6 @@ func getFlags(fp string, debug bool) (*asm.FlagParser, error) {
return flagParser, nil
lash commented 2024-09-19 18:09:17 +02:00
Owner
Copy Link

could we factor out getFlags too please?

could we factor out getFlags too please?
carlos added 1 commit 2024-09-19 20:04:46 +02:00
lash approved these changes 2024-09-19 20:18:58 +02:00
lash added 1 commit 2024-09-19 20:19:08 +02:00
lash merged commit 7197382911 into master 2024-09-19 20:19:17 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
lash
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Runner
AT

  
Runner
CLI

  
Runner
HTTP

  
cleanup

   
easy

A task that can be completed with little effort

  
exchange

relating to swapping of assets and offramps

  
optimization

   
privilege

features that have to do with special, privileged axx

  
refactor

   
smell

Code smell

  
support

transparency and help with exception states

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Runner
AT
Runner
CLI
Runner
HTTP
cleanup
easy
exchange
optimization
privilege
refactor
smell
support
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: urdt/ussd#66
No description provided.
Delete Branch "wip-main-refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?