WIP: wip-menu-select-fix #72

Closed

carlos wants to merge 12 commits from wip-menu-select-fix into master

carlos commented

2024-09-20 13:48:46 +02:00

Member

This PR main change is on how language selection is done,it now uses the symbol name to decide the language selected.It also updates the affected unit tests

carlos added 10 commits 2024-09-20 13:48:46 +02:00

split symbol 8feee318b7

Merge remote-tracking branch 'remotes/origin/master' into wip-menu-select-fix 37c62f3d01

rename set_default to set_eng c75ca1b30b

rename set_default to set_eng aa18d41c81

add swahili view menu option 5898f8e87a

add swahili version f5ed1ce120

rename to set_eng 250341a8bd

add supported language codes 33f8733106

update tests a20e275db3

use symbol for language selection ffd091c9a9

carlos added 2 commits 2024-09-20 21:43:07 +02:00

add expected navigation paths for single edit df260c2288

use navigation path matching for case selection b54f3f32b5

carlos commented

2024-09-20 21:44:57 +02:00

Author

Member

@lash What do you think about using the execution path to decide if it is a single edit option selected?

lash commented

2024-09-20 22:57:19 +02:00

Owner

What do you think about using the execution path to decide if it is a single edit option selected?

To be honest this utils.GetSingleEditExecutionPath solution looks hacky, and suffers from a similar issue; it is dependent on more than just local information of the node. As in, what if the execution path changed later; we would have to remember to change this, too, independently.

In go-vise there is an example/profile did you have a look at that. Could something like that improve the situation?

@carlos

> What do you think about using the execution path to decide if it is a single edit option selected? To be honest this `utils.GetSingleEditExecutionPath` solution looks hacky, and suffers from a similar issue; it is dependent on more than just local information of the node. As in, what if the execution path changed later; we would have to remember to change this, too, independently. In go-vise there is an `example/profile` did you have a look at that. Could something like that improve the situation? @carlos

carlos closed this pull request

2024-09-23 09:46:03 +02:00