lash
0 Followers · 0 Following
  • Joined on 2021-10-26
Repositories
1
 Projects Packages Public Activity Starred Repositories
lash approved urdt/ussd#203 2024-12-05 16:03:45 +01:00
data-items-cleanup
lash commented on pull request urdt/ussd#199 2024-12-05 16:02:44 +01:00
profile-edit-traverse

IIRC this was the switch-case statement previously?. This can still be an array, and profileDataKeys[index] can address the index in the array?

lash suggested changes for urdt/ussd#199 2024-12-05 16:02:44 +01:00
profile-edit-traverse
lash commented on pull request urdt/ussd#203 2024-12-05 15:46:31 +01:00
data-items-cleanup

Sorry perhaps it wasn't clear. The "PREFIX" part in general is implied and a thus redundant. TX should suffice.

lash commented on pull request urdt/ussd#203 2024-12-05 15:46:31 +01:00
data-items-cleanup

So this should call IntToBytes then ;)

lash suggested changes for urdt/ussd#203 2024-12-05 15:46:31 +01:00
data-items-cleanup
lash commented on pull request urdt/ussd#203 2024-12-05 02:13:14 +01:00
data-items-cleanup

Perhaps better name DATA_VOUCHER_* ?

lash commented on pull request urdt/ussd#203 2024-12-05 02:13:14 +01:00
data-items-cleanup

I would start at 256 (0x0100), and keep the DATATYPE_USERDATA prefix.

lash commented on pull request urdt/ussd#203 2024-12-05 02:13:14 +01:00
data-items-cleanup

The prefix should be DATATYPE_USERDATA

lash suggested changes for urdt/ussd#203 2024-12-05 02:13:14 +01:00
data-items-cleanup
lash commented on pull request urdt/ussd#199 2024-12-04 16:59:44 +01:00
profile-edit-traverse

can we do this right now?

lash commented on pull request urdt/ussd#199 2024-12-04 16:59:44 +01:00
profile-edit-traverse

isn't it easier and less code to iterate a map?

lash commented on pull request urdt/ussd#199 2024-12-04 16:59:44 +01:00
profile-edit-traverse

are we still testing the case when profile information already has been set?

lash suggested changes for urdt/ussd#199 2024-12-04 16:59:44 +01:00
profile-edit-traverse
lash opened issue urdt/ussd#202 2024-12-04 16:51:57 +01:00
Add devtool to restart user state
lash opened issue urdt/ussd#201 2024-12-04 16:49:22 +01:00
Force restart of state on different request id
lash pushed to master at urdt/ussd 2024-12-03 18:18:25 +01:00
22c9c3e0f0 Merge pull request 'minor-bug-fixes' (#177) from minor-bug-fixes into master
a709d24520 Merge branch 'master' into minor-bug-fixes
d40a4a171f formatted code
ba430a5849 add a separate function to handle ConstructName
0f21b01813 resolved error in the TestViewVoucher
Compare 27 commits »
lash merged pull request urdt/ussd#177 2024-12-03 18:18:23 +01:00
minor-bug-fixes
lash pushed to minor-bug-fixes at urdt/ussd 2024-12-03 18:16:21 +01:00
a709d24520 Merge branch 'master' into minor-bug-fixes
e56138e416 Merge pull request 'Clear persister from handler in outer code aswell' (#200) from lash/persister-freakout into master
d516584d90 Clear persister from handler in outer code aswell
Compare 3 commits »
lash merged pull request urdt/ussd#200 2024-12-03 17:18:12 +01:00
Clear persister from handler in outer code aswell