lash
0 Followers · 0 Following
  • Joined on 2021-10-26
Repositories
1
 Projects Packages Public Activity Starred Repositories
lash suggested changes for urdt/ussd#53 2024-09-14 16:34:57 +02:00
menu-options-help

it looks like code not pertaining to help is also in here. please remove.

lash opened issue urdt/ussd#54 2024-09-14 16:30:28 +02:00
AT should not return CON on status != 200
lash pushed to lash/async-driver at urdt/ussd 2024-09-14 16:28:07 +02:00
f4f475bd45 Merge pull request 'africas-talking' (#50) from africas-talking into lash/async-driver
6fe2e7287f Update the func name to Output
1e9c9cf6ad removed AT specific code
3cb0b099e4 use the new AtSessionHandler
b53658e038 have AtOutput as an option
Compare 9 commits »
lash merged pull request urdt/ussd#50 2024-09-14 16:28:06 +02:00
africas-talking
lash approved urdt/ussd#50 2024-09-14 16:28:00 +02:00
africas-talking
lash opened issue urdt/ussd#52 2024-09-14 14:36:09 +02:00
use engine adaptation instead of basehandler to handle AT request and response
lash commented on pull request urdt/ussd#51 2024-09-14 01:37:39 +02:00
menu-options

This should be a config variable. Let's put it as a global variable for now.

lash commented on pull request urdt/ussd#51 2024-09-14 01:37:39 +02:00
menu-options

can you please put the pin length in a global variable and replace all similar occurrences and check with that?

lash commented on pull request urdt/ussd#51 2024-09-14 01:37:39 +02:00
menu-options

this test does not pass

lash suggested changes for urdt/ussd#51 2024-09-14 01:37:39 +02:00
menu-options

Help menu does not work as expected here:

lash commented on pull request urdt/ussd#50 2024-09-13 16:33:27 +02:00
africas-talking

In general, chainable functions should be called ON the object instead of being an argument TO The object.

lash commented on pull request urdt/ussd#50 2024-09-13 16:33:27 +02:00
africas-talking

In fact, I should have implemented this as chainable, too. My bad.

lash commented on pull request urdt/ussd#50 2024-09-13 16:33:27 +02:00
africas-talking

It would be better to have this PR against my async branch, because here we cannot see the differences....

lash commented on pull request urdt/ussd#50 2024-09-13 16:33:27 +02:00
africas-talking

This method should not exist in the base handler. Please EXTEND the handler to adapt it to your needs.

lash commented on pull request urdt/ussd#50 2024-09-13 16:33:27 +02:00
africas-talking

Similary here, Please do not put AT speicifc code in the generic http code. Please use your own extension of the class.

lash suggested changes for urdt/ussd#50 2024-09-13 16:33:27 +02:00
africas-talking
lash pushed to lash/async-driver at urdt/ussd 2024-09-12 17:46:27 +02:00
9b4a4eeaf4 Temporary solution for make sure storage object gets put back in all cases of execution
lash commented on issue urdt/ussd#48 2024-09-12 15:41:22 +02:00
HTTP stuck on 500 after multiple requests while account created

The crash cites that a persister is already set, suggesting that the persister / engine is not being properly reset in certain cases.

lash pushed to lash/async-driver at urdt/ussd 2024-09-12 05:19:30 +02:00
9c751aff30 Update go-vise
lash created pull request urdt/ussd#49 2024-09-12 05:17:57 +02:00
Enable CLI driver of async session