urdt/ussd
5
0
Fork 0
Code Issues 33 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Enable CLI driver of async session #49

Merged
lash merged 14 commits from lash/async-driver into master 2024-09-14 16:52:07 +02:00
Conversation 0 Commits 14 Files Changed 10 +848 -100
lash commented 2024-09-12 05:17:57 +02:00
Owner
Copy Link

This PR refactors the HTTP handler by extracting all code not http specific to internal/handlers/*.go

It introduces an interface RequestSession that gets passed around different phases of request lifetime.

Also added is a new CLI tool cmd/async/main.go which drives the same asynchronous code execution as the http requests, but without the added overhead of using curl, postman etc.

This PR refactors the HTTP handler by extracting all code not http specific to internal/handlers/*.go It introduces an interface RequestSession that gets passed around different phases of request lifetime. Also added is a new CLI tool `cmd/async/main.go` which drives the same asynchronous code execution as the http requests, but without the added overhead of using curl, postman etc.
lash added 3 commits 2024-09-12 05:17:57 +02:00
lash added 1 commit 2024-09-12 05:19:30 +02:00
lash added 1 commit 2024-09-12 17:46:27 +02:00
lash added 9 commits 2024-09-14 16:28:07 +02:00 
Signed-off-by: Alfred Kamanda <alfredkamandamw@gmail.com>
Reviewed-on: #50
Reviewed-by: lash <accounts-grassrootseconomics@holbrook.no>
lash merged commit b5d33a98f0 into master 2024-09-14 16:52:07 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

  
Runner
AT

  
Runner
CLI

  
Runner
HTTP

  
cleanup

   
easy

A task that can be completed with little effort

  
optimization

   
refactor

   
smell

Code smell

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Runner
AT
Runner
CLI
Runner
HTTP
cleanup
easy
optimization
refactor
smell
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: urdt/ussd#49
No description provided.
Delete Branch "lash/async-driver"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?