urdt/ussd
5
0
Fork 1
Code Issues 41 Pull Requests Actions Packages Projects Releases Wiki Activity

profile-edit-traverse #199

Merged
lash merged 26 commits from profile-edit-traverse into master 2024-12-05 16:37:37 +01:00
Conversation 3 Commits 26 Files Changed 25 +723 -99
carlos commented 2024-12-03 09:26:11 +01:00
Member
Copy Link

Fixes:
#80
#186

Fixes: #80 #186
carlos added 5 commits 2024-12-03 09:26:12 +01:00
add required profile edit flags fd586d09c3
add handler to update profile items 3e0bbe5ffe
allow all item profile edit 48e1b02e0e
add profile holder struct 944fa89b3c
allow sequential profile edit a72fb08dc8
carlos added 3 commits 2024-12-03 12:41:20 +01:00
catch next unset profile item 1c7c0af712
add a zero pad value to unfilled profile item 9e998f9a29
allow sequential profile edit e0ec15b272
carlos added 2 commits 2024-12-03 15:41:28 +01:00
explicit reload save gender a20ab79355
set flag if profile data is set b420a9bba0
carlos added 2 commits 2024-12-03 20:30:57 +01:00
catch incorrect pin entries c0ed6fa9c8
Merge branch 'master' into profile-edit-traverse 91cd6077ce
carlos added 4 commits 2024-12-04 06:30:50 +01:00
add flag to catch back navigations c4282a870e
catch back navigations c5ebdbf85b
add handler for catching back navigations 5c202741d6
add doc lines and check for back naviagtions ed632248c5
carlos added 2 commits 2024-12-04 07:09:06 +01:00
update tests e7c4b5bca7
set flag when location is set 8efed966a0
carlos added 1 commit 2024-12-04 07:46:33 +01:00
update menu traversal test data a84c3e0852
carlos changed title from WIP: profile-edit-traverse to profile-edit-traverse 2024-12-04 11:06:24 +01:00
lash requested changes 2024-12-04 16:59:40 +01:00
Dismissed
internal/handlers/ussd/menuhandler.go
@@ -680,0 +731,4 @@
func (h *Handlers) SetBack(ctx context.Context, sym string, input []byte) (resource.Result, error) {
var res resource.Result
//TODO:
//Add check if the navigation is lateral nav instead of checking the input.
lash commented 2024-12-04 16:55:51 +01:00
Owner
Copy Link

can we do this right now?

can we do this right now?
carlos commented 2024-12-05 13:12:33 +01:00
Author
Member
Copy Link

Based on tests i have done so far,it seems the INCMP _ 0 does not make the st.Lateral() evaluate to true,this will need some investigation or clarification if it is the expected behaviour.If this is the case, then we will probably need something similar to this to be able to do away with the input check for back.

Based on tests i have done so far,it seems the INCMP _ 0 does not make the st.Lateral() evaluate to true,this will need some investigation or clarification if it is the expected behaviour.If this is the case, then we will probably need something similar to this to be able to do away with the input check for back.
👍 1
internal/handlers/ussd/menuhandler.go Outdated
@@ -1879,0 +1966,4 @@
"flag_location_set",
"flag_offerings_set",
}
for index, profileItem := range h.profile.ProfileItems {
lash commented 2024-12-04 16:58:10 +01:00
Owner
Copy Link

isn't it easier and less code to iterate a map?

isn't it easier and less code to iterate a map?
carlos commented 2024-12-05 13:14:38 +01:00
Author
Member
Copy Link

handled by commit: 321f038c7c

handled by commit: 321f038c7ce4492d05bd35572e68d669b7c05a9b
menutraversal_test/group_test.json
@@ -187,6 +187,26 @@
},
{
"input": "foo",
"expectedContent": "Enter family name:\n0:Back"
lash commented 2024-12-04 16:59:35 +01:00
Owner
Copy Link

are we still testing the case when profile information already has been set?

how about the test case where item 1 and 3 has been set, and we start at 2?

are we still testing the case when profile information already _has_ been set? how about the test case where item 1 and 3 has been set, and we start at 2?
carlos commented 2024-12-05 13:32:30 +01:00
Author
Member
Copy Link

Yes ,there're test cases for when profile information is already set,i've added more test data files to handle the different test scenarios when editing the profile and for clarity: 22f96363ba

Yes ,there're test cases for when profile information is already set,i've added more test data files to handle the different test scenarios when editing the profile and for clarity: 22f96363ba61352cc23868f5f0d26b75915e0971
carlos added 1 commit 2024-12-05 09:15:53 +01:00
iterate over a map for the set profile items 321f038c7c
carlos added 1 commit 2024-12-05 10:22:46 +01:00
update test names 3e7f90733e
carlos added 2 commits 2024-12-05 12:06:22 +01:00
add test files 22f96363ba
read test file from test run arg 160ccbb220
carlos added 1 commit 2024-12-05 14:03:40 +01:00
add test data. 72a3681767
lash requested changes 2024-12-05 16:02:44 +01:00
Dismissed
internal/handlers/ussd/menuhandler.go Outdated
@@ -1879,0 +1966,4 @@
"flag_location_set",
"flag_offerings_set",
}
profileDataKeys := map[int]common.DataTyp{
lash commented 2024-12-05 16:02:36 +01:00
Owner
Copy Link

IIRC this was the switch-case statement previously?. This can still be an array, and profileDataKeys[index] can address the index in the array?

IIRC this was the switch-case statement previously?. This can still be an array, and profileDataKeys[index] can address the index in the array?
carlos added 1 commit 2024-12-05 16:26:12 +01:00
chore: use profileDataKeys as an array 9cbbdff993
carlos added 1 commit 2024-12-05 16:34:50 +01:00
Merge branch 'master' into profile-edit-traverse 8e6b1e6f52
lash approved these changes 2024-12-05 16:37:29 +01:00
lash merged commit 43892f0d8c into master 2024-12-05 16:37:37 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
lash
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Activity
Doing
An item actively being worked on currently
Activity
Hold
Not being actively worked on
Activity
Proposal
A proposal for a new feature or enhancement
Activity
QA
Ready for QA testing
Activity
Validate
Dev team validating changes
Runner
AT
Runner
CLI
Runner
HTTP
Runner
SSH
cleanup
devops
documentation
easypeasy
A task that can be completed with little effort
 exchange
relating to swapping of assets and offramps
 i18n
Languages and translations
 legacy
Legacy features from the old ussd system to be ported
 meta
container for other issues
 migration
optimization
privilege
features that have to do with special, privileged axx
 refactor
smell
Code smell
 support
transparency and help with exception states
 tooling
ux
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Alfred-mk carlos kamikazechaser lash willruddick
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: urdt/ussd#199
Delete Branch "profile-edit-traverse"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?