profile-edit-traverse #199
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: urdt/ussd#199
Reference in New Issue
Block a user
Fixes:
#80
#186
@@ -680,0 +731,4 @@func (h *Handlers) SetBack(ctx context.Context, sym string, input []byte) (resource.Result, error) {var res resource.Result//TODO://Add check if the navigation is lateral nav instead of checking the input.can we do this right now?
Based on tests i have done so far,it seems the INCMP _ 0 does not make the st.Lateral() evaluate to true,this will need some investigation or clarification if it is the expected behaviour.If this is the case, then we will probably need something similar to this to be able to do away with the input check for back.
@@ -1879,0 +1966,4 @@"flag_location_set","flag_offerings_set",}for index, profileItem := range h.profile.ProfileItems {isn't it easier and less code to iterate a map?
handled by commit:
321f038c7c@@ -187,6 +187,26 @@},{"input": "foo","expectedContent": "Enter family name:\n0:Back"are we still testing the case when profile information already has been set?
how about the test case where item 1 and 3 has been set, and we start at 2?
Yes ,there're test cases for when profile information is already set,i've added more test data files to handle the different test scenarios when editing the profile and for clarity:
22f96363ba@@ -1879,0 +1966,4 @@"flag_location_set","flag_offerings_set",}profileDataKeys := map[int]common.DataTyp{IIRC this was the switch-case statement previously?. This can still be an array, and profileDataKeys[index] can address the index in the array?