lash
0 Followers · 0 Following
  • Joined on 2021-10-26
Repositories
1
 Projects Packages Public Activity Starred Repositories
lash pushed to master at grassrootseconomics/sarafu-api 2025-01-21 14:52:44 +01:00
e0b5398098 Merge remote-tracking branch 'origin/master' into lash/alias-deps
b7e53609a9 Upgrade deps
Compare 2 commits »
lash pushed to master at grassrootseconomics/visedriver 2025-01-21 14:49:31 +01:00
f7d31e4e81 Update deps
90ecec1798 rehabilitate storage test
874edb3da6 Apply session on the menuhandler store returns
60ff1b0ab3 Set up multiple conns in config
9b3dad579b Set up multiple conns in config
Compare 12 commits »
lash pushed to master at grassrootseconomics/common 2025-01-21 14:47:37 +01:00
ba8cbbccea Merge pull request 'allow period for the alias' (#1) from alias-period into master
b4cd696f48 test alias regex
3e859d3469 allow period for the alias regex
26b53c79df allow period for the alias
Compare 4 commits »
lash merged pull request grassrootseconomics/common#1 2025-01-21 14:47:36 +01:00
allow period for the alias
lash pushed to lash/dbtx at grassrootseconomics/sarafu-vise 2025-01-21 14:46:00 +01:00
341f0b9cc8 Merge branch 'master' into lash/dbtx
1c911ee73f Merge branch 'master' into lash/dbtx
00b9079a55 Clean up spaces
156511e499 Build vise-asm binary in makefile
8b68130ed4 Remove bin files
Compare 9 commits »
lash merged pull request grassrootseconomics/sarafu-vise#13 2025-01-21 07:47:34 +01:00
reset account blocked flag
lash pushed to master at grassrootseconomics/sarafu-vise 2025-01-21 07:47:34 +01:00
7d513ac2a7 Merge pull request 'reset account blocked flag' (#13) from reset-account-blocked-flag into master
fbee26da08 added CheckBlockedStatus to reset the flag_account_blocked if the incorrect PIN attempt has been reset
4fb3474b51 reset the incorrect PIN attempts to 0 when the PIN is reset
Compare 3 commits »
lash commented on pull request grassrootseconomics/sarafu-vise#13 2025-01-21 07:42:27 +01:00
reset account blocked flag

Hmm. Ok. It's not entirely clear to me why it is like this, as any point where the pin is reset would simply enable to set the flag as reset? There would be no need to read the flag?

lash pushed to master at grassrootseconomics/sarafu-api 2025-01-21 07:17:10 +01:00
a4cc7d2a98 Merge pull request 'dev-api-aliases' (#5) from dev-api-aliases into master
a63164bcf5 fix failing test
fa355e3729 handle accounts created via the api,add getter for the account aliases
99c704f6ff implement request alias based on dev implementation
ed549cba70 bind session id for aliases,soft code voucher balance
Compare 7 commits »
lash merged pull request grassrootseconomics/sarafu-api#5 2025-01-21 07:17:09 +01:00
dev-api-aliases
lash commented on pull request grassrootseconomics/sarafu-vise#13 2025-01-21 07:12:23 +01:00
reset account blocked flag

why is the check for incorrect pin attempts needed here? Why not just put it as part of the incorrect pin reset? Wouldn't that reduce the need for one read operation?

lash commented on pull request grassrootseconomics/sarafu-api#5 2025-01-20 18:31:04 +01:00
dev-api-aliases

no its fine here, it's for dev only anyway.

lash commented on pull request grassrootseconomics/sarafu-api#5 2025-01-20 18:30:29 +01:00
dev-api-aliases

yes for sure, while we wait or the api implementation.

lash commented on pull request grassrootseconomics/common#1 2025-01-20 16:31:06 +01:00
allow period for the alias

perhaps we can test it too?

foo foo.bar foo.bar.baz

and a couple of wrongs like

.foo foo..bar etc

lash commented on pull request grassrootseconomics/common#1 2025-01-20 16:27:00 +01:00
allow period for the alias

Actually this should be previous regex then followed by 1+ dot-prefixed alphanumerics something like ^[a-zA-Z0-9]+(\.[a-zA-Z0.9])*$

lash suggested changes for grassrootseconomics/common#1 2025-01-20 16:27:00 +01:00
allow period for the alias
lash commented on pull request grassrootseconomics/sarafu-api#5 2025-01-20 16:25:11 +01:00
dev-api-aliases

THe searchdomain should not be necessary here

lash commented on pull request grassrootseconomics/sarafu-api#5 2025-01-20 16:25:11 +01:00
dev-api-aliases

Can't we just point this to devapi.RequestAlias?

lash commented on pull request grassrootseconomics/sarafu-api#5 2025-01-20 16:25:11 +01:00
dev-api-aliases

Export please

lash commented on pull request grassrootseconomics/sarafu-api#5 2025-01-20 16:25:11 +01:00
dev-api-aliases

remove commentedp lease